Re: [PATCH] drm/amdgpu: disable page queue support for Vega20
Am 21.11.18 um 07:40 schrieb Evan Quan: Keep it disabled until we confirm it's ready. Change-Id: I2dc4c0f1156dd82f7046672fed6d22b9d18c2010 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 0a3b68dd49a0..e6cb2c399957 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c @@ -1457,7 +1457,8 @@ static bool sdma_v4_0_fw_support_paging_queue(struct amdgpu_device *adev) case CHIP_VEGA12: return fw_version >= 31; case CHIP_VEGA20: - return fw_version >= 115; + //return fw_version >= 115; + return false; Please don't use "//" in kernel code to comment things out. Christian. default: return false; } ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu: disable page queue support for Vega20
Do we need this for vega12 as well? From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, November 21, 2018 2:25:06 AM To: Quan, Evan Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: disable page queue support for Vega20 Reviewed-by: Alex Deucher On Wed, Nov 21, 2018 at 1:40 AM Evan Quan wrote: > > Keep it disabled until we confirm it's ready. > > Change-Id: I2dc4c0f1156dd82f7046672fed6d22b9d18c2010 > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > index 0a3b68dd49a0..e6cb2c399957 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -1457,7 +1457,8 @@ static bool sdma_v4_0_fw_support_paging_queue(struct > amdgpu_device *adev) > case CHIP_VEGA12: > return fw_version >= 31; > case CHIP_VEGA20: > - return fw_version >= 115; > + //return fw_version >= 115; > + return false; > default: > return false; > } > -- > 2.19.1 > > ___ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdgpu: disable page queue support for Vega20
Reviewed-by: Alex Deucher On Wed, Nov 21, 2018 at 1:40 AM Evan Quan wrote: > > Keep it disabled until we confirm it's ready. > > Change-Id: I2dc4c0f1156dd82f7046672fed6d22b9d18c2010 > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > index 0a3b68dd49a0..e6cb2c399957 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -1457,7 +1457,8 @@ static bool sdma_v4_0_fw_support_paging_queue(struct > amdgpu_device *adev) > case CHIP_VEGA12: > return fw_version >= 31; > case CHIP_VEGA20: > - return fw_version >= 115; > + //return fw_version >= 115; > + return false; > default: > return false; > } > -- > 2.19.1 > > ___ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdgpu: disable page queue support for Vega20
Keep it disabled until we confirm it's ready. Change-Id: I2dc4c0f1156dd82f7046672fed6d22b9d18c2010 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 0a3b68dd49a0..e6cb2c399957 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c @@ -1457,7 +1457,8 @@ static bool sdma_v4_0_fw_support_paging_queue(struct amdgpu_device *adev) case CHIP_VEGA12: return fw_version >= 31; case CHIP_VEGA20: - return fw_version >= 115; + //return fw_version >= 115; + return false; default: return false; } -- 2.19.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
