Re: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

2016-10-11 Thread Andy Furniss 

I can boot OK with this.

Christian König wrote:

From: Christian König 

Add type, align_mask and nop to the physical mode VCE funcs as well.

Signed-off-by: Christian König 
---
  drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c 
b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
index f7dbd0d..c7ddbef 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
@@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
  };

  static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
+   .type = AMDGPU_RING_TYPE_VCE,
+   .align_mask = 0xf,
+   .nop = VCE_CMD_NO_OP,
.get_rptr = vce_v3_0_ring_get_rptr,
.get_wptr = vce_v3_0_ring_get_wptr,
.set_wptr = vce_v3_0_ring_set_wptr,



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

2016-10-11 Thread Deucher, Alexander 
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Tuesday, October 11, 2016 1:34 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode
> 
> From: Christian König <christian.koe...@amd.com>
> 
> Add type, align_mask and nop to the physical mode VCE funcs as well.
> 
> Signed-off-by: Christian König <christian.koe...@amd.com>


Please update uvd6 physical mode as well.

Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> index f7dbd0d..c7ddbef 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> @@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
>  };
> 
>  static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
> + .type = AMDGPU_RING_TYPE_VCE,
> + .align_mask = 0xf,
> + .nop = VCE_CMD_NO_OP,
>   .get_rptr = vce_v3_0_ring_get_rptr,
>   .get_wptr = vce_v3_0_ring_get_wptr,
>   .set_wptr = vce_v3_0_ring_set_wptr,
> --
> 2.5.0
> 
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

2016-10-11 Thread StDenis, Tom 
Yup, with it I get a normal modprobe.


Can add my


Ack-By: Tom St Denis <tom.stde...@amd.com>



From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Christian 
König <deathsim...@vodafone.de>
Sent: Tuesday, October 11, 2016 13:33
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

From: Christian König <christian.koe...@amd.com>

Add type, align_mask and nop to the physical mode VCE funcs as well.

Signed-off-by: Christian König <christian.koe...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c 
b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
index f7dbd0d..c7ddbef 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
@@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
 };

 static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
+   .type = AMDGPU_RING_TYPE_VCE,
+   .align_mask = 0xf,
+   .nop = VCE_CMD_NO_OP,
 .get_rptr = vce_v3_0_ring_get_rptr,
 .get_wptr = vce_v3_0_ring_get_wptr,
 .set_wptr = vce_v3_0_ring_set_wptr,
--
2.5.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - 
lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx 
Archives. Using amd-gfx: To post a message to all the list members, send email 
...



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: fix broken VCE startup in phys mode

2016-10-11 Thread Christian König 
From: Christian König 

Add type, align_mask and nop to the physical mode VCE funcs as well.

Signed-off-by: Christian König 
---
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c 
b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
index f7dbd0d..c7ddbef 100644
--- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
@@ -829,6 +829,9 @@ const struct amd_ip_funcs vce_v3_0_ip_funcs = {
 };
 
 static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
+   .type = AMDGPU_RING_TYPE_VCE,
+   .align_mask = 0xf,
+   .nop = VCE_CMD_NO_OP,
.get_rptr = vce_v3_0_ring_get_rptr,
.get_wptr = vce_v3_0_ring_get_wptr,
.set_wptr = vce_v3_0_ring_set_wptr,
-- 
2.5.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx