Re: [PATCH] drm/amdgpu: log when amdgpu.dc=1 but ASIC is unsupported

2019-12-11 Thread Alex Deucher 
On Wed, Dec 11, 2019 at 5:27 AM Simon Ser  wrote:
>
> This makes it easier to figure out whether the kernel parameter has been
> taken into account.
>
> Signed-off-by: Simon Ser 
> Cc: Harry Wentland 
> Cc: Alex Deucher 

Applied. thanks.

Alex


> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 7a6c837c0a85..10618353383f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2525,6 +2525,9 @@ bool amdgpu_device_asic_has_dc_support(enum 
> amd_asic_type asic_type)
> return amdgpu_dc != 0;
>  #endif
> default:
> +   if (amdgpu_dc > 0)
> +   DRM_INFO("Display Core has been requested via kernel 
> parameter "
> +"but isn't supported by ASIC, 
> ignoring\n");
> return false;
> }
>  }
> --
> 2.24.0
>
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: log when amdgpu.dc=1 but ASIC is unsupported

2019-12-11 Thread Simon Ser 
This makes it easier to figure out whether the kernel parameter has been
taken into account.

Signed-off-by: Simon Ser 
Cc: Harry Wentland 
Cc: Alex Deucher 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 7a6c837c0a85..10618353383f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2525,6 +2525,9 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type 
asic_type)
return amdgpu_dc != 0;
 #endif
default:
+   if (amdgpu_dc > 0)
+   DRM_INFO("Display Core has been requested via kernel 
parameter "
+"but isn't supported by ASIC, 
ignoring\n");
return false;
}
 }
--
2.24.0


___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx