RE: [PATCH] drm/amdgpu: make rlc fw loading backward compatible with fw

2022-09-26 Thread Gao, Likun
[AMD Official Use Only - General]

Reviewed-by: Likun Gao .

Regards,
Likun

-Original Message-
From: Zhang, Hawking  
Sent: Tuesday, September 27, 2022 10:30 AM
To: amd-gfx@lists.freedesktop.org; Gao, Likun ; Deucher, 
Alexander 
Cc: Zhang, Hawking 
Subject: [PATCH] drm/amdgpu: make rlc fw loading backward compatible with fw

To allow kernel change
drm/amdgpu/gfx10: switch to amdgpu_gfx_rlc_init_microcode backward compatible 
with old rlc firmware

Signed-off-by: Hawking Zhang 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
index 792333206362..012b72d00e04 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
@@ -537,9 +537,9 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device 
*adev,
amdgpu_gfx_rlc_init_microcode_v2_1(adev);
if (version_minor >= 2)
amdgpu_gfx_rlc_init_microcode_v2_2(adev);
-   if (version_minor >= 3)
+   if (version_minor == 3)
amdgpu_gfx_rlc_init_microcode_v2_3(adev);
-   if (version_minor >= 4)
+   if (version_minor == 4)
amdgpu_gfx_rlc_init_microcode_v2_4(adev);
 
return 0;
--
2.17.1


[PATCH] drm/amdgpu: make rlc fw loading backward compatible with fw

2022-09-26 Thread Hawking Zhang
To allow kernel change
drm/amdgpu/gfx10: switch to amdgpu_gfx_rlc_init_microcode
backward compatible with old rlc firmware

Signed-off-by: Hawking Zhang 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
index 792333206362..012b72d00e04 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c
@@ -537,9 +537,9 @@ int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device 
*adev,
amdgpu_gfx_rlc_init_microcode_v2_1(adev);
if (version_minor >= 2)
amdgpu_gfx_rlc_init_microcode_v2_2(adev);
-   if (version_minor >= 3)
+   if (version_minor == 3)
amdgpu_gfx_rlc_init_microcode_v2_3(adev);
-   if (version_minor >= 4)
+   if (version_minor == 4)
amdgpu_gfx_rlc_init_microcode_v2_4(adev);
 
return 0;
-- 
2.17.1