[AMD Public Use]
Hi John,
The patch is good. However, maybe it's better we can improve the patch commit
message title/body together a bit.
Generally, original title 'resolve bug...' is not pretty clear to audience. If
possible, we can modify the title to 'correct fw start address', and in message
body, illustrate why the patch is needed.
With the comment addressed, the patch is:
Reviewed-by: Guchun Chen
Regards,
Guchun
From: Clements, John
Sent: Wednesday, July 15, 2020 2:44 PM
To: amd-gfx list ; Lakha, Bhawanpreet
; Zhang, Hawking ; Chen,
Guchun
Subject: [PATCH] drm/amdgpu: resolve bug in ta microcode init
[AMD Public Use]
Submitting patch for review to resolve bug when calculating FW offset within
binaries with PSP TA v2 header.
Thank you,
John Clements
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
