Re: [PATCH] drm/amdgpu: skip BAR resizing if the bios already did it

2020-06-08 Thread Felix Kuehling
Am 2020-06-08 um 3:41 p.m. schrieb Alex Deucher:
> No need to do it again.
>
> Signed-off-by: Alex Deucher 

Acked-by: Felix Kuehling 


> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 1df28b7bf22e..539010798116 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -909,6 +909,11 @@ int amdgpu_device_resize_fb_bar(struct amdgpu_device 
> *adev)
>   if (amdgpu_sriov_vf(adev))
>   return 0;
>  
> + /* skip if the bios has already enabled large BAR */
> + if (adev->gmc.real_vram_size &&
> + (pci_resource_len(adev->pdev, 0) >= adev->gmc.real_vram_size))
> + return 0;
> +
>   /* Check if the root BUS has 64bit memory resources */
>   root = adev->pdev->bus;
>   while (root->parent)
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


Re: [PATCH] drm/amdgpu: skip BAR resizing if the bios already did it

2020-06-08 Thread Christian König

Am 08.06.20 um 21:41 schrieb Alex Deucher:

No need to do it again.

Signed-off-by: Alex Deucher 


Reviewed-by: Christian König 


---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +
  1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 1df28b7bf22e..539010798116 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -909,6 +909,11 @@ int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
if (amdgpu_sriov_vf(adev))
return 0;
  
+	/* skip if the bios has already enabled large BAR */

+   if (adev->gmc.real_vram_size &&
+   (pci_resource_len(adev->pdev, 0) >= adev->gmc.real_vram_size))
+   return 0;
+
/* Check if the root BUS has 64bit memory resources */
root = adev->pdev->bus;
while (root->parent)


___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH] drm/amdgpu: skip BAR resizing if the bios already did it

2020-06-08 Thread Alex Deucher
No need to do it again.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 1df28b7bf22e..539010798116 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -909,6 +909,11 @@ int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
if (amdgpu_sriov_vf(adev))
return 0;
 
+   /* skip if the bios has already enabled large BAR */
+   if (adev->gmc.real_vram_size &&
+   (pci_resource_len(adev->pdev, 0) >= adev->gmc.real_vram_size))
+   return 0;
+
/* Check if the root BUS has 64bit memory resources */
root = adev->pdev->bus;
while (root->parent)
-- 
2.25.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx