Re: [PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
On 2019-11-13 5:50 p.m., Yong Zhao wrote: After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 ++-- .../amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_v9.c} | 0 .../amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_v9.c} (100%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (100%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..61474627a32c 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_v9.o \ $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 ++-- .../amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_v9.c} | 0 .../amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_v9.c} (100%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (100%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..61474627a32c 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_v9.o \ $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c -- 2.17.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
On 2019-11-13 5:39 p.m., Yong Zhao wrote: After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. NAK. Like I mentioned in the other email, AI refers to the SOC generation by its deprecated code name that predates the Vega code name. I also want to avoid having a mix of kfd_*_v9 and kfd_*_ai files and functions referring to the same GFX generation. Regards, Felix Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 +-- .../gpu/drm/amd/amdkfd/kfd_packet_manager.c | 4 +-- ...nel_queue_v9.c => kfd_packet_manager_ai.c} | 26 +-- ...nel_queue_vi.c => kfd_packet_manager_vi.c} | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 4 +-- 5 files changed, 20 insertions(+), 20 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} (94%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (99%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..55bfecf04239 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_ai.o \ $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c index 6cabed06ef5d..cc945a2acd66 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c @@ -233,7 +233,7 @@ int pm_init(struct packet_manager *pm, struct device_queue_manager *dqm) case CHIP_POLARIS11: case CHIP_POLARIS12: case CHIP_VEGAM: - pm->pmf = _vi_pm_funcs; + pm->pmf = _pm_funcs_vi; break; case CHIP_VEGA10: case CHIP_VEGA12: @@ -244,7 +244,7 @@ int pm_init(struct packet_manager *pm, struct device_queue_manager *dqm) case CHIP_NAVI10: case CHIP_NAVI12: case CHIP_NAVI14: - pm->pmf = _v9_pm_funcs; + pm->pmf = _pm_funcs_ai; break; default: WARN(1, "Unexpected ASIC family %u", diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c similarity index 94% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c index 2de01009f1b6..713530cd9760 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c @@ -27,7 +27,7 @@ #include "kfd_pm4_opcodes.h" #include "gc/gc_10_1_0_sh_mask.h" -static int pm_map_process_v9(struct packet_manager *pm, +static int pm_map_process_ai(struct packet_manager *pm, uint32_t *buffer, struct qcm_process_device *qpd) { struct pm4_mes_map_process *packet; @@ -73,7 +73,7 @@ static int pm_map_process_v9(struct packet_manager *pm, return 0; } -static int pm_runlist_v9(struct packet_manager *pm, uint32_t *buffer, +static int pm_runlist_ai(struct packet_manager *pm, uint32_t *buffer, uint64_t ib, size_t ib_size_in_dwords, bool chain) { struct pm4_mes_runlist *packet; @@ -111,7 +111,7 @@ static int pm_runlist_v9(struct packet_manager *pm, uint32_t *buffer, return 0; } -static int pm_set_resources_v9(struct packet_manager *pm, uint32_t *buffer, +static int pm_set_resources_ai(struct packet_manager *pm, uint32_t *buffer, struct scheduling_resources *res) { struct pm4_mes_set_resources *packet; @@ -139,7 +139,7 @@ static int pm_set_resources_v9(struct packet_manager *pm, uint32_t *buffer, return 0; } -static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer, +static int pm_map_queues_ai(struct packet_manager *pm, uint32_t *buffer, struct queue *q, bool is_static) { struct pm4_mes_map_queues *packet; @@ -206,7 +206,7 @@ static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer, return 0; } -static int pm_unmap_queues_v9(struct packet_manager *pm, uint32_t *buffer,
Re: [PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
On 2019-11-13 5:26 p.m., Yong Zhao wrote: Oh, I did not realize the part inside of the file. I think v9->ai is better, because the packet format header uses ai. Also v9 will give people an impression of gfx9. There are a lot of other places in KFD that use the "v9" suffix. Like I said, if we decide to change this, it will affect lots of other KFD files and functions. The code in the packet manager deals with the MEC, which is part of the GFX engine. So referring to the GFX version (v9) makes sense. AI refers to the whole SOC generation by its deprecated code name that the Vega code name for the SOC that's used elsewhere in the code. Regards, Felix Yong On 2019-11-13 5:19 p.m., Felix Kuehling wrote: On 2019-11-13 5:09 p.m., Yong Zhao wrote: After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 ++-- .../amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} | 0 .../amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} (100%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (100%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..55bfecf04239 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_ai.o \ This naming convention is inconsistent with the rest of KFD. We use _v9, not _ai. Also the function s inside this file are named _v9. If we decide to change that naming convention, it should not be accidental and piece-meal. It should be deliberate and comprehensive. Regards, Felix $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 +-- .../gpu/drm/amd/amdkfd/kfd_packet_manager.c | 4 +-- ...nel_queue_v9.c => kfd_packet_manager_ai.c} | 26 +-- ...nel_queue_vi.c => kfd_packet_manager_vi.c} | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 4 +-- 5 files changed, 20 insertions(+), 20 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} (94%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (99%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..55bfecf04239 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_ai.o \ $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c index 6cabed06ef5d..cc945a2acd66 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c @@ -233,7 +233,7 @@ int pm_init(struct packet_manager *pm, struct device_queue_manager *dqm) case CHIP_POLARIS11: case CHIP_POLARIS12: case CHIP_VEGAM: - pm->pmf = _vi_pm_funcs; + pm->pmf = _pm_funcs_vi; break; case CHIP_VEGA10: case CHIP_VEGA12: @@ -244,7 +244,7 @@ int pm_init(struct packet_manager *pm, struct device_queue_manager *dqm) case CHIP_NAVI10: case CHIP_NAVI12: case CHIP_NAVI14: - pm->pmf = _v9_pm_funcs; + pm->pmf = _pm_funcs_ai; break; default: WARN(1, "Unexpected ASIC family %u", diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c similarity index 94% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c index 2de01009f1b6..713530cd9760 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c @@ -27,7 +27,7 @@ #include "kfd_pm4_opcodes.h" #include "gc/gc_10_1_0_sh_mask.h" -static int pm_map_process_v9(struct packet_manager *pm, +static int pm_map_process_ai(struct packet_manager *pm, uint32_t *buffer, struct qcm_process_device *qpd) { struct pm4_mes_map_process *packet; @@ -73,7 +73,7 @@ static int pm_map_process_v9(struct packet_manager *pm, return 0; } -static int pm_runlist_v9(struct packet_manager *pm, uint32_t *buffer, +static int pm_runlist_ai(struct packet_manager *pm, uint32_t *buffer, uint64_t ib, size_t ib_size_in_dwords, bool chain) { struct pm4_mes_runlist *packet; @@ -111,7 +111,7 @@ static int pm_runlist_v9(struct packet_manager *pm, uint32_t *buffer, return 0; } -static int pm_set_resources_v9(struct packet_manager *pm, uint32_t *buffer, +static int pm_set_resources_ai(struct packet_manager *pm, uint32_t *buffer, struct scheduling_resources *res) { struct pm4_mes_set_resources *packet; @@ -139,7 +139,7 @@ static int pm_set_resources_v9(struct packet_manager *pm, uint32_t *buffer, return 0; } -static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer, +static int pm_map_queues_ai(struct packet_manager *pm, uint32_t *buffer, struct queue *q, bool is_static) { struct pm4_mes_map_queues *packet; @@ -206,7 +206,7 @@ static int pm_map_queues_v9(struct packet_manager *pm, uint32_t *buffer, return 0; } -static int pm_unmap_queues_v9(struct packet_manager *pm, uint32_t *buffer, +static int pm_unmap_queues_ai(struct packet_manager *pm, uint32_t *buffer, enum kfd_queue_type type, enum kfd_unmap_queues_filter filter, uint32_t filter_param, bool reset, @@ -282,7 +282,7 @@ static int pm_unmap_queues_v9(struct packet_manager *pm, uint32_t *buffer, } -static
Re: [PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
Oh, I did not realize the part inside of the file. I think v9->ai is better, because the packet format header uses ai. Also v9 will give people an impression of gfx9. Yong On 2019-11-13 5:19 p.m., Felix Kuehling wrote: On 2019-11-13 5:09 p.m., Yong Zhao wrote: After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 ++-- .../amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} | 0 .../amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} (100%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (100%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..55bfecf04239 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_ai.o \ This naming convention is inconsistent with the rest of KFD. We use _v9, not _ai. Also the function s inside this file are named _v9. If we decide to change that naming convention, it should not be accidental and piece-meal. It should be deliberate and comprehensive. Regards, Felix $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
On 2019-11-13 5:09 p.m., Yong Zhao wrote: After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 ++-- .../amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} | 0 .../amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} (100%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (100%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..55bfecf04239 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_ai.o \ This naming convention is inconsistent with the rest of KFD. We use _v9, not _ai. Also the function s inside this file are named _v9. If we decide to change that naming convention, it should not be accidental and piece-meal. It should be deliberate and comprehensive. Regards, Felix $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm/amdkfd: Rename kfd_kernel_queue_*.c to kfd_packet_manager_*.c
After the recent cleanup, the functionalities provided by the previous kfd_kernel_queue_*.c are actually all packet manager related. So rename them to reflect that. Change-Id: I6544ccb38da827c747544c0787aa949df20edbb0 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 ++-- .../amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} | 0 .../amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_v9.c => kfd_packet_manager_ai.c} (100%) rename drivers/gpu/drm/amd/amdkfd/{kfd_kernel_queue_vi.c => kfd_packet_manager_vi.c} (100%) diff --git a/drivers/gpu/drm/amd/amdkfd/Makefile b/drivers/gpu/drm/amd/amdkfd/Makefile index f93a16372325..55bfecf04239 100644 --- a/drivers/gpu/drm/amd/amdkfd/Makefile +++ b/drivers/gpu/drm/amd/amdkfd/Makefile @@ -38,9 +38,9 @@ AMDKFD_FILES := $(AMDKFD_PATH)/kfd_module.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v9.o \ $(AMDKFD_PATH)/kfd_mqd_manager_v10.o \ $(AMDKFD_PATH)/kfd_kernel_queue.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_vi.o \ - $(AMDKFD_PATH)/kfd_kernel_queue_v9.o \ $(AMDKFD_PATH)/kfd_packet_manager.o \ + $(AMDKFD_PATH)/kfd_packet_manager_vi.o \ + $(AMDKFD_PATH)/kfd_packet_manager_ai.o \ $(AMDKFD_PATH)/kfd_process_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager.o \ $(AMDKFD_PATH)/kfd_device_queue_manager_cik.o \ diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_ai.c diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c similarity index 100% rename from drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c rename to drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_vi.c -- 2.17.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx