RE: [PATCH] drm: should break if already get the best size
Ok, will send a v2 version with description
From: Deucher, Alexander
Sent: Saturday, November 24, 2018 3:34 AM
To: Zhu, Rex ; Liu, Monk ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm: should break if already get the best size
Please add a proper patch description.
Alex
From: amd-gfx
mailto:amd-gfx-boun...@lists.freedesktop.org>>
on behalf of Zhu, Rex mailto:rex@amd.com>>
Sent: Friday, November 23, 2018 4:44:31 AM
To: Liu, Monk;
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm: should break if already get the best size
Tested-by: Rex Zhu mailto:rex@amd.com>>
Without this patch, if we search node via rb tree.
For example: we insert different node with rand size, size range in
(1-).
the key in root node is 5587.
if we try to find the node with key equal to 5587 or 7381,
Loop:
node->key is 5587
node->key is 2273
node->key is 3706
node->key is 4892
node->key is 5296
node->key is 5461
node->key is 5519
node->key is 5549
node->key is 5570
node->key is 5581
node->key is 5584
node->key is 5585
node->key is 5586
node->key is 5586
Find the best node, key is 5587 (Loop 14 levels)
Loop:
node->key is 5587
node->key is 7381
node->key is 6474
node->key is 7034
node->key is 7228
node->key is 7314
node->key is 7339
node->key is 7349
node->key is 7372
node->key is 7377
node->key is 7378
node->key is 7379
node->key is 7379
find the best node, key is 7381. (Loop 13 levels)
With this patch:
we don't need to go down if we found the right node that size equal to we
needed.
Best Regards
Rex
From: amd-gfx
mailto:amd-gfx-boun...@lists.freedesktop.org>>
on behalf of Monk Liu mailto:monk@amd.com>>
Sent: Thursday, November 22, 2018 8:33 PM
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
Cc: Liu, Monk
Subject: [PATCH] drm: should break if already get the best size
Signed-off-by: Monk Liu mailto:monk@amd.com>>
---
drivers/gpu/drm/drm_mm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 3cc5fbd..369fd9b 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -318,6 +318,8 @@ static struct drm_mm_node *best_hole(struct drm_mm *mm, u64
size)
if (size <= node->hole_size) {
best = node;
rb = rb->rb_right;
+ if (size == node->hole_size)
+ break;
} else {
rb = rb->rb_left;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page -
freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx
Archives.. Using amd-gfx: To post a message to all the list members, send email
to amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>. You can
subscribe to the list, or change your existing subscription, in the sections
below.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm: should break if already get the best size
Please add a proper patch description.
Alex
From: amd-gfx on behalf of Zhu, Rex
Sent: Friday, November 23, 2018 4:44:31 AM
To: Liu, Monk; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm: should break if already get the best size
Tested-by: Rex Zhu
Without this patch, if we search node via rb tree.
For example: we insert different node with rand size, size range in
(1-).
the key in root node is 5587.
if we try to find the node with key equal to 5587 or 7381,
Loop:
node->key is 5587
node->key is 2273
node->key is 3706
node->key is 4892
node->key is 5296
node->key is 5461
node->key is 5519
node->key is 5549
node->key is 5570
node->key is 5581
node->key is 5584
node->key is 5585
node->key is 5586
node->key is 5586
Find the best node, key is 5587 (Loop 14 levels)
Loop:
node->key is 5587
node->key is 7381
node->key is 6474
node->key is 7034
node->key is 7228
node->key is 7314
node->key is 7339
node->key is 7349
node->key is 7372
node->key is 7377
node->key is 7378
node->key is 7379
node->key is 7379
find the best node, key is 7381. (Loop 13 levels)
With this patch:
we don't need to go down if we found the right node that size equal to we
needed.
Best Regards
Rex
From: amd-gfx on behalf of Monk Liu
Sent: Thursday, November 22, 2018 8:33 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Monk
Subject: [PATCH] drm: should break if already get the best size
Signed-off-by: Monk Liu
---
drivers/gpu/drm/drm_mm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 3cc5fbd..369fd9b 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -318,6 +318,8 @@ static struct drm_mm_node *best_hole(struct drm_mm *mm, u64
size)
if (size <= node->hole_size) {
best = node;
rb = rb->rb_right;
+ if (size == node->hole_size)
+ break;
} else {
rb = rb->rb_left;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page -
freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx
Archives.. Using amd-gfx: To post a message to all the list members, send email
to amd-gfx@lists.freedesktop.org. You can subscribe to the list, or change your
existing subscription, in the sections below.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm: should break if already get the best size
Tested-by: Rex Zhu
Without this patch, if we search node via rb tree.
For example: we insert different node with rand size, size range in
(1-).
the key in root node is 5587.
if we try to find the node with key equal to 5587 or 7381,
Loop:
node->key is 5587
node->key is 2273
node->key is 3706
node->key is 4892
node->key is 5296
node->key is 5461
node->key is 5519
node->key is 5549
node->key is 5570
node->key is 5581
node->key is 5584
node->key is 5585
node->key is 5586
node->key is 5586
Find the best node, key is 5587 (Loop 14 levels)
Loop:
node->key is 5587
node->key is 7381
node->key is 6474
node->key is 7034
node->key is 7228
node->key is 7314
node->key is 7339
node->key is 7349
node->key is 7372
node->key is 7377
node->key is 7378
node->key is 7379
node->key is 7379
find the best node, key is 7381. (Loop 13 levels)
With this patch:
we don't need to go down if we found the right node that size equal to we
needed.
Best Regards
Rex
From: amd-gfx on behalf of Monk Liu
Sent: Thursday, November 22, 2018 8:33 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Monk
Subject: [PATCH] drm: should break if already get the best size
Signed-off-by: Monk Liu
---
drivers/gpu/drm/drm_mm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 3cc5fbd..369fd9b 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -318,6 +318,8 @@ static struct drm_mm_node *best_hole(struct drm_mm *mm, u64
size)
if (size <= node->hole_size) {
best = node;
rb = rb->rb_right;
+ if (size == node->hole_size)
+ break;
} else {
rb = rb->rb_left;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page -
freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx
Archives.. Using amd-gfx: To post a message to all the list members, send email
to amd-gfx@lists.freedesktop.org. You can subscribe to the list, or change your
existing subscription, in the sections below.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH] drm: should break if already get the best size
Signed-off-by: Monk Liu
---
drivers/gpu/drm/drm_mm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 3cc5fbd..369fd9b 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -318,6 +318,8 @@ static struct drm_mm_node *best_hole(struct drm_mm *mm, u64
size)
if (size <= node->hole_size) {
best = node;
rb = rb->rb_right;
+ if (size == node->hole_size)
+ break;
} else {
rb = rb->rb_left;
}
--
2.7.4
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
