Re: [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static

[Oded Gabbay]

On Mon, Apr 2, 2018 at 9:03 PM, Felix Kuehling  wrote:
> This patch is Reviewed-by: Felix Kuehling 
>
>
> On 2018-03-29 10:25 PM, Wei Yongjun wrote:
>> Fixes the following sparse warning:
>>
>> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning:
>>  symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun 
>> ---
>>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c 
>> b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> index cd679cf..fb5d997 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
>> @@ -1147,7 +1147,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, 
>> struct kfd_process *p,
>>   return ret;
>>  }
>>
>> -bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>> +static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>>  {
>>   struct kfd_local_mem_info mem_info;
>>
>
Thanks, already applied the fix from the kbuild robot.
Oded
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static

[Felix Kuehling]

This patch is Reviewed-by: Felix Kuehling 


On 2018-03-29 10:25 PM, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning:
>  symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c 
> b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index cd679cf..fb5d997 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -1147,7 +1147,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, 
> struct kfd_process *p,
>   return ret;
>  }
>  
> -bool kfd_dev_is_large_bar(struct kfd_dev *dev)
> +static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>  {
>   struct kfd_local_mem_info mem_info;
>

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static

[Wei Yongjun]

Fixes the following sparse warning:

drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning:
 symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?

Signed-off-by: Wei Yongjun 
---
 drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index cd679cf..fb5d997 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -1147,7 +1147,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, 
struct kfd_process *p,
return ret;
 }
 
-bool kfd_dev_is_large_bar(struct kfd_dev *dev)
+static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
 {
struct kfd_local_mem_info mem_info;

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx