[PATCH 00/14] amdgpu: remove load and unload callbacks
These are deprecated and the drm will soon start warning when drivers still use them. It was a long and twisty road, but seems to work. Alex Deucher (14): drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs drm/amdgpu/pm: move debugfs init into core amdgpu debugfs drm/amdgpu/sa: move debugfs init into core amdgpu debugfs drm/amdgpu/fence: move debugfs init into core amdgpu debugfs drm/amdgpu/gem: move debugfs init into core amdgpu debugfs drm/amdgpu/regs: move debugfs init into core amdgpu debugfs drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs drm/amdgpu: don't call drm_connector_register for non-MST ports drm/amdgpu/display: move debugfs init into core amdgpu debugfs drm/amd/display: move dpcd debugfs members setup drm/amdgpu/display: add a late register connector callback drm/amdgpu/ring: move debugfs init into core amdgpu debugfs drm/amdgpu: drop legacy drm load and unload callbacks .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 67 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 3 - drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c| 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 9 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h| 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 15 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 3 + drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 1 - .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++ .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 3 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 - 18 files changed, 112 insertions(+), 78 deletions(-) -- 2.24.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 00/14] amdgpu: remove load and unload callbacks
Am 05.02.20 um 04:48 schrieb Alex Deucher: These are deprecated and the drm will soon start warning when drivers still use them. It was a long and twisty road, but seems to work. Acked-by: Christian König for the whole series. Alex Deucher (14): drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs drm/amdgpu/pm: move debugfs init into core amdgpu debugfs drm/amdgpu/sa: move debugfs init into core amdgpu debugfs drm/amdgpu/fence: move debugfs init into core amdgpu debugfs drm/amdgpu/gem: move debugfs init into core amdgpu debugfs drm/amdgpu/regs: move debugfs init into core amdgpu debugfs drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs drm/amdgpu: don't call drm_connector_register for non-MST ports drm/amdgpu/display: move debugfs init into core amdgpu debugfs drm/amd/display: move dpcd debugfs members setup drm/amdgpu/display: add a late register connector callback drm/amdgpu/ring: move debugfs init into core amdgpu debugfs drm/amdgpu: drop legacy drm load and unload callbacks .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 67 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 3 - drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c| 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 9 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h| 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 15 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 3 + drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 1 - .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++ .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 3 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 - 18 files changed, 112 insertions(+), 78 deletions(-) ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 00/14] amdgpu: remove load and unload callbacks
Hi Alex Am 05.02.20 um 04:48 schrieb Alex Deucher: > These are deprecated and the drm will soon start warning when drivers still > use them. It was a long and twisty road, but seems to work. > > Alex Deucher (14): > drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup > drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs > drm/amdgpu/pm: move debugfs init into core amdgpu debugfs > drm/amdgpu/sa: move debugfs init into core amdgpu debugfs > drm/amdgpu/fence: move debugfs init into core amdgpu debugfs > drm/amdgpu/gem: move debugfs init into core amdgpu debugfs > drm/amdgpu/regs: move debugfs init into core amdgpu debugfs > drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs > drm/amdgpu: don't call drm_connector_register for non-MST ports > drm/amdgpu/display: move debugfs init into core amdgpu debugfs > drm/amd/display: move dpcd debugfs members setup > drm/amdgpu/display: add a late register connector callback > drm/amdgpu/ring: move debugfs init into core amdgpu debugfs > drm/amdgpu: drop legacy drm load and unload callbacks Trying out the patches (on drm-tip) resulted in a NULL-pointer access during startup. [ 10.059945] == [ 10.067285] BUG: KASAN: null-ptr-deref in drm_dp_aux_register+0xcc/0xf0 [ 10.073941] Read of size 8 at addr 0050 by task systemd-udevd/379 [ 10.081118] [ 10.089117] == [ 10.096675] BUG: kernel NULL pointer dereference, address: 0050 [ 10.103674] #PF: supervisor read access in kernel mode [ 10.108840] #PF: error_code(0x) - not-present page [ 10.114004] PGD 0 P4D 0 [ 10.116557] Oops: [#1] SMP KASAN PTI [ 10.120586] CPU: 2 PID: 379 Comm: systemd-udevd Tainted: GB E 5.5.0-1-default+ #235 [ 10.129500] Hardware name: Dell Inc. OptiPlex 9020/0N4YC8, BIOS A24 10/24/2018 [ 10.136775] RIP: 0010:drm_dp_aux_register+0xcc/0xf0 [ 10.136778] Code: 41 5c c3 4c 89 e7 e8 53 b4 28 00 85 c0 74 eb 48 89 ef 89 44 24 04 e8 23 1d 02 00 8b 44 24 04 eb d9 48 8d 7b 50 e8 d4 98 8f ff <48> 8b 73 50 48 85 f6 75 aa 48 89 df e8 c3 98 8f ff 48 8b 33 eb 9d [ 10.136779] RSP: 0018:c9a3f0b0 EFLAGS: 00010286 [ 10.165792] RAX: 8886dc5505c0 RBX: RCX: dc00 [ 10.165793] RDX: 0007 RSI: 0004 RDI: 0297 [ 10.165805] RBP: 8886c1f1c900 R08: 9f19ec71 R09: fbfff4246b5d [ 10.165806] R10: fbfff4246b5c R11: a1235ae3 R12: 8886c1f1c908 [ 10.165807] R13: R14: 0001 R15: 8886bbd64000 [ 10.165809] FS: 7f094629adc0() GS:8886fb60() knlGS: [ 10.165810] CS: 0010 DS: ES: CR0: 80050033 [ 10.165812] CR2: 0050 CR3: 0006dc558006 CR4: 001606e0 [ 10.165813] Call Trace: [ 10.165995] amdgpu_atombios_dp_aux_init+0xa2/0xf0 [amdgpu] [ 10.230952] amdgpu_connector_add+0x8c3/0x1320 [amdgpu] [ 10.231113] ? amdgpu_connector_is_dp12_capable+0xf0/0xf0 [amdgpu] [ OK 10.242611] ? amdgpu_connector_is_dp12_capable+0xf0/0xf0 [amdgpu] [ 10.242783] amdgpu_atombios_get_connector_info_from_object_table+0x9fd/0xd60 [amdgpu] 0m] Started10.258253] ? amdgpu_atombios_has_dce_engine_info+0x110/0x110 [amdgpu] [ 10.258259] ? match_held_lock+0x1b/0x240 1;39mForward Pas[ 10.270175] ? __lock_acquire+0x543/0xaf0 [ 10.270188] ? collect_percpu_times+0x3bb/0x400 [ 10.270198] ? rcu_read_lock_bh_held+0xa0/0xa0 [ 10.284629] ? debug_lockdep_rcu_enabled.part.0+0x16/0x30 [ 10.284634] ? __kmalloc+0x310/0x6e0 sword R�…s to P[ 10.293648] ? drm_mode_crtc_set_gamma_size+0x44/0xf0 [ 10.293834] ? dce_v6_0_sw_init+0x3c4/0x720 [amdgpu] [ 10.293986] dce_v6_0_sw_init+0x3c4/0x720 [amdgpu] lymouth Director[ 10.310201] ? si_dma_sw_init+0x8b/0x120 [amdgpu] [ 10.310409] amdgpu_device_ip_init+0xbd/0x64e [amdgpu] y Watch. [[ 10.321430] amdgpu_device_init.cold+0xb92/0xf26 [amdgpu] [ 10.321577] ? amdgpu_driver_load_kms+0x7a/0x370 [amdgpu] [ 10.333506] ? rcu_read_lock_sched_held+0x85/0x90 [ 10.333689] ? amdgpu_device_has_dc_support+0x30/0x30 [amdgpu] OK 10.344105] ? debug_lockdep_rcu_enabled.part.0+0x16/0x30 [ 10.344108] ? kmem_cache_alloc_trace+0x51e/0x6b0 [ 10.344112] ? kstrdup+0x44/0x60 [ 10.344269] amdgpu_driver_load_kms+0xc7/0x370 [amdgpu] [ 10.344414] ? amdgpu_register_gpu_instance+0xd0/0xd0 [amdgpu] [ 10.344581] ? amdgpu_dm_initialize_drm_device+0xe88/0x1544 [amdgpu] m] Reached targe[ 10.376553] amdgpu_pci_probe+0x12e/0x1d0 [amdgpu] [ 10.376698] ? amdgpu_pmops_runtime_idle+0xf0/0xf0 [amdgpu] [ 10.388229] local_pci_probe+0x74/0xc0 t Paths[ 10.388233] pci_device_probe+0x1c9/0x2d0 [ 10.388252] ? pci_device_remove+0x180/0x180 [ 10.388258] ? sysfs_do_create_link_sd.isra.0+0x74/0xd0 . [ 10.406977] really_probe+0x184/0x530 [
Re: [PATCH 00/14] amdgpu: remove load and unload callbacks
Patches 10-12 are Reviewed-by: Harry Wentland Harry On 2020-02-04 10:48 p.m., Alex Deucher wrote: > These are deprecated and the drm will soon start warning when drivers still > use them. It was a long and twisty road, but seems to work. > > Alex Deucher (14): > drm/amdgpu: rename amdgpu_debugfs_preempt_cleanup > drm/amdgpu/ttm: move debugfs init into core amdgpu debugfs > drm/amdgpu/pm: move debugfs init into core amdgpu debugfs > drm/amdgpu/sa: move debugfs init into core amdgpu debugfs > drm/amdgpu/fence: move debugfs init into core amdgpu debugfs > drm/amdgpu/gem: move debugfs init into core amdgpu debugfs > drm/amdgpu/regs: move debugfs init into core amdgpu debugfs > drm/amdgpu/firmware: move debugfs init into core amdgpu debugfs > drm/amdgpu: don't call drm_connector_register for non-MST ports > drm/amdgpu/display: move debugfs init into core amdgpu debugfs > drm/amd/display: move dpcd debugfs members setup > drm/amdgpu/display: add a late register connector callback > drm/amdgpu/ring: move debugfs init into core amdgpu debugfs > drm/amdgpu: drop legacy drm load and unload callbacks > > .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 1 - > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 67 ++- > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 17 - > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +++- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 3 - > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c| 7 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.h| 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 9 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h| 2 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 15 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 +--- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 3 + > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 1 - > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++ > .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 3 + > .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 - > 18 files changed, 112 insertions(+), 78 deletions(-) > ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
