Re: How are the DC patches tested? (was: [PATCH 00/15] DC Patches May 9, 2022)
On 2022-05-09 10:00, Paul Menzel wrote: [Sorry for the incomplete first message.] Dear Daniel, Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: […] This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS I am curious, what this means exactly? You clone the Ubuntu Linux 5.16 kernel source, and then apply your patches on top? (Do they even apply?) All of these "promotion" patches are tested by using amd-staging-drm-next. In a few words: 1. We get the latest code from amd-staging-drm-next; 2. We apply these weekly promotion patches on top of it; 3. We compile, run unit tests, and run many manual tests (Daniel does that). If everything is alright with Daniel's tests, we feel confident to merge these series on top amd-staging-drm-next (we are basically trying to avoid regressions here). Anyway, maybe we can rephrase: Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS to Tested on Ubuntu 22.04 and ChromeOS with amd-staging-drm-next + promotion patches. The same for Chrome OS. Do you use Chrome OS Flex [1] with the systems you listed? If not, what Google Chromebooks/-boxes did you test with? The Linux kernel version is also tied for a device and Chrome OS release. Please mention those too. Is it documented somewhere, what tests you run exactly? We run IGT tests, some scripts that validate some specific areas, and Daniel has an extensive set of manual tests. Thanks Siqueira Kind regards, Paul [1]: https://chromeenterprise.google/os/chromeosflex/
How are the DC patches tested? (was: [PATCH 00/15] DC Patches May 9, 2022)
[Sorry for the incomplete first message.] Dear Daniel, Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: […] This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS I am curious, what this means exactly? You clone the Ubuntu Linux 5.16 kernel source, and then apply your patches on top? (Do they even apply?) The same for Chrome OS. Do you use Chrome OS Flex [1] with the systems you listed? If not, what Google Chromebooks/-boxes did you test with? The Linux kernel version is also tied for a device and Chrome OS release. Please mention those too. Is it documented somewhere, what tests you run exactly? Kind regards, Paul [1]: https://chromeenterprise.google/os/chromeosflex/
Re: [PATCH 00/15] DC Patches May 9, 2022
Dear Daniel, Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: […] This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS Kind regards, Paul
RE: [PATCH 00/15] DC Patches May 9, 2022
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Stylon Wang Sent: May 6, 2022 11:42 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/15] DC Patches May 9, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Refactor LTTPR code - Fix PSR after hibernate - Fix DC build errors - Fix IRQ unregister error when unloading amdgpu - Improve DP link training - Fix stutter - Remove redundant CONFIG_DRM_AMD_DC_DCN guards - Fix 2nd connected USB-C display not lighting up --- Alan Liu (1): drm/amd/display: do not disable an invalid irq source in hdp finish Alex Hung (7): drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dc drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dce drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in gpio drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in irq drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN for z10 drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in amdgpu_dm drm/amd/display: remove unnecessary else by CONFIG_DRM_AMD_DC_DCN Aric Cyr (1): drm/amd/display: 3.2.185 Evgenii Krasnikov (1): drm/amd/display: Reset cached PSR parameters after hibernate Josip Pavic (2): drm/amd/display: move definition of dc_flip_addrs struct drm/amd/display: do not wait for vblank during pipe programming Michael Strauss (1): drm/amd/display: Refactor LTTPR cap retrieval Stylon Wang (1): Revert "drm/amd/display: Fix DCN3 B0 DP Alt Mapping" Wenjing Liu (1): drm/amd/display: do not calculate DP2.0 SST payload when link is off .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 46 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 6 - .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 - .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 6 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 - .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 3 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 4 - drivers/gpu/drm/amd/display/dc/Makefile | 2 - .../display/dc/bios/command_table_helper2.c | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 41 +--- .../gpu/drm/amd/display/dc/core/dc_debug.c| 2 - drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 179 ++ .../drm/amd/display/dc/core/dc_link_dpia.c| 2 - .../gpu/drm/amd/display/dc/core/dc_resource.c | 25 +-- .../gpu/drm/amd/display/dc/core/dc_stream.c | 12 -- drivers/gpu/drm/amd/display/dc/dc.h | 51 + drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 16 ++ drivers/gpu/drm/amd/display/dc/dc_link.h | 2 + .../drm/amd/display/dc/dce/dce_clock_source.c | 15 +- .../drm/amd/display/dc/dce/dce_clock_source.h | 12 +- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 10 - .../amd/display/dc/dce/dce_stream_encoder.c | 21 +- .../display/dc/dce110/dce110_hw_sequencer.c | 2 - .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 1 - .../drm/amd/display/dc/dcn31/dcn31_resource.c | 6 - drivers/gpu/drm/amd/display/dc/dm_helpers.h | 2 - drivers/gpu/drm/amd/display/dc/gpio/Makefile | 3 +- .../display/dc/gpio/dcn30/hw_factory_dcn30.c | 2 - .../display/dc/gpio/dcn30/hw_factory_dcn30.h | 2 - .../dc/gpio/dcn30/hw_translate_dcn30.c| 2 - .../dc/gpio/dcn30/hw_translate_dcn30.h| 2 - .../gpu/drm/amd/display/dc/gpio/hw_factory.c | 4 - .../drm/amd/display/dc/gpio/hw_translate.c| 4 - .../gpu/drm/amd/display/dc/inc/co
[PATCH 00/15] DC Patches May 9, 2022
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Refactor LTTPR code - Fix PSR after hibernate - Fix DC build errors - Fix IRQ unregister error when unloading amdgpu - Improve DP link training - Fix stutter - Remove redundant CONFIG_DRM_AMD_DC_DCN guards - Fix 2nd connected USB-C display not lighting up --- Alan Liu (1): drm/amd/display: do not disable an invalid irq source in hdp finish Alex Hung (7): drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dc drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dce drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in gpio drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in irq drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN for z10 drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in amdgpu_dm drm/amd/display: remove unnecessary else by CONFIG_DRM_AMD_DC_DCN Aric Cyr (1): drm/amd/display: 3.2.185 Evgenii Krasnikov (1): drm/amd/display: Reset cached PSR parameters after hibernate Josip Pavic (2): drm/amd/display: move definition of dc_flip_addrs struct drm/amd/display: do not wait for vblank during pipe programming Michael Strauss (1): drm/amd/display: Refactor LTTPR cap retrieval Stylon Wang (1): Revert "drm/amd/display: Fix DCN3 B0 DP Alt Mapping" Wenjing Liu (1): drm/amd/display: do not calculate DP2.0 SST payload when link is off .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 46 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 6 - .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 - .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 6 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 - .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 3 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 4 - drivers/gpu/drm/amd/display/dc/Makefile | 2 - .../display/dc/bios/command_table_helper2.c | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 41 +--- .../gpu/drm/amd/display/dc/core/dc_debug.c| 2 - drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 179 ++ .../drm/amd/display/dc/core/dc_link_dpia.c| 2 - .../gpu/drm/amd/display/dc/core/dc_resource.c | 25 +-- .../gpu/drm/amd/display/dc/core/dc_stream.c | 12 -- drivers/gpu/drm/amd/display/dc/dc.h | 51 + drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 16 ++ drivers/gpu/drm/amd/display/dc/dc_link.h | 2 + .../drm/amd/display/dc/dce/dce_clock_source.c | 15 +- .../drm/amd/display/dc/dce/dce_clock_source.h | 12 +- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 10 - .../amd/display/dc/dce/dce_stream_encoder.c | 21 +- .../display/dc/dce110/dce110_hw_sequencer.c | 2 - .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 1 - .../drm/amd/display/dc/dcn31/dcn31_resource.c | 6 - drivers/gpu/drm/amd/display/dc/dm_helpers.h | 2 - drivers/gpu/drm/amd/display/dc/gpio/Makefile | 3 +- .../display/dc/gpio/dcn30/hw_factory_dcn30.c | 2 - .../display/dc/gpio/dcn30/hw_factory_dcn30.h | 2 - .../dc/gpio/dcn30/hw_translate_dcn30.c| 2 - .../dc/gpio/dcn30/hw_translate_dcn30.h| 2 - .../gpu/drm/amd/display/dc/gpio/hw_factory.c | 4 - .../drm/amd/display/dc/gpio/hw_translate.c| 4 - .../gpu/drm/amd/display/dc/inc/core_types.h | 17 +- .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 3 +- drivers/gpu/drm/amd/display/dc/irq/Makefile | 3 +- .../display/dc/irq/dcn30/irq_service_dcn30.c | 3 - .../display/dc/irq/dcn30/irq_service_dcn30.h | 3 - .../gpu/drm/amd/display/dc/irq/irq_service.c | 5 - .../amd/display/include/link_service_types.h | 6 + 42 files changed, 161 insertions(+), 391 deletions(-) -- 2.35.1
