Re: [PATCH 00/18] *** multiple level VMPT enablement ***

2017-03-24 Thread Christian König
Patches #11 and #18 are Reviewed-by: Christian König 
.


Patch #12 is a NAK, that will also increase the VM space for pre gfx9 
and we already found that this isn't a good idea.


We should change how that value is evaluated in the different GMC 
handling code instead.


In other words, set it to -1 as default value and handle -1 in gmc 
v6/v7/v9 as 64GB, while in gmc v9 as 1TB (or even 256TB?).


Patch #13, #14: Good catch, but please squash into my original patch #8.

Patch #15, #16, #17: Please squash into patch #10.

Apart from that thanks a lot to pick this up while I was busy tracking 
the hw problem down.


And BTW did you tested the 48bit (256TB) address space support as well? 
That should also work now.


Regards,
Christian.

Am 24.03.2017 um 04:16 schrieb Chunming Zhou:

*** BLURB HERE ***
 From Vega, ascis start to support multiple level vmpt, the series is to 
implement it.

Tested successfully with 2/3/4 levels.

Christian König (10):
   drm/amdgpu: rename page_directory_fence to last_dir_update
   drm/amdgpu: add the VM pointer to the amdgpu_pte_update_params as well
   drm/amdgpu: add num_level to the VM manager
   drm/amdgpu: generalize page table level
   drm/amdgpu: handle multi level PD size calculation
   drm/amdgpu: handle multi level PD during validation
   drm/amdgpu: handle multi level PD in the LRU
   drm/amdgpu: handle multi level PD updates
   drm/amdgpu: handle multi level PD during PT updates
   drm/amdgpu: add alloc/free for multi level PDs

Chunming Zhou (8):
   drm/amdgpu: set page table depth by num_level
   drm/amdgpu: block size of multiple level vmpt prefers one page
   drm/amdgpu: fix update sub levels
   drm/amdgpu: sub levels need to update regardless of parent updates
   drm/amdgpu: clear entries allocation
   drm/amdgpu: fix entries index calculation
   drm/amdgpu: need alloc sub level even parent bo was allocated
   drm/amdgpu: enable four level vmpt

  drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c   |   6 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c  |   4 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c  |   2 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c   | 474 ---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h   |  16 +-
  drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c |   3 +-
  drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c|   1 +
  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c|   1 +
  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c|   1 +
  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c|   1 +
  drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c  |   2 +-
  11 files changed, 336 insertions(+), 175 deletions(-)



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH 00/18] *** multiple level VMPT enablement ***

2017-03-23 Thread Chunming Zhou
*** BLURB HERE ***
From Vega, ascis start to support multiple level vmpt, the series is to 
implement it.

Tested successfully with 2/3/4 levels.

Christian König (10):
  drm/amdgpu: rename page_directory_fence to last_dir_update
  drm/amdgpu: add the VM pointer to the amdgpu_pte_update_params as well
  drm/amdgpu: add num_level to the VM manager
  drm/amdgpu: generalize page table level
  drm/amdgpu: handle multi level PD size calculation
  drm/amdgpu: handle multi level PD during validation
  drm/amdgpu: handle multi level PD in the LRU
  drm/amdgpu: handle multi level PD updates
  drm/amdgpu: handle multi level PD during PT updates
  drm/amdgpu: add alloc/free for multi level PDs

Chunming Zhou (8):
  drm/amdgpu: set page table depth by num_level
  drm/amdgpu: block size of multiple level vmpt prefers one page
  drm/amdgpu: fix update sub levels
  drm/amdgpu: sub levels need to update regardless of parent updates
  drm/amdgpu: clear entries allocation
  drm/amdgpu: fix entries index calculation
  drm/amdgpu: need alloc sub level even parent bo was allocated
  drm/amdgpu: enable four level vmpt

 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c   |   6 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c  |   4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c  |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c   | 474 ---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h   |  16 +-
 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c |   3 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c|   1 +
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c|   1 +
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c|   1 +
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c|   1 +
 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c  |   2 +-
 11 files changed, 336 insertions(+), 175 deletions(-)

-- 
1.9.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx