Re: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and pg status

2018-07-10 Thread Alex Deucher 
On Sun, Jul 8, 2018 at 11:56 PM, Quan, Evan  wrote:
> Ping..
>
>> -Original Message-
>> From: Evan Quan [mailto:evan.q...@amd.com]
>> Sent: Thursday, July 05, 2018 5:09 PM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Quan, Evan 
>> Subject: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and
>> pg status
>>
>> CSIB init has no relation with rlc version and pg status. It should be needed
>> regardless of them.
>>
>> Change-Id: Iccd12e1015f41c7e2bc3fe02472dc979015514d4
>> Signed-off-by: Evan Quan 

Acked-by: Alex Deucher 

>> ---
>>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> index 65cc30766658..2f6ac255203f 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
>> @@ -2182,6 +2182,8 @@ static void
>> gfx_v9_0_enable_gfx_dynamic_mg_power_gating(struct amdgpu_device
>> *ad
>>
>>  static void gfx_v9_0_init_pg(struct amdgpu_device *adev)  {
>> + gfx_v9_0_init_csb(adev);
>> +
>>   if (!adev->gfx.rlc.is_rlc_v2_1)
>>   return;
>>
>> @@ -2191,7 +2193,6 @@ static void gfx_v9_0_init_pg(struct amdgpu_device
>> *adev)
>> AMD_PG_SUPPORT_CP |
>> AMD_PG_SUPPORT_GDS |
>> AMD_PG_SUPPORT_RLC_SMU_HS)) {
>> - gfx_v9_0_init_csb(adev);
>>   gfx_v9_1_init_rlc_save_restore_list(adev);
>>   gfx_v9_0_enable_save_restore_machine(adev);
>>
>> --
>> 2.18.0
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and pg status

2018-07-08 Thread Quan, Evan 
Ping..

> -Original Message-
> From: Evan Quan [mailto:evan.q...@amd.com]
> Sent: Thursday, July 05, 2018 5:09 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Quan, Evan 
> Subject: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and
> pg status
> 
> CSIB init has no relation with rlc version and pg status. It should be needed
> regardless of them.
> 
> Change-Id: Iccd12e1015f41c7e2bc3fe02472dc979015514d4
> Signed-off-by: Evan Quan 
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 65cc30766658..2f6ac255203f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -2182,6 +2182,8 @@ static void
> gfx_v9_0_enable_gfx_dynamic_mg_power_gating(struct amdgpu_device
> *ad
> 
>  static void gfx_v9_0_init_pg(struct amdgpu_device *adev)  {
> + gfx_v9_0_init_csb(adev);
> +
>   if (!adev->gfx.rlc.is_rlc_v2_1)
>   return;
> 
> @@ -2191,7 +2193,6 @@ static void gfx_v9_0_init_pg(struct amdgpu_device
> *adev)
> AMD_PG_SUPPORT_CP |
> AMD_PG_SUPPORT_GDS |
> AMD_PG_SUPPORT_RLC_SMU_HS)) {
> - gfx_v9_0_init_csb(adev);
>   gfx_v9_1_init_rlc_save_restore_list(adev);
>   gfx_v9_0_enable_save_restore_machine(adev);
> 
> --
> 2.18.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and pg status

2018-07-05 Thread Evan Quan 
CSIB init has no relation with rlc version and pg status. It should be
needed regardless of them.

Change-Id: Iccd12e1015f41c7e2bc3fe02472dc979015514d4
Signed-off-by: Evan Quan 
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 65cc30766658..2f6ac255203f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -2182,6 +2182,8 @@ static void 
gfx_v9_0_enable_gfx_dynamic_mg_power_gating(struct amdgpu_device *ad
 
 static void gfx_v9_0_init_pg(struct amdgpu_device *adev)
 {
+   gfx_v9_0_init_csb(adev);
+
if (!adev->gfx.rlc.is_rlc_v2_1)
return;
 
@@ -2191,7 +2193,6 @@ static void gfx_v9_0_init_pg(struct amdgpu_device *adev)
  AMD_PG_SUPPORT_CP |
  AMD_PG_SUPPORT_GDS |
  AMD_PG_SUPPORT_RLC_SMU_HS)) {
-   gfx_v9_0_init_csb(adev);
gfx_v9_1_init_rlc_save_restore_list(adev);
gfx_v9_0_enable_save_restore_machine(adev);
 
-- 
2.18.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx