Re: [PATCH 08/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag: Fix struct declared inside parameter list error

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones  wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
>  warning: ‘struct hw_factory’ declared inside parameter list will not be 
> visible outside of this definition or declaration
>  
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:6:
>  note: previous declaration of ‘dal_hw_factory_diag_fpga_init’ was here
>  
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
>  warning: ‘struct hw_factory’ declared inside parameter list will not be 
> visible outside of this definition or declaration
>  
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:6:
>  note: previous declaration of ‘dal_hw_factory_diag_fpga_init’ was here
>  
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
>  warning: ‘struct hw_factory’ declared inside parameter list will not be 
> visible outside of this definition or declaration
>  
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:6:
>  note: previous declaration of ‘dal_hw_factory_diag_fpga_init’ was here
>
> Cc: Harry Wentland 
> Cc: Leo Li 
> Cc: Alex Deucher 
> Cc: "Christian König" 
> Cc: David Airlie 
> Cc: Daniel Vetter 
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org
> Signed-off-by: Lee Jones 

Applied.  Thanks!

Alex

> ---
>  .../gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h   | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git 
> a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h 
> b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
> index 8a74f6adb8eee..bf68eb1d9a1d2 100644
> --- a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
> +++ b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
> @@ -26,6 +26,8 @@
>  #ifndef __DAL_HW_FACTORY_DIAG_FPGA_H__
>  #define __DAL_HW_FACTORY_DIAG_FPGA_H__
>
> +struct hw_factory;
> +
>  /* Initialize HW factory function pointers and pin info */
>  void dal_hw_factory_diag_fpga_init(struct hw_factory *factory);
>
> --
> 2.25.1
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH 08/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag: Fix struct declared inside parameter list error

2021-01-11 Thread Lee Jones
Fixes the following W=1 kernel build warning(s):

 
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
 warning: ‘struct hw_factory’ declared inside parameter list will not be 
visible outside of this definition or declaration
 
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:6:
 note: previous declaration of ‘dal_hw_factory_diag_fpga_init’ was here
 
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
 warning: ‘struct hw_factory’ declared inside parameter list will not be 
visible outside of this definition or declaration
 
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:6:
 note: previous declaration of ‘dal_hw_factory_diag_fpga_init’ was here
 
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
 warning: ‘struct hw_factory’ declared inside parameter list will not be 
visible outside of this definition or declaration
 
drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:6:
 note: previous declaration of ‘dal_hw_factory_diag_fpga_init’ was here

Cc: Harry Wentland 
Cc: Leo Li 
Cc: Alex Deucher 
Cc: "Christian König" 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones 
---
 .../gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h 
b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
index 8a74f6adb8eee..bf68eb1d9a1d2 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
+++ b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
@@ -26,6 +26,8 @@
 #ifndef __DAL_HW_FACTORY_DIAG_FPGA_H__
 #define __DAL_HW_FACTORY_DIAG_FPGA_H__
 
+struct hw_factory;
+
 /* Initialize HW factory function pointers and pin info */
 void dal_hw_factory_diag_fpga_init(struct hw_factory *factory);
 
-- 
2.25.1

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx