Re: [PATCH 09/40] drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1590: warning: Function parameter or > member 'instance' not described in 'gfx_v7_0_select_se_sh' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1788: warning: Excess function > parameter 'se_num' description in 'gfx_v7_0_setup_rb' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1788: warning: Excess function > parameter 'sh_per_se' description in 'gfx_v7_0_setup_rb' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1852: warning: Excess function > parameter 'adev' description in 'DEFAULT_SH_MEM_BASES' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2086: warning: Excess function > parameter 'adev' description in 'gfx_v7_0_ring_test_ring' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2130: warning: Function parameter or > member 'ring' not described in 'gfx_v7_0_ring_emit_hdp_flush' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2130: warning: Excess function > parameter 'adev' description in 'gfx_v7_0_ring_emit_hdp_flush' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2130: warning: Excess function > parameter 'ridx' description in 'gfx_v7_0_ring_emit_hdp_flush' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or > member 'ring' not described in 'gfx_v7_0_ring_emit_fence_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or > member 'addr' not described in 'gfx_v7_0_ring_emit_fence_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or > member 'seq' not described in 'gfx_v7_0_ring_emit_fence_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or > member 'flags' not described in 'gfx_v7_0_ring_emit_fence_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Excess function > parameter 'adev' description in 'gfx_v7_0_ring_emit_fence_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Excess function > parameter 'fence' description in 'gfx_v7_0_ring_emit_fence_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or > member 'ring' not described in 'gfx_v7_0_ring_emit_fence_compute' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or > member 'addr' not described in 'gfx_v7_0_ring_emit_fence_compute' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or > member 'seq' not described in 'gfx_v7_0_ring_emit_fence_compute' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or > member 'flags' not described in 'gfx_v7_0_ring_emit_fence_compute' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Excess function > parameter 'adev' description in 'gfx_v7_0_ring_emit_fence_compute' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Excess function > parameter 'fence' description in 'gfx_v7_0_ring_emit_fence_compute' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2260: warning: Function parameter or > member 'job' not described in 'gfx_v7_0_ring_emit_ib_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2260: warning: Function parameter or > member 'flags' not described in 'gfx_v7_0_ring_emit_ib_gfx' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2351: warning: Function parameter or > member 'timeout' not described in 'gfx_v7_0_ring_test_ib' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or > member 'ring' not described in 'gfx_v7_0_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or > member 'vmid' not described in 'gfx_v7_0_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or > member 'pd_addr' not described in 'gfx_v7_0_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Excess function > parameter 'adev' description in 'gfx_v7_0_ring_emit_vm_flush' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lists.linaro.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++ > 1 file changed, 19 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > index 04e1e92f5f3cf..f2490f915a8be 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c > @@ -1580,10 +1580,10 @@ static void gfx_v7_0_tiling_mode_table_init(struct > amdgpu_device *adev) > * @adev: amdgpu_device pointer > * @se_num: shader engine to address > * @sh_num: sh block to address > + * @instance: Certain registers are instanced per SE or SH. > + *0x means broadcast to all SEs or SHs (CIK). > * > - * Select which SE, SH combinations to address. Certain > - * registers are i
[PATCH 09/40] drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1590: warning: Function parameter or member 'instance' not described in 'gfx_v7_0_select_se_sh' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1788: warning: Excess function parameter 'se_num' description in 'gfx_v7_0_setup_rb' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1788: warning: Excess function parameter 'sh_per_se' description in 'gfx_v7_0_setup_rb' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1852: warning: Excess function parameter 'adev' description in 'DEFAULT_SH_MEM_BASES' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2086: warning: Excess function parameter 'adev' description in 'gfx_v7_0_ring_test_ring' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2130: warning: Function parameter or member 'ring' not described in 'gfx_v7_0_ring_emit_hdp_flush' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2130: warning: Excess function parameter 'adev' description in 'gfx_v7_0_ring_emit_hdp_flush' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2130: warning: Excess function parameter 'ridx' description in 'gfx_v7_0_ring_emit_hdp_flush' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or member 'ring' not described in 'gfx_v7_0_ring_emit_fence_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or member 'addr' not described in 'gfx_v7_0_ring_emit_fence_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or member 'seq' not described in 'gfx_v7_0_ring_emit_fence_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Function parameter or member 'flags' not described in 'gfx_v7_0_ring_emit_fence_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Excess function parameter 'adev' description in 'gfx_v7_0_ring_emit_fence_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2182: warning: Excess function parameter 'fence' description in 'gfx_v7_0_ring_emit_fence_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or member 'ring' not described in 'gfx_v7_0_ring_emit_fence_compute' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or member 'addr' not described in 'gfx_v7_0_ring_emit_fence_compute' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or member 'seq' not described in 'gfx_v7_0_ring_emit_fence_compute' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Function parameter or member 'flags' not described in 'gfx_v7_0_ring_emit_fence_compute' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Excess function parameter 'adev' description in 'gfx_v7_0_ring_emit_fence_compute' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2224: warning: Excess function parameter 'fence' description in 'gfx_v7_0_ring_emit_fence_compute' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2260: warning: Function parameter or member 'job' not described in 'gfx_v7_0_ring_emit_ib_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2260: warning: Function parameter or member 'flags' not described in 'gfx_v7_0_ring_emit_ib_gfx' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:2351: warning: Function parameter or member 'timeout' not described in 'gfx_v7_0_ring_test_ib' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or member 'ring' not described in 'gfx_v7_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or member 'vmid' not described in 'gfx_v7_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Function parameter or member 'pd_addr' not described in 'gfx_v7_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3244: warning: Excess function parameter 'adev' description in 'gfx_v7_0_ring_emit_vm_flush' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++ 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 04e1e92f5f3cf..f2490f915a8be 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c @@ -1580,10 +1580,10 @@ static void gfx_v7_0_tiling_mode_table_init(struct amdgpu_device *adev) * @adev: amdgpu_device pointer * @se_num: shader engine to address * @sh_num: sh block to address + * @instance: Certain registers are instanced per SE or SH. + *0x means broadcast to all SEs or SHs (CIK). * - * Select which SE, SH combinations to address. Certain - * registers are instanced per SE or SH. 0x means - * broadcast to all SEs or SHs (CIK). + * Select which SE, SH combinations to address. */ static void gfx_v7_0_select_se_sh(struct amdgpu_device *adev, u32 se_num, u32 s
