Re: [PATCH 1/2] drm/amdgpu/gfx8: enable cp/rlc ints after we disable clockgating
Ping? On Tue, Mar 14, 2017 at 3:32 PM, Alex Deucher wrote: > Even if we disable clockgating, we still need to make sure the > cp/rlc interrupts are enabled for powergating which might still > be enabled. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index a53e36c..c9d9913 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -6258,6 +6258,8 @@ static void > gfx_v8_0_update_coarse_grain_clock_gating(struct amdgpu_device *adev > RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK); > if (temp != data) > WREG32(mmRLC_CGCG_CGLS_CTRL, data); > + /* enable interrupts again for PG */ > + gfx_v8_0_enable_gui_idle_interrupt(adev, true); > } > > gfx_v8_0_wait_for_rlc_serdes(adev); > -- > 2.5.5 > ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 1/2] drm/amdgpu/gfx8: enable cp/rlc ints after we disable clockgating
On 16/03/17 12:24 PM, Alex Deucher wrote: On Tue, Mar 14, 2017 at 3:32 PM, Alex Deucher wrote: Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled. Signed-off-by: Alex Deucher Anyone? Haven't had a chance to try it out (only one devel board...). In principle that should work provided this is called when CGCG is disabled. Tom ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 1/2] drm/amdgpu/gfx8: enable cp/rlc ints after we disable clockgating
On Tue, Mar 14, 2017 at 3:32 PM, Alex Deucher wrote: > Even if we disable clockgating, we still need to make sure the > cp/rlc interrupts are enabled for powergating which might still > be enabled. > > Signed-off-by: Alex Deucher Anyone? > --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index a53e36c..c9d9913 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -6258,6 +6258,8 @@ static void > gfx_v8_0_update_coarse_grain_clock_gating(struct amdgpu_device *adev > RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK); > if (temp != data) > WREG32(mmRLC_CGCG_CGLS_CTRL, data); > + /* enable interrupts again for PG */ > + gfx_v8_0_enable_gui_idle_interrupt(adev, true); > } > > gfx_v8_0_wait_for_rlc_serdes(adev); > -- > 2.5.5 > ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH 1/2] drm/amdgpu/gfx8: enable cp/rlc ints after we disable clockgating
Even if we disable clockgating, we still need to make sure the cp/rlc interrupts are enabled for powergating which might still be enabled. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index a53e36c..c9d9913 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c @@ -6258,6 +6258,8 @@ static void gfx_v8_0_update_coarse_grain_clock_gating(struct amdgpu_device *adev RLC_CGCG_CGLS_CTRL__CGLS_EN_MASK); if (temp != data) WREG32(mmRLC_CGCG_CGLS_CTRL, data); + /* enable interrupts again for PG */ + gfx_v8_0_enable_gui_idle_interrupt(adev, true); } gfx_v8_0_wait_for_rlc_serdes(adev); -- 2.5.5 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
