Re: [PATCH 1/3] drm/amdgpu: Really leave SI support disabled by default

2017-05-30 Thread Christian König 

Am 30.05.2017 um 05:26 schrieb Michel Dänzer:

On 30/05/17 02:18 AM, Christian König wrote:

Am 29.05.2017 um 11:20 schrieb Michel Dänzer:

From: Michel Dänzer 

The default option value didn't match the help text and intention.

Signed-off-by: Michel Dänzer 

I'm still unsure about the last one. The feature parity is a good
argument but on the other hand we want people to use amdgpu for CIK
these days, don't we?

We want to make it easy for people to test amdgpu on CIK, which is what
the options added by Felix are for. IMO we should not flip the default
(upstream) before there is feature parity.



Anyway Reviewed-by: Christian König .

Thanks, I assume that applies to the whole series?


With the SI typo and the HDMI/DP audio thing pointed out by Kai fixed, 
than yes that rb applies to the whole series.


Christian.

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 1/3] drm/amdgpu: Really leave SI support disabled by default

2017-05-29 Thread Michel Dänzer 
On 30/05/17 02:18 AM, Christian König wrote:
> Am 29.05.2017 um 11:20 schrieb Michel Dänzer:
>> From: Michel Dänzer 
>>
>> The default option value didn't match the help text and intention.
>>
>> Signed-off-by: Michel Dänzer 
> 
> I'm still unsure about the last one. The feature parity is a good
> argument but on the other hand we want people to use amdgpu for CIK
> these days, don't we?

We want to make it easy for people to test amdgpu on CIK, which is what
the options added by Felix are for. IMO we should not flip the default
(upstream) before there is feature parity.


> Anyway Reviewed-by: Christian König .

Thanks, I assume that applies to the whole series?


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 1/3] drm/amdgpu: Really leave SI support disabled by default

2017-05-29 Thread Christian König 

Am 29.05.2017 um 11:20 schrieb Michel Dänzer:

From: Michel Dänzer 

The default option value didn't match the help text and intention.

Signed-off-by: Michel Dänzer 


I'm still unsure about the last one. The feature parity is a good 
argument but on the other hand we want people to use amdgpu for CIK 
these days, don't we?


Anyway Reviewed-by: Christian König .

Regards,
Christian.


---

Maybe this can be squashed into the commit adding this option when it
goes upstream.

  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 17ecc2542af5..76dea5fe620b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -234,7 +234,7 @@ MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip 
Pramater Cache per Shad
  module_param_named(param_buf_per_se, amdgpu_param_buf_per_se, int, 0444);
  
  #ifdef CONFIG_DRM_AMDGPU_SI

-int amdgpu_si_support = 1;
+int amdgpu_si_support = 0;
  MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled 
(default))");
  module_param_named(si_support, amdgpu_si_support, int, 0444);
  #endif



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/3] drm/amdgpu: Really leave SI support disabled by default

2017-05-29 Thread Michel Dänzer 
From: Michel Dänzer 

The default option value didn't match the help text and intention.

Signed-off-by: Michel Dänzer 
---

Maybe this can be squashed into the commit adding this option when it
goes upstream.

 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 17ecc2542af5..76dea5fe620b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -234,7 +234,7 @@ MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip 
Pramater Cache per Shad
 module_param_named(param_buf_per_se, amdgpu_param_buf_per_se, int, 0444);
 
 #ifdef CONFIG_DRM_AMDGPU_SI
-int amdgpu_si_support = 1;
+int amdgpu_si_support = 0;
 MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled 
(default))");
 module_param_named(si_support, amdgpu_si_support, int, 0444);
 #endif
-- 
2.11.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx