Re: [PATCH 1/6] HID: amd_sfh: Increase sensor command timeout

[Alex Deucher]

On Tue, Jun 4, 2024 at 8:57 AM Jiri Kosina  wrote:
>
> On Wed, 22 May 2024, Li Ma wrote:
>
> > From: Basavaraj Natikar 
> >
> > During the initialization sensors may take some time to respond. Hence,
> > increase the sensor command timeouts in order to obtain status responses
> > within a maximum timeout.
> > (Li: backport for s0ix issue, these patches have landed on 6.9)
> > Co-developed-by: Akshata MukundShetty 
> > Signed-off-by: Akshata MukundShetty 
> > Signed-off-by: Basavaraj Natikar 
> > Signed-off-by: Jiri Kosina 
> > (cherry picked from commit 333861f4cca6d2c959ca2876587c42767853dccc)
>
> All these patches seem to already have been merged, why am I receiving
> them again with some strange metadata?

They were sent to amd-gfx as well since they are required for full
functionality of the entire platform (including the iGPU).  Sorry for
the confusion.

Alex

Re: [PATCH 1/6] HID: amd_sfh: Increase sensor command timeout

[Jiri Kosina]

On Wed, 22 May 2024, Li Ma wrote:

> From: Basavaraj Natikar 
> 
> During the initialization sensors may take some time to respond. Hence,
> increase the sensor command timeouts in order to obtain status responses
> within a maximum timeout.
> (Li: backport for s0ix issue, these patches have landed on 6.9)
> Co-developed-by: Akshata MukundShetty 
> Signed-off-by: Akshata MukundShetty 
> Signed-off-by: Basavaraj Natikar 
> Signed-off-by: Jiri Kosina 
> (cherry picked from commit 333861f4cca6d2c959ca2876587c42767853dccc)

All these patches seem to already have been merged, why am I receiving 
them again with some strange metadata?

-- 
Jiri Kosina
Director, SUSE Labs Core

[PATCH 1/6] HID: amd_sfh: Increase sensor command timeout

[Li Ma]

From: Basavaraj Natikar 

During the initialization sensors may take some time to respond. Hence,
increase the sensor command timeouts in order to obtain status responses
within a maximum timeout.
(Li: backport for s0ix issue, these patches have landed on 6.9)
Co-developed-by: Akshata MukundShetty 
Signed-off-by: Akshata MukundShetty 
Signed-off-by: Basavaraj Natikar 
Signed-off-by: Jiri Kosina 
(cherry picked from commit 333861f4cca6d2c959ca2876587c42767853dccc)
---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c 
b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index 2530fa98b568..8a4cd793d021 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -39,11 +39,11 @@ static int amd_sfh_wait_response_v2(struct amd_mp2_dev 
*mp2, u8 sid, u32 sensor_
 {
union cmd_response cmd_resp;
 
-   /* Get response with status within a max of 1600 ms timeout */
+   /* Get response with status within a max of 10 seconds timeout */
if (!readl_poll_timeout(mp2->mmio + AMD_P2C_MSG(0), cmd_resp.resp,
(cmd_resp.response_v2.response == sensor_sts &&
cmd_resp.response_v2.status == 0 && (sid == 
0xff ||
-   cmd_resp.response_v2.sensor_id == sid)), 500, 
160))
+   cmd_resp.response_v2.sensor_id == sid)), 500, 
1000))
return cmd_resp.response_v2.response;
 
return SENSOR_DISABLED;
-- 
2.25.1