Re: [PATCH 2/2] drm/amdgpu: Report VDDC and MVDD over pp_dpm{sclk,mclk}

[StDenis, Tom]

It'd be nicer to move these into the PP_SENSORS framework and then print them 
from pm_info.


But other than that I don't have any strong objections to these patches.


Tom



From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Donny Yang 
<w...@kota.moe>
Sent: Friday, January 13, 2017 03:58
To: amd-gfx@lists.freedesktop.org
Cc: Donny Yang
Subject: [PATCH 2/2] drm/amdgpu: Report VDDC and MVDD over pp_dpm{sclk,mclk}

Signed-off-by: Donny Yang <w...@kota.moe>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index 103e1330..4dd27c28 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
@@ -4065,6 +4065,8 @@ static int smu7_print_clock_levels(struct pp_hwmgr *hwmgr,
 struct smu7_single_dpm_table *sclk_table = 
&(data->dpm_table.sclk_table);
 struct smu7_single_dpm_table *mclk_table = 
&(data->dpm_table.mclk_table);
 struct smu7_single_dpm_table *pcie_table = 
&(data->dpm_table.pcie_speed_table);
+   struct smu7_single_dpm_table *vddc_table = 
&(data->dpm_table.vddc_table);
+   struct smu7_single_dpm_table *mvdd_table = 
&(data->dpm_table.mvdd_table);
 int i, now, size = 0;
 uint32_t clock, pcie_speed;

@@ -4081,8 +4083,9 @@ static int smu7_print_clock_levels(struct pp_hwmgr *hwmgr,
 now = i;

 for (i = 0; i < sclk_table->count; i++)
-   size += sprintf(buf + size, "%d: %uMhz %s\n",
+   size += sprintf(buf + size, "%d: %uMhz %umV %s\n",
 i, sclk_table->dpm_levels[i].value / 
100,
+   vddc_table->dpm_levels[i].value,
 (i == now) ? "*" : "");
 break;
 case PP_MCLK:
@@ -4097,8 +4100,9 @@ static int smu7_print_clock_levels(struct pp_hwmgr *hwmgr,
 now = i;

 for (i = 0; i < mclk_table->count; i++)
-   size += sprintf(buf + size, "%d: %uMhz %s\n",
+   size += sprintf(buf + size, "%d: %uMhz %umV %s\n",
 i, mclk_table->dpm_levels[i].value / 
100,
+   mvdd_table->dpm_levels[i].value,
 (i == now) ? "*" : "");
 break;
 case PP_PCIE:
--
2.11.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - 
lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx 
Archives. Using amd-gfx: To post a message to all the list members, send email 
...



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 2/2] drm/amdgpu: Report VDDC and MVDD over pp_dpm{sclk,mclk}

[Donny Yang]

Signed-off-by: Donny Yang 
---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index 103e1330..4dd27c28 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
@@ -4065,6 +4065,8 @@ static int smu7_print_clock_levels(struct pp_hwmgr *hwmgr,
struct smu7_single_dpm_table *sclk_table = 
&(data->dpm_table.sclk_table);
struct smu7_single_dpm_table *mclk_table = 
&(data->dpm_table.mclk_table);
struct smu7_single_dpm_table *pcie_table = 
&(data->dpm_table.pcie_speed_table);
+   struct smu7_single_dpm_table *vddc_table = 
&(data->dpm_table.vddc_table);
+   struct smu7_single_dpm_table *mvdd_table = 
&(data->dpm_table.mvdd_table);
int i, now, size = 0;
uint32_t clock, pcie_speed;
 
@@ -4081,8 +4083,9 @@ static int smu7_print_clock_levels(struct pp_hwmgr *hwmgr,
now = i;
 
for (i = 0; i < sclk_table->count; i++)
-   size += sprintf(buf + size, "%d: %uMhz %s\n",
+   size += sprintf(buf + size, "%d: %uMhz %umV %s\n",
i, sclk_table->dpm_levels[i].value / 
100,
+   vddc_table->dpm_levels[i].value,
(i == now) ? "*" : "");
break;
case PP_MCLK:
@@ -4097,8 +4100,9 @@ static int smu7_print_clock_levels(struct pp_hwmgr *hwmgr,
now = i;
 
for (i = 0; i < mclk_table->count; i++)
-   size += sprintf(buf + size, "%d: %uMhz %s\n",
+   size += sprintf(buf + size, "%d: %uMhz %umV %s\n",
i, mclk_table->dpm_levels[i].value / 
100,
+   mvdd_table->dpm_levels[i].value,
(i == now) ? "*" : "");
break;
case PP_PCIE:
-- 
2.11.0

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx