Re: [PATCH 2/2] gpu: drm: Convert printk(KERN_ to pr_
On Mon, Feb 27, 2017 at 05:31:04PM -0800, Joe Perches wrote: > Use a more common logging style. > > Miscellanea: > > o Coalesce formats and realign arguments > o Neaten a few macros now using pr_ > > Signed-off-by: Joe PerchesI know this is pain, but can you pls split this into: - amd/radeon drivers - drm core (anything that's not a subdirectory) - all other drivers for merge technical reasons? DRM is huge, we need to split big patches like this one to avoid conflict chaos. Patch 1 only touches amd stuff, so can go in directly with Alex' tree. -Daniel > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_test.c | 2 +- > drivers/gpu/drm/amd/amdgpu/atom.c | 44 - > drivers/gpu/drm/amd/amdgpu/ci_dpm.c| 4 +- > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 4 +- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 8 ++-- > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 8 ++-- > drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 4 +- > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 +- > drivers/gpu/drm/amd/include/amd_pcie_helpers.h | 4 +- > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- > drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 2 +- > drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c| 4 +- > drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 14 +++--- > .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 +- > drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 +- > drivers/gpu/drm/drm_cache.c| 12 ++--- > drivers/gpu/drm/drm_edid.c | 4 +- > drivers/gpu/drm/drm_ioc32.c| 3 +- > drivers/gpu/drm/gma500/cdv_intel_lvds.c| 9 ++-- > drivers/gpu/drm/gma500/oaktrail_lvds.c | 18 +++ > drivers/gpu/drm/gma500/psb_drv.h | 5 +- > drivers/gpu/drm/gma500/psb_intel_lvds.c| 7 ++- > drivers/gpu/drm/i915/i915_sw_fence.c | 8 ++-- > drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_acpi.c | 7 +-- > drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +- > drivers/gpu/drm/nouveau/nv50_display.c | 22 - > drivers/gpu/drm/nouveau/nvkm/core/mm.c | 10 ++-- > drivers/gpu/drm/omapdrm/dss/dsi.c | 17 --- > drivers/gpu/drm/omapdrm/dss/dss.c | 3 +- > drivers/gpu/drm/omapdrm/dss/dss.h | 15 +++--- > drivers/gpu/drm/omapdrm/omap_gem.c | 5 +- > drivers/gpu/drm/r128/r128_cce.c| 7 ++- > drivers/gpu/drm/radeon/atom.c | 46 -- > drivers/gpu/drm/radeon/cik.c | 56 > -- > drivers/gpu/drm/radeon/evergreen.c | 2 +- > drivers/gpu/drm/radeon/evergreen_cs.c | 7 ++- > drivers/gpu/drm/radeon/ni.c| 22 +++-- > drivers/gpu/drm/radeon/r100.c | 18 +++ > drivers/gpu/drm/radeon/r200.c | 3 +- > drivers/gpu/drm/radeon/r300.c | 13 ++--- > drivers/gpu/drm/radeon/r420.c | 9 ++-- > drivers/gpu/drm/radeon/r520.c | 3 +- > drivers/gpu/drm/radeon/r600.c | 21 +++- > drivers/gpu/drm/radeon/r600_cs.c | 7 ++- > drivers/gpu/drm/radeon/radeon.h| 3 +- > drivers/gpu/drm/radeon/radeon_atpx_handler.c | 4 +- > drivers/gpu/drm/radeon/radeon_audio.c | 4 +- > drivers/gpu/drm/radeon/radeon_clocks.c | 2 +- > drivers/gpu/drm/radeon/radeon_device.c | 8 ++-- > drivers/gpu/drm/radeon/radeon_fb.c | 3 +- > drivers/gpu/drm/radeon/radeon_gem.c| 4 +- > drivers/gpu/drm/radeon/radeon_test.c | 6 +-- > drivers/gpu/drm/radeon/rs400.c | 4 +- > drivers/gpu/drm/radeon/rs690.c | 3 +- > drivers/gpu/drm/radeon/rv515.c | 9 ++-- > drivers/gpu/drm/radeon/si.c| 45 ++--- > drivers/gpu/drm/ttm/ttm_bo.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 6 +-- > drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 3 +- > drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
[PATCH 2/2] gpu: drm: Convert printk(KERN_ to pr_
Use a more common logging style. Miscellanea: o Coalesce formats and realign arguments o Neaten a few macros now using pr_ Signed-off-by: Joe Perches--- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_test.c | 2 +- drivers/gpu/drm/amd/amdgpu/atom.c | 44 - drivers/gpu/drm/amd/amdgpu/ci_dpm.c| 4 +- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 4 +- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 8 ++-- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 8 ++-- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 4 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 +- drivers/gpu/drm/amd/include/amd_pcie_helpers.h | 4 +- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 2 +- drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c| 4 +- drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 14 +++--- .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 +- drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 +- drivers/gpu/drm/drm_cache.c| 12 ++--- drivers/gpu/drm/drm_edid.c | 4 +- drivers/gpu/drm/drm_ioc32.c| 3 +- drivers/gpu/drm/gma500/cdv_intel_lvds.c| 9 ++-- drivers/gpu/drm/gma500/oaktrail_lvds.c | 18 +++ drivers/gpu/drm/gma500/psb_drv.h | 5 +- drivers/gpu/drm/gma500/psb_intel_lvds.c| 7 ++- drivers/gpu/drm/i915/i915_sw_fence.c | 8 ++-- drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- drivers/gpu/drm/msm/msm_drv.c | 2 +- drivers/gpu/drm/nouveau/nouveau_acpi.c | 7 +-- drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +- drivers/gpu/drm/nouveau/nv50_display.c | 22 - drivers/gpu/drm/nouveau/nvkm/core/mm.c | 10 ++-- drivers/gpu/drm/omapdrm/dss/dsi.c | 17 --- drivers/gpu/drm/omapdrm/dss/dss.c | 3 +- drivers/gpu/drm/omapdrm/dss/dss.h | 15 +++--- drivers/gpu/drm/omapdrm/omap_gem.c | 5 +- drivers/gpu/drm/r128/r128_cce.c| 7 ++- drivers/gpu/drm/radeon/atom.c | 46 -- drivers/gpu/drm/radeon/cik.c | 56 -- drivers/gpu/drm/radeon/evergreen.c | 2 +- drivers/gpu/drm/radeon/evergreen_cs.c | 7 ++- drivers/gpu/drm/radeon/ni.c| 22 +++-- drivers/gpu/drm/radeon/r100.c | 18 +++ drivers/gpu/drm/radeon/r200.c | 3 +- drivers/gpu/drm/radeon/r300.c | 13 ++--- drivers/gpu/drm/radeon/r420.c | 9 ++-- drivers/gpu/drm/radeon/r520.c | 3 +- drivers/gpu/drm/radeon/r600.c | 21 +++- drivers/gpu/drm/radeon/r600_cs.c | 7 ++- drivers/gpu/drm/radeon/radeon.h| 3 +- drivers/gpu/drm/radeon/radeon_atpx_handler.c | 4 +- drivers/gpu/drm/radeon/radeon_audio.c | 4 +- drivers/gpu/drm/radeon/radeon_clocks.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 8 ++-- drivers/gpu/drm/radeon/radeon_fb.c | 3 +- drivers/gpu/drm/radeon/radeon_gem.c| 4 +- drivers/gpu/drm/radeon/radeon_test.c | 6 +-- drivers/gpu/drm/radeon/rs400.c | 4 +- drivers/gpu/drm/radeon/rs690.c | 3 +- drivers/gpu/drm/radeon/rv515.c | 9 ++-- drivers/gpu/drm/radeon/si.c| 45 ++--- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 6 +-- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 3 +- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 4 +- 69 files changed, 253 insertions(+), 362 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index c1b913541739..3f636632c289 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -1515,7 +1515,8 @@ void amdgpu_mm_wdoorbell(struct amdgpu_device *adev, u32 index, u32 v); */ #define RREG32(reg) amdgpu_mm_rreg(adev, (reg), false) #define RREG32_IDX(reg) amdgpu_mm_rreg(adev, (reg), true) -#define DREG32(reg) printk(KERN_INFO "REGISTER: " #reg " :