Re: [PATCH 36/37] drm/amd/display/dc/link/link_detection: Demote a couple of kerneldoc abuses
On Fri, 17 Mar 2023, Alex Deucher wrote: > Applied. Thanks! > > Alex Awesome as ever Alex. Thank you. > On Fri, Mar 17, 2023 at 4:24 AM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: > > warning: Function parameter or member 'link' not described in > > 'detect_link_and_local_sink' > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: > > warning: Function parameter or member 'reason' not described in > > 'detect_link_and_local_sink' > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:1232: > > warning: Function parameter or member 'link' not described in > > 'dc_link_detect_connection_type' > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: "Pan, Xinhui" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Lee Jones > > Cc: Wenjing Liu > > Cc: amd-gfx@lists.freedesktop.org > > Cc: dri-de...@lists.freedesktop.org > > Signed-off-by: Lee Jones > > --- > > drivers/gpu/drm/amd/display/dc/link/link_detection.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/link/link_detection.c > > b/drivers/gpu/drm/amd/display/dc/link/link_detection.c > > index 9a4cfa777622e..67addedd89563 100644 > > --- a/drivers/gpu/drm/amd/display/dc/link/link_detection.c > > +++ b/drivers/gpu/drm/amd/display/dc/link/link_detection.c > > @@ -832,7 +832,7 @@ static void verify_link_capability(struct dc_link > > *link, struct dc_sink *sink, > > verify_link_capability_non_destructive(link); > > } > > > > -/** > > +/* > > * detect_link_and_local_sink() - Detect if a sink is attached to a given > > link > > * > > * link->local_sink is created or destroyed as needed. > > @@ -1185,7 +1185,7 @@ static bool detect_link_and_local_sink(struct dc_link > > *link, > > return true; > > } > > > > -/** > > +/* > > * link_detect_connection_type() - Determine if there is a sink connected > > * > > * @type: Returned connection type > > -- > > 2.40.0.rc1.284.g88254d51c5-goog > > -- Lee Jones [李琼斯]
Re: [PATCH 36/37] drm/amd/display/dc/link/link_detection: Demote a couple of kerneldoc abuses
Applied. Thanks! Alex On Fri, Mar 17, 2023 at 4:24 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: warning: > Function parameter or member 'link' not described in > 'detect_link_and_local_sink' > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: warning: > Function parameter or member 'reason' not described in > 'detect_link_and_local_sink' > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:1232: > warning: Function parameter or member 'link' not described in > 'dc_link_detect_connection_type' > > Cc: Harry Wentland > Cc: Leo Li > Cc: Rodrigo Siqueira > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Lee Jones > Cc: Wenjing Liu > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/amd/display/dc/link/link_detection.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/link/link_detection.c > b/drivers/gpu/drm/amd/display/dc/link/link_detection.c > index 9a4cfa777622e..67addedd89563 100644 > --- a/drivers/gpu/drm/amd/display/dc/link/link_detection.c > +++ b/drivers/gpu/drm/amd/display/dc/link/link_detection.c > @@ -832,7 +832,7 @@ static void verify_link_capability(struct dc_link *link, > struct dc_sink *sink, > verify_link_capability_non_destructive(link); > } > > -/** > +/* > * detect_link_and_local_sink() - Detect if a sink is attached to a given > link > * > * link->local_sink is created or destroyed as needed. > @@ -1185,7 +1185,7 @@ static bool detect_link_and_local_sink(struct dc_link > *link, > return true; > } > > -/** > +/* > * link_detect_connection_type() - Determine if there is a sink connected > * > * @type: Returned connection type > -- > 2.40.0.rc1.284.g88254d51c5-goog >
[PATCH 36/37] drm/amd/display/dc/link/link_detection: Demote a couple of kerneldoc abuses
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: warning: Function parameter or member 'link' not described in 'detect_link_and_local_sink' drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:877: warning: Function parameter or member 'reason' not described in 'detect_link_and_local_sink' drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_detection.c:1232: warning: Function parameter or member 'link' not described in 'dc_link_detect_connection_type' Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Lee Jones Cc: Wenjing Liu Cc: amd-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/link/link_detection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/link_detection.c b/drivers/gpu/drm/amd/display/dc/link/link_detection.c index 9a4cfa777622e..67addedd89563 100644 --- a/drivers/gpu/drm/amd/display/dc/link/link_detection.c +++ b/drivers/gpu/drm/amd/display/dc/link/link_detection.c @@ -832,7 +832,7 @@ static void verify_link_capability(struct dc_link *link, struct dc_sink *sink, verify_link_capability_non_destructive(link); } -/** +/* * detect_link_and_local_sink() - Detect if a sink is attached to a given link * * link->local_sink is created or destroyed as needed. @@ -1185,7 +1185,7 @@ static bool detect_link_and_local_sink(struct dc_link *link, return true; } -/** +/* * link_detect_connection_type() - Determine if there is a sink connected * * @type: Returned connection type -- 2.40.0.rc1.284.g88254d51c5-goog
