Re: [PATCH 4/7] drm/selftests: add drm buddy optimistic testcase

2022-02-08 Thread Matthew Auld

On 03/02/2022 13:32, Arunpravin wrote:

create a mm with one block of each order available, and
try to allocate them all.

Signed-off-by: Arunpravin 

Reviewed-by: Matthew Auld 


[PATCH 4/7] drm/selftests: add drm buddy optimistic testcase

2022-02-03 Thread Arunpravin
create a mm with one block of each order available, and
try to allocate them all.

Signed-off-by: Arunpravin 
---
 .../gpu/drm/selftests/drm_buddy_selftests.h   |  1 +
 drivers/gpu/drm/selftests/test-drm_buddy.c| 82 +++
 2 files changed, 83 insertions(+)

diff --git a/drivers/gpu/drm/selftests/drm_buddy_selftests.h 
b/drivers/gpu/drm/selftests/drm_buddy_selftests.h
index 3230bfd2770b..21a6bd38864f 100644
--- a/drivers/gpu/drm/selftests/drm_buddy_selftests.h
+++ b/drivers/gpu/drm/selftests/drm_buddy_selftests.h
@@ -9,3 +9,4 @@
 selftest(sanitycheck, igt_sanitycheck) /* keep first (selfcheck for igt) */
 selftest(buddy_alloc_limit, igt_buddy_alloc_limit)
 selftest(buddy_alloc_range, igt_buddy_alloc_range)
+selftest(buddy_alloc_optimistic, igt_buddy_alloc_optimistic)
diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c 
b/drivers/gpu/drm/selftests/test-drm_buddy.c
index e347060c05a2..b193d9556fb4 100644
--- a/drivers/gpu/drm/selftests/test-drm_buddy.c
+++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
@@ -17,6 +17,11 @@
 
 static unsigned int random_seed;
 
+static inline u64 get_size(int order, u64 chunk_size)
+{
+   return (1 << order) * chunk_size;
+}
+
 static inline const char *yesno(bool v)
 {
return v ? "yes" : "no";
@@ -309,6 +314,83 @@ static void igt_mm_config(u64 *size, u64 *chunk_size)
*size = (u64)s << 12;
 }
 
+static int igt_buddy_alloc_optimistic(void *arg)
+{
+   u64 mm_size, size, min_page_size, start = 0;
+   struct drm_buddy_block *block;
+   unsigned long flags = 0;
+   const int max_order = 16;
+   struct drm_buddy mm;
+   LIST_HEAD(blocks);
+   LIST_HEAD(tmp);
+   int order, err;
+
+   /*
+* Create a mm with one block of each order available, and
+* try to allocate them all.
+*/
+
+   mm_size = PAGE_SIZE * ((1 << (max_order + 1)) - 1);
+   err = drm_buddy_init(,
+mm_size,
+PAGE_SIZE);
+   if (err) {
+   pr_err("buddy_init failed(%d)\n", err);
+   return err;
+   }
+
+   BUG_ON(mm.max_order != max_order);
+
+   for (order = 0; order <= max_order; order++) {
+   size = min_page_size = get_size(order, PAGE_SIZE);
+   err = drm_buddy_alloc_blocks(, start, mm_size, size, 
min_page_size, , flags);
+   if (err) {
+   pr_info("buddy_alloc hit -ENOMEM with order=%d\n",
+   order);
+   goto err;
+   }
+
+   block = list_first_entry_or_null(,
+struct drm_buddy_block,
+link);
+   if (!block) {
+   pr_err("alloc_blocks has no blocks\n");
+   err = -EINVAL;
+   goto err;
+   }
+
+   list_del(>link);
+   list_add_tail(>link, );
+   }
+
+   /* Should be completely full! */
+   size = min_page_size = get_size(0, PAGE_SIZE);
+   err = drm_buddy_alloc_blocks(, start, mm_size, size, min_page_size, 
, flags);
+   if (!err) {
+   pr_info("buddy_alloc unexpectedly succeeded, it should be 
full!");
+   block = list_first_entry_or_null(,
+struct drm_buddy_block,
+link);
+   if (!block) {
+   pr_err("alloc_blocks has no blocks\n");
+   err = -EINVAL;
+   goto err;
+   }
+
+   list_del(>link);
+   list_add_tail(>link, );
+   goto err;
+   } else {
+   pr_info("%s - succeeded\n", __func__);
+   err = 0;
+   }
+
+err:
+   drm_buddy_free_list(, );
+   drm_buddy_fini();
+   return err;
+}
+
 static int igt_buddy_alloc_range(void *arg)
 {
unsigned long flags = DRM_BUDDY_RANGE_ALLOCATION;
-- 
2.25.1