Re: [PATCH v2] drm/amd/powerplay:clean up the residual mutex for smu_hw_init
Reviewed-by: Kevin Wang On 6/25/19 3:43 PM, Prike Liang wrote: > The mutex for procting SMU during hw_init was removed as system > will be deadlock when smu_populate_umd_state_clk try get SMU mutex. > Therefore need remove the residual mutex from failed path. > > Change-Id: Id8019c01b9496c067efda4817a46983e4da3b6e4 > Signed-off-by: Prike Liang > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index f61ecbf..fe83c5e 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -1044,7 +1044,6 @@ static int smu_hw_init(void *handle) > return 0; > > failed: > - mutex_unlock(&smu->mutex); > return ret; > } > ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[PATCH v2] drm/amd/powerplay:clean up the residual mutex for smu_hw_init
The mutex for procting SMU during hw_init was removed as system will be deadlock when smu_populate_umd_state_clk try get SMU mutex. Therefore need remove the residual mutex from failed path. Change-Id: Id8019c01b9496c067efda4817a46983e4da3b6e4 Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c index f61ecbf..fe83c5e 100644 --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c @@ -1044,7 +1044,6 @@ static int smu_hw_init(void *handle) return 0; failed: - mutex_unlock(&smu->mutex); return ret; } -- 2.7.4 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
