Re: [PATCH v2] drm/radeon: only warn once in radeon_ttm_bo_destroy if va list not empty

[Christian König]

Am 27.04.2017 um 16:10 schrieb Julien Isorce:

Encountered a dozen of exact same backtraces when mesa's
pb_cache_release_all_buffers is called after that a gpu reset failed.

v2: Remove superfluous error message added in v1.

bug: https://bugs.freedesktop.org/show_bug.cgi?id=96271

Signed-off-by: Julien Isorce 


Reviewed-by: Christian König 


---
  drivers/gpu/drm/radeon/radeon_object.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_object.c 
b/drivers/gpu/drm/radeon/radeon_object.c
index bec2ec0..8b72229 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -81,7 +81,7 @@ static void radeon_ttm_bo_destroy(struct ttm_buffer_object 
*tbo)
list_del_init(>list);
mutex_unlock(>rdev->gem.mutex);
radeon_bo_clear_surface_reg(bo);
-   WARN_ON(!list_empty(>va));
+   WARN_ON_ONCE(!list_empty(>va));
drm_gem_object_release(>gem_base);
kfree(bo);
  }



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH v2] drm/radeon: only warn once in radeon_ttm_bo_destroy if va list not empty

[Julien Isorce]

Encountered a dozen of exact same backtraces when mesa's
pb_cache_release_all_buffers is called after that a gpu reset failed.

v2: Remove superfluous error message added in v1.

bug: https://bugs.freedesktop.org/show_bug.cgi?id=96271

Signed-off-by: Julien Isorce 
---
 drivers/gpu/drm/radeon/radeon_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_object.c 
b/drivers/gpu/drm/radeon/radeon_object.c
index bec2ec0..8b72229 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -81,7 +81,7 @@ static void radeon_ttm_bo_destroy(struct ttm_buffer_object 
*tbo)
list_del_init(>list);
mutex_unlock(>rdev->gem.mutex);
radeon_bo_clear_surface_reg(bo);
-   WARN_ON(!list_empty(>va));
+   WARN_ON_ONCE(!list_empty(>va));
drm_gem_object_release(>gem_base);
kfree(bo);
 }
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx