Re: [PATCH v2 0/2] Fix issues caused by DML2 in ASICs older than DCN35
On 10/20/23 15:38, Harry Wentland wrote: On 2023-10-20 17:26, Rodrigo Siqueira wrote: The first commit of this series just sets the variable using_dml2 to false for all ASICs that do not require it. The second commit adds a fix to the DC sequence that calls a DML2 operation in ASICs that does not use it. Cc: Vitaly Prosyak Cc: Roman Li Cc: Qingqing Zhuo Cc: Daniel Wheeler Cc: Alex Deucher Didn't realize this would make the change much bigger but I think it'll be more consistent in the long-term. Reviewed-by: Harry Wentland Thanks Harry Harry Rodrigo Siqueira (2): drm/amd/display: Set the DML2 attribute to false in all DCNs older than version 3.5 drm/amd/display: Fix DMUB errors introduced by DML2 drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 9 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dcn315/dcn315_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn316/dcn316_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c | 1 + 14 files changed, 20 insertions(+), 6 deletions(-)
Re: [PATCH v2 0/2] Fix issues caused by DML2 in ASICs older than DCN35
On 2023-10-20 17:26, Rodrigo Siqueira wrote: > The first commit of this series just sets the variable using_dml2 to > false for all ASICs that do not require it. The second commit adds a fix > to the DC sequence that calls a DML2 operation in ASICs that does not > use it. > > Cc: Vitaly Prosyak > Cc: Roman Li > Cc: Qingqing Zhuo > Cc: Daniel Wheeler > Cc: Alex Deucher > Didn't realize this would make the change much bigger but I think it'll be more consistent in the long-term. Reviewed-by: Harry Wentland Harry > Rodrigo Siqueira (2): > drm/amd/display: Set the DML2 attribute to false in all DCNs older > than version 3.5 > drm/amd/display: Fix DMUB errors introduced by DML2 > > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 9 + > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 3 ++- > drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 3 ++- > drivers/gpu/drm/amd/display/dc/dcn315/dcn315_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn316/dcn316_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c | 1 + > 14 files changed, 20 insertions(+), 6 deletions(-) >
[PATCH v2 0/2] Fix issues caused by DML2 in ASICs older than DCN35
The first commit of this series just sets the variable using_dml2 to false for all ASICs that do not require it. The second commit adds a fix to the DC sequence that calls a DML2 operation in ASICs that does not use it. Cc: Vitaly Prosyak Cc: Roman Li Cc: Qingqing Zhuo Cc: Daniel Wheeler Cc: Alex Deucher Rodrigo Siqueira (2): drm/amd/display: Set the DML2 attribute to false in all DCNs older than version 3.5 drm/amd/display: Fix DMUB errors introduced by DML2 drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 9 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dcn315/dcn315_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn316/dcn316_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c | 1 + 14 files changed, 20 insertions(+), 6 deletions(-) -- 2.42.0
