RE: [PATCH] SWDEV-227226 [AWS][Linux]ReallyQuick test failed, guest dmesg and host dmesg have error

2020-03-26 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Emily Deng 

>-Original Message-
>From: amd-gfx  On Behalf Of Gu,
>JiaWei (Will)
>Sent: Thursday, March 26, 2020 1:58 PM
>To: amd-gfx@lists.freedesktop.org
>Subject: RE: [PATCH] SWDEV-227226 [AWS][Linux]ReallyQuick test failed, guest
>dmesg and host dmesg have error
>
>[AMD Official Use Only - Internal Distribution Only]
>
>Ping..
>
>-Original Message-
>From: Jiawei 
>Sent: Wednesday, March 25, 2020 4:32 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Gu, JiaWei (Will) 
>Subject: [PATCH] SWDEV-227226 [AWS][Linux]ReallyQuick test failed, guest
>dmesg and host dmesg have error
>
>root cause: compute job timeout for sriov/passthrough is 1 ms, which is too
>short for some compute benchmark
>
>solution: extend the default compute lockup timeout to 6 ms
>
>Signed-off-by: Jiawei 
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>index 3607a63f48bb..88360b220a8f 100755
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>@@ -2680,12 +2680,12 @@ static int
>amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev)
>* By default timeout for non compute jobs is 1.
>* And there is no timeout enforced on compute jobs.
>* In SR-IOV or passthrough mode, timeout for compute
>-   * jobs are 1 by default.
>+   * jobs are 6 by default.
>*/
>   adev->gfx_timeout = msecs_to_jiffies(1);
>   adev->sdma_timeout = adev->video_timeout = adev->gfx_timeout;
>   if (amdgpu_sriov_vf(adev) || amdgpu_passthrough(adev))
>-  adev->compute_timeout = adev->gfx_timeout;
>+  adev->compute_timeout =  msecs_to_jiffies(6);
>   else
>   adev->compute_timeout = MAX_SCHEDULE_TIMEOUT;
>
>--
>2.20.1
>___
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.free
>desktop.org%2Fmailman%2Flistinfo%2Famd-
>gfxdata=02%7C01%7CEmily.Deng%40amd.com%7Cef72ce0afbaf4ed9b1a
>708d7d14a9e8b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637
>207990753889298sdata=febWyY9VUPq2hucVLit73FilxzacEmoIq1TBLFha
>%2FNM%3Dreserved=0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


RE: [PATCH] SWDEV-227226 [AWS][Linux]ReallyQuick test failed, guest dmesg and host dmesg have error

2020-03-25 Thread Gu, JiaWei (Will)
[AMD Official Use Only - Internal Distribution Only]

Ping..

-Original Message-
From: Jiawei  
Sent: Wednesday, March 25, 2020 4:32 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gu, JiaWei (Will) 
Subject: [PATCH] SWDEV-227226 [AWS][Linux]ReallyQuick test failed, guest dmesg 
and host dmesg have error

root cause: compute job timeout for sriov/passthrough is 1 ms, which is too 
short for some compute benchmark

solution: extend the default compute lockup timeout to 6 ms

Signed-off-by: Jiawei 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 3607a63f48bb..88360b220a8f 100755
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2680,12 +2680,12 @@ static int 
amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev)
 * By default timeout for non compute jobs is 1.
 * And there is no timeout enforced on compute jobs.
 * In SR-IOV or passthrough mode, timeout for compute
-* jobs are 1 by default.
+* jobs are 6 by default.
 */
adev->gfx_timeout = msecs_to_jiffies(1);
adev->sdma_timeout = adev->video_timeout = adev->gfx_timeout;
if (amdgpu_sriov_vf(adev) || amdgpu_passthrough(adev))
-   adev->compute_timeout = adev->gfx_timeout;
+   adev->compute_timeout =  msecs_to_jiffies(6);
else
adev->compute_timeout = MAX_SCHEDULE_TIMEOUT;
 
--
2.20.1
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx