RE: [PATCH] drm/amd/pm: Add vclk and dclk sysnode for GC 9.4.3

[Chen, Guchun]

[Public]

> -Original Message-
> From: amd-gfx  On Behalf Of Asad
> Kamal
> Sent: Wednesday, August 9, 2023 5:10 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Lazar, Lijo ; Kamal, Asad ;
> Zhang, Hawking 
> Subject: [PATCH] drm/amd/pm: Add vclk and dclk sysnode for GC 9.4.3
>
> Expose sysfs vclck and dclk entries for GC version 9.4.3
>
> Signed-off-by: Asad Kamal 
> Reviewed-by: Lijo Lazar 
> ---
>  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 3922dd274f30..e4183d6d7f39 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2095,7 +2095,8 @@ static int default_attr_update(struct
> amdgpu_device *adev, struct amdgpu_device_
> gc_ver == IP_VERSION(10, 1, 2) ||
> gc_ver == IP_VERSION(11, 0, 0) ||
> gc_ver == IP_VERSION(11, 0, 2) ||
> -   gc_ver == IP_VERSION(11, 0, 3)))
> +   gc_ver == IP_VERSION(11, 0, 3) ||
> +   gc_ver == IP_VERSION(9, 4, 3)))

I suggest to put IP_VERSION(9, 4, 3) prior to IP_VERSION(10...) to maintain it 
numerically.

>   *states = ATTR_STATE_UNSUPPORTED;
>   } else if (DEVICE_ATTR_IS(pp_dpm_vclk1)) {
>   if (!((gc_ver == IP_VERSION(10, 3, 1) || @@ -2109,7 +2110,8
> @@ static int default_attr_update(struct amdgpu_device *adev, struct
> amdgpu_device_
> gc_ver == IP_VERSION(10, 1, 2) ||
> gc_ver == IP_VERSION(11, 0, 0) ||
> gc_ver == IP_VERSION(11, 0, 2) ||
> -   gc_ver == IP_VERSION(11, 0, 3)))
> +   gc_ver == IP_VERSION(11, 0, 3) ||
> +   gc_ver == IP_VERSION(9, 4, 3)))

Same as above.

Regards,
Guchun

>   *states = ATTR_STATE_UNSUPPORTED;
>   } else if (DEVICE_ATTR_IS(pp_dpm_dclk1)) {
>   if (!((gc_ver == IP_VERSION(10, 3, 1) ||
> --
> 2.34.1

RE: [PATCH] drm/amd/pm: Add vclk and dclk sysnode for GC 9.4.3

[Zhang, Hawking]

[AMD Official Use Only - General]

Reviewed-by: Hawking Zhang 

Regards,
Hawking
-Original Message-
From: Kamal, Asad 
Sent: Wednesday, August 9, 2023 17:10
To: amd-gfx@lists.freedesktop.org
Cc: Kamal, Asad ; Zhang, Hawking ; 
Lazar, Lijo 
Subject: [PATCH] drm/amd/pm: Add vclk and dclk sysnode for GC 9.4.3

Expose sysfs vclck and dclk entries for GC version 9.4.3

Signed-off-by: Asad Kamal 
Reviewed-by: Lijo Lazar 
---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c 
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 3922dd274f30..e4183d6d7f39 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -2095,7 +2095,8 @@ static int default_attr_update(struct amdgpu_device 
*adev, struct amdgpu_device_
  gc_ver == IP_VERSION(10, 1, 2) ||
  gc_ver == IP_VERSION(11, 0, 0) ||
  gc_ver == IP_VERSION(11, 0, 2) ||
- gc_ver == IP_VERSION(11, 0, 3)))
+ gc_ver == IP_VERSION(11, 0, 3) ||
+ gc_ver == IP_VERSION(9, 4, 3)))
*states = ATTR_STATE_UNSUPPORTED;
} else if (DEVICE_ATTR_IS(pp_dpm_vclk1)) {
if (!((gc_ver == IP_VERSION(10, 3, 1) || @@ -2109,7 +2110,8 @@ 
static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
  gc_ver == IP_VERSION(10, 1, 2) ||
  gc_ver == IP_VERSION(11, 0, 0) ||
  gc_ver == IP_VERSION(11, 0, 2) ||
- gc_ver == IP_VERSION(11, 0, 3)))
+ gc_ver == IP_VERSION(11, 0, 3) ||
+ gc_ver == IP_VERSION(9, 4, 3)))
*states = ATTR_STATE_UNSUPPORTED;
} else if (DEVICE_ATTR_IS(pp_dpm_dclk1)) {
if (!((gc_ver == IP_VERSION(10, 3, 1) ||
--
2.34.1