RE: [PATCH] drm/amdgpu: Remove IMU ucode in vf2pf

[Chen, Horace]

[AMD Official Use Only - General]

Reviewed-By: Horace Chen 

-Original Message-
From: YuanShang Mao (River) 
Sent: Tuesday, May 9, 2023 3:32 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yin, ZhenGuo (Chris) ; Chen, Horace 
; YuanShang Mao (River) 
Subject: [PATCH] drm/amdgpu: Remove IMU ucode in vf2pf

The IMU firmware is loaded on the host side, not the guest.
Remove IMU in vf2pf ucode id enum.

Signed-off-by: YuanShang 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c| 1 -
 drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 1311e42ab8e9..0af871735a74 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -557,7 +557,6 @@ static void amdgpu_virt_populate_vf2pf_ucode_info(struct 
amdgpu_device *adev)
POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_RLC_SRLS, 
adev->gfx.rlc_srls_fw_version);
POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_MEC,  
adev->gfx.mec_fw_version);
POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_MEC2, 
adev->gfx.mec2_fw_version);
-   POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_IMU,  
adev->gfx.imu_fw_version);
POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_SOS,  
adev->psp.sos.fw_version);
POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_ASD,
adev->psp.asd_context.bin_desc.fw_version);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h 
b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
index 24d42d24e6a0..104a5ad8397d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
@@ -70,7 +70,6 @@ enum amd_sriov_ucode_engine_id {
AMD_SRIOV_UCODE_ID_RLC_SRLS,
AMD_SRIOV_UCODE_ID_MEC,
AMD_SRIOV_UCODE_ID_MEC2,
-   AMD_SRIOV_UCODE_ID_IMU,
AMD_SRIOV_UCODE_ID_SOS,
AMD_SRIOV_UCODE_ID_ASD,
AMD_SRIOV_UCODE_ID_TA_RAS,
--
2.25.1

RE: [PATCH] drm/amdgpu: Remove IMU ucode in vf2pf

[Deucher, Alexander]

[Public]

> -Original Message-
> From: amd-gfx  On Behalf Of
> YuanShang
> Sent: Tuesday, May 9, 2023 5:16 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Yin, ZhenGuo (Chris) ; Chen, Horace
> ; YuanShang Mao (River)
> 
> Subject: [PATCH] drm/amdgpu: Remove IMU ucode in vf2pf
> 
> The IMU firmware is loaded on the host side, not the guest.
> Remove IMU in vf2pf ucode id enum.
> 
> Signed-off-by: YuanShang 

Acked-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c| 1 -
>  drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 1311e42ab8e9..0af871735a74 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -557,7 +557,6 @@ static void
> amdgpu_virt_populate_vf2pf_ucode_info(struct amdgpu_device *adev)
>   POPULATE_UCODE_INFO(vf2pf_info,
> AMD_SRIOV_UCODE_ID_RLC_SRLS, adev->gfx.rlc_srls_fw_version);
>   POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_MEC,
> adev->gfx.mec_fw_version);
>   POPULATE_UCODE_INFO(vf2pf_info,
> AMD_SRIOV_UCODE_ID_MEC2, adev->gfx.mec2_fw_version);
> - POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_IMU,
> adev->gfx.imu_fw_version);
>   POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_SOS,
> adev->psp.sos.fw_version);
>   POPULATE_UCODE_INFO(vf2pf_info, AMD_SRIOV_UCODE_ID_ASD,
>   adev->psp.asd_context.bin_desc.fw_version);
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
> b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
> index 24d42d24e6a0..104a5ad8397d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
> @@ -70,7 +70,6 @@ enum amd_sriov_ucode_engine_id {
>   AMD_SRIOV_UCODE_ID_RLC_SRLS,
>   AMD_SRIOV_UCODE_ID_MEC,
>   AMD_SRIOV_UCODE_ID_MEC2,
> - AMD_SRIOV_UCODE_ID_IMU,
>   AMD_SRIOV_UCODE_ID_SOS,
>   AMD_SRIOV_UCODE_ID_ASD,
>   AMD_SRIOV_UCODE_ID_TA_RAS,
> --
> 2.25.1