Re: [PATCH 1/3] drm/amdgpu/gmc11: disable AGP aperture

[Christian König]

Am 09.11.23 um 15:41 schrieb Alex Deucher:

We've had misc reports of random IOMMU page faults when
this is used.  It's just a rarely used optimization anyway, so
let's just disable it.

Signed-off-by: Alex Deucher 


Acked-by: Christian König  for the series.


---
  drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c 
b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
index 6dce9b29f675..e1cac5da9c4b 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
@@ -640,9 +640,6 @@ static void gmc_v11_0_vram_gtt_location(struct 
amdgpu_device *adev,
amdgpu_gmc_set_agp_default(adev, mc);
amdgpu_gmc_vram_location(adev, >gmc, base);
amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_HIGH);
-   if (!amdgpu_sriov_vf(adev) ||
-   (amdgpu_ip_version(adev, GC_HWIP, 0) < IP_VERSION(11, 5, 0)))
-   amdgpu_gmc_agp_location(adev, mc);
  
  	/* base offset of vram pages */

if (amdgpu_sriov_vf(adev))

RE: [PATCH 1/3] drm/amdgpu/gmc11: disable AGP aperture

[Wang, Yang(Kevin)]

Series is
Reviewed-by: Yang Wang 

Best Regards,
Kevin

-Original Message-
From: amd-gfx  On Behalf Of Alex Deucher
Sent: Thursday, November 9, 2023 10:42 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander 
Subject: [PATCH 1/3] drm/amdgpu/gmc11: disable AGP aperture

We've had misc reports of random IOMMU page faults when this is used.  It's 
just a rarely used optimization anyway, so let's just disable it.

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c 
b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
index 6dce9b29f675..e1cac5da9c4b 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
@@ -640,9 +640,6 @@ static void gmc_v11_0_vram_gtt_location(struct 
amdgpu_device *adev,
amdgpu_gmc_set_agp_default(adev, mc);
amdgpu_gmc_vram_location(adev, >gmc, base);
amdgpu_gmc_gart_location(adev, mc, AMDGPU_GART_PLACEMENT_HIGH);
-   if (!amdgpu_sriov_vf(adev) ||
-   (amdgpu_ip_version(adev, GC_HWIP, 0) < IP_VERSION(11, 5, 0)))
-   amdgpu_gmc_agp_location(adev, mc);
 
/* base offset of vram pages */
if (amdgpu_sriov_vf(adev))
--
2.41.0