RE: [PATCH 12/22] drm/amd/pm: remove logically dead code

2024-05-12 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only]

Acked-by: Yang Wang 

Best Regards,
Kevin

-Original Message-
From: amd-gfx  On Behalf Of Zhang, 
Jesse(Jie)
Sent: Monday, May 13, 2024 10:19 AM
To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian 
; Huang, Tim 
Subject: RE: [PATCH 12/22] drm/amd/pm: remove logically dead code

[AMD Official Use Only - AMD Internal Distribution Only]

[AMD Official Use Only - AMD Internal Distribution Only]

Ping ...

-Original Message-
From: amd-gfx  On Behalf Of Jesse Zhang
Sent: Friday, May 10, 2024 10:50 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian 
; Huang, Tim ; Zhang, Jesse(Jie) 
; Zhang, Jesse(Jie) 
Subject: [PATCH 12/22] drm/amd/pm: remove logically dead code

Execution cannot reach this statement: case POWER_STATE_TYPE_BALAN.

Signed-off-by: Jesse Zhang 
---
 drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c | 9 -
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c 
b/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c
index 60377747bab4..e861355ebd75 100644
--- a/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c
+++ b/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c
@@ -831,15 +831,6 @@ static struct amdgpu_ps 
*amdgpu_dpm_pick_power_state(struct amdgpu_device *adev,
return ps;
}
break;
-   case POWER_STATE_TYPE_BALANCED:
-   if (ui_class == ATOM_PPLIB_CLASSIFICATION_UI_BALANCED) {
-   if (ps->caps & ATOM_PPLIB_SINGLE_DISPLAY_ONLY) {
-   if (single_display)
-   return ps;
-   } else
-   return ps;
-   }
-   break;
case POWER_STATE_TYPE_PERFORMANCE:
if (ui_class == 
ATOM_PPLIB_CLASSIFICATION_UI_PERFORMANCE) {
if (ps->caps & ATOM_PPLIB_SINGLE_DISPLAY_ONLY) {
--
2.25.1

<>

RE: [PATCH 12/22] drm/amd/pm: remove logically dead code

2024-05-12 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - AMD Internal Distribution Only]

Ping ...

-Original Message-
From: amd-gfx  On Behalf Of Jesse Zhang
Sent: Friday, May 10, 2024 10:50 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian 
; Huang, Tim ; Zhang, Jesse(Jie) 
; Zhang, Jesse(Jie) 
Subject: [PATCH 12/22] drm/amd/pm: remove logically dead code

Execution cannot reach this statement: case POWER_STATE_TYPE_BALAN.

Signed-off-by: Jesse Zhang 
---
 drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c | 9 -
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c 
b/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c
index 60377747bab4..e861355ebd75 100644
--- a/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c
+++ b/drivers/gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c
@@ -831,15 +831,6 @@ static struct amdgpu_ps 
*amdgpu_dpm_pick_power_state(struct amdgpu_device *adev,
return ps;
}
break;
-   case POWER_STATE_TYPE_BALANCED:
-   if (ui_class == ATOM_PPLIB_CLASSIFICATION_UI_BALANCED) {
-   if (ps->caps & ATOM_PPLIB_SINGLE_DISPLAY_ONLY) {
-   if (single_display)
-   return ps;
-   } else
-   return ps;
-   }
-   break;
case POWER_STATE_TYPE_PERFORMANCE:
if (ui_class == 
ATOM_PPLIB_CLASSIFICATION_UI_PERFORMANCE) {
if (ps->caps & ATOM_PPLIB_SINGLE_DISPLAY_ONLY) {
--
2.25.1