Re: [PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd
On Mon, Apr 11, 2022 at 09:43:06AM -0700, Nathan Chancellor wrote:
> Hi everyone,
>
> These two patches resolve two instances of -Wstrict-prototypes with
> newer versions of clang that are present in 5.4. The main Makefile makes
> this a hard error.
>
> The first patch is upstream commit 63617d8b125e ("drm/amdkfd: add
> missing void argument to function kgd2kfd_init"), which showed up in
> 5.5.
>
> The second patch has no upstream equivalent, as the code in question was
> removed in commit e392c887df97 ("drm/amdkfd: Use array to probe
> kfd2kgd_calls") upstream, which is part of a larger series that did not
> look reasonable for stable. I opted to just fix the warning in the same
> manner as the prior patch, which is less risky and accomplishes the same
> end result of no warning.
>
> Colin Ian King (1):
> drm/amdkfd: add missing void argument to function kgd2kfd_init
>
> Nathan Chancellor (1):
> drm/amdkfd: Fix -Wstrict-prototypes from
> amdgpu_amdkfd_gfx_10_0_get_functions()
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 2 +-
> drivers/gpu/drm/amd/amdkfd/kfd_module.c| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
> base-commit: 2845ff3fd34499603249676495c524a35e795b45
> --
> 2.35.1
>
Now queued up, thanks.
greg k-h
RE: [PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd
[Public]
> -Original Message-
> From: Nathan Chancellor
> Sent: Monday, April 11, 2022 12:43 PM
> To: Greg Kroah-Hartman ; Sasha Levin
>
> Cc: Kuehling, Felix ; Deucher, Alexander
> ; Nick Desaulniers
> ; amd-gfx@lists.freedesktop.org;
> l...@lists.linux.dev; sta...@vger.kernel.org; Nathan Chancellor
>
> Subject: [PATCH 5.4 0/2] Fix two instances of -Wstrict-prototypes in drm/amd
>
> Hi everyone,
>
> These two patches resolve two instances of -Wstrict-prototypes with newer
> versions of clang that are present in 5.4. The main Makefile makes this a hard
> error.
>
> The first patch is upstream commit 63617d8b125e ("drm/amdkfd: add missing
> void argument to function kgd2kfd_init"), which showed up in 5.5.
>
> The second patch has no upstream equivalent, as the code in question was
> removed in commit e392c887df97 ("drm/amdkfd: Use array to probe
> kfd2kgd_calls") upstream, which is part of a larger series that did not look
> reasonable for stable. I opted to just fix the warning in the same manner as
> the prior patch, which is less risky and accomplishes the same end result of
> no
> warning.
>
> Colin Ian King (1):
> drm/amdkfd: add missing void argument to function kgd2kfd_init
>
> Nathan Chancellor (1):
> drm/amdkfd: Fix -Wstrict-prototypes from
> amdgpu_amdkfd_gfx_10_0_get_functions()
Series is:
Acked-by: Alex Deucher
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 2 +-
> drivers/gpu/drm/amd/amdkfd/kfd_module.c| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
> base-commit: 2845ff3fd34499603249676495c524a35e795b45
> --
> 2.35.1
