Re: [PATCH v2] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Lazar, Lijo

On 1/18/2024 11:07 AM, Yang Wang wrote:

From: Yang Wang 

v1:
enable amdgpu smu driver message log.

v2:
add smu/pmfw response value into debug log.

Signed-off-by: Yang Wang 


Reviewed-by: Lijo Lazar 

Thanks,
Lijo


---
  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 9 -
  1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 00cd615bbcdc..b8dbd4e25348 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -378,8 +378,15 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context 
*smu,
res = __smu_cmn_reg2errno(smu, reg);
if (res != 0)
__smu_cmn_reg_print_error(smu, reg, index, param, msg);
-   if (read_arg)
+   if (read_arg) {
smu_cmn_read_arg(smu, read_arg);
+   dev_dbg(adev->dev, "smu send message: %s(%d) param: 0x%08x, 
resp: 0x%08x,\
+   readval: 0x%08x\n",
+   smu_get_message_name(smu, msg), index, param, reg, 
*read_arg);
+   } else {
+   dev_dbg(adev->dev, "smu send message: %s(%d) param: 0x%08x, resp: 
0x%08x\n",
+   smu_get_message_name(smu, msg), index, param, reg);
+   }
  Out:
if (unlikely(adev->pm.smu_debug_mask & SMU_DEBUG_HALT_ON_ERROR) && res) 
{
amdgpu_device_halt(adev);




RE: [PATCH v2] drm/amd/pm: enable amdgpu smu send message log

2024-01-17 Thread Feng, Kenneth
[AMD Official Use Only - General]

Reviewed-by: Kenneth Feng 


-Original Message-
From: amd-gfx  On Behalf Of Yang Wang
Sent: Thursday, January 18, 2024 1:37 PM
To: amd-gfx@lists.freedesktop.org
Cc: Lazar, Lijo ; Feng, Kenneth ; 
Wang, Yang(Kevin) 
Subject: [PATCH v2] drm/amd/pm: enable amdgpu smu send message log

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


From: Yang Wang 

v1:
enable amdgpu smu driver message log.

v2:
add smu/pmfw response value into debug log.

Signed-off-by: Yang Wang 
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 00cd615bbcdc..b8dbd4e25348 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -378,8 +378,15 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context 
*smu,
res = __smu_cmn_reg2errno(smu, reg);
if (res != 0)
__smu_cmn_reg_print_error(smu, reg, index, param, msg);
-   if (read_arg)
+   if (read_arg) {
smu_cmn_read_arg(smu, read_arg);
+   dev_dbg(adev->dev, "smu send message: %s(%d) param: 0x%08x, 
resp: 0x%08x,\
+   readval: 0x%08x\n",
+   smu_get_message_name(smu, msg), index, param, reg, 
*read_arg);
+   } else {
+   dev_dbg(adev->dev, "smu send message: %s(%d) param: 0x%08x, 
resp: 0x%08x\n",
+   smu_get_message_name(smu, msg), index, param, reg);
+   }
 Out:
if (unlikely(adev->pm.smu_debug_mask & SMU_DEBUG_HALT_ON_ERROR) && res) 
{
amdgpu_device_halt(adev);
--
2.34.1