Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
On Wed, Feb 02, 2022 at 03:57:50PM +0100, Christoph Hellwig wrote: > On Thu, Jan 27, 2022 at 02:32:58PM -0800, Andrew Morton wrote: > > On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra wrote: > > > > > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory > > > owned by a device that can be mapped into CPU page tables like > > > MEMORY_DEVICE_GENERIC and can also be migrated like > > > MEMORY_DEVICE_PRIVATE. > > > > Some more reviewer input appears to be desirable here. > > > > I was going to tentatively add it to -mm and -next, but problems. > > 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different > > from the tree you patched. Please redo, refresh and resend? > > I really hate adding more types with the weird one off page refcount. > We need to clean that mess up first. Is there anyone who could give an outline of what is needed to make fsdax use compound pages/folios for its PMD stuff? I already suggested removing that as a way forward, and was shot down, but nobody is standing up to maintain this code and fix it :( We got devdax and the DRM stuff fixed now, so FSDAX is the next blocker on this work. The people who want this to advance have no idea about FSs or what to do, unfortunately. Jason
Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
On Thu, Jan 27, 2022 at 02:32:58PM -0800, Andrew Morton wrote: > On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra wrote: > > > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory > > owned by a device that can be mapped into CPU page tables like > > MEMORY_DEVICE_GENERIC and can also be migrated like > > MEMORY_DEVICE_PRIVATE. > > Some more reviewer input appears to be desirable here. > > I was going to tentatively add it to -mm and -next, but problems. > 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different > from the tree you patched. Please redo, refresh and resend? I really hate adding more types with the weird one off page refcount. We need to clean that mess up first.
Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
Thank you, Alex for your persistence with this patch series. Fee free to add my Acked-by to all the patches that don't already have my R-b. I have done pretty through reviews of previous versions of those patches, but obviously missed a lot of issues pointed out by real MM experts. Thank you Alistair for your reviews, feedback and collaboration! Regards, Felix Am 2022-01-27 um 18:20 schrieb Sierra Guiza, Alejandro (Alex): Andrew, We're somehow new on this procedure. Are you referring to rebase this patch series to git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git <5.17-rc1 tag>? Regards, Alex Sierra Alex Deucher, Just a quick heads up. This patch series contains changes to the amdgpu driver which we're planning to merge through Andrew's tree, If that's ok with you. Regards, Alex Sierra On 1/27/2022 4:32 PM, Andrew Morton wrote: On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra wrote: This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory owned by a device that can be mapped into CPU page tables like MEMORY_DEVICE_GENERIC and can also be migrated like MEMORY_DEVICE_PRIVATE. Some more reviewer input appears to be desirable here. I was going to tentatively add it to -mm and -next, but problems. 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different from the tree you patched. Please redo, refresh and resend?
RE: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
[Public] > -Original Message- > From: Sierra Guiza, Alejandro (Alex) > Sent: Thursday, January 27, 2022 6:21 PM > To: Andrew Morton > Cc: Kuehling, Felix ; linux...@kvack.org; > rcampb...@nvidia.com; linux-e...@vger.kernel.org; linux- > x...@vger.kernel.org; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; h...@lst.de; j...@nvidia.com; > jgli...@redhat.com; apop...@nvidia.com; wi...@infradead.org; Deucher, > Alexander > Subject: Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for > coherent device memory mapping > > Andrew, > We're somehow new on this procedure. Are you referring to rebase this > patch series to git://git.kernel.org/pub/scm/linux/kernel/git/next/linux- > next.git > <5.17-rc1 tag>? > > Regards, > Alex Sierra > > Alex Deucher, > Just a quick heads up. This patch series contains changes to the amdgpu > driver which we're planning to merge through Andrew's tree, If that's ok with > you. No problem. Thanks! Alex > > Regards, > Alex Sierra > > On 1/27/2022 4:32 PM, Andrew Morton wrote: > > On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra > wrote: > > > >> This patch series introduces MEMORY_DEVICE_COHERENT, a type of > memory > >> owned by a device that can be mapped into CPU page tables like > >> MEMORY_DEVICE_GENERIC and can also be migrated like > >> MEMORY_DEVICE_PRIVATE. > > Some more reviewer input appears to be desirable here. > > > > I was going to tentatively add it to -mm and -next, but problems. > > 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different > > from the tree you patched. Please redo, refresh and resend? > >
Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
On Thu, 27 Jan 2022 17:20:40 -0600 "Sierra Guiza, Alejandro (Alex)" wrote: > Andrew, > We're somehow new on this procedure. Are you referring to rebase this > patch series to > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > <5.17-rc1 tag>? No, against current Linus mainline, please.
Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
Andrew, We're somehow new on this procedure. Are you referring to rebase this patch series to git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git <5.17-rc1 tag>? Regards, Alex Sierra Alex Deucher, Just a quick heads up. This patch series contains changes to the amdgpu driver which we're planning to merge through Andrew's tree, If that's ok with you. Regards, Alex Sierra On 1/27/2022 4:32 PM, Andrew Morton wrote: On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra wrote: This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory owned by a device that can be mapped into CPU page tables like MEMORY_DEVICE_GENERIC and can also be migrated like MEMORY_DEVICE_PRIVATE. Some more reviewer input appears to be desirable here. I was going to tentatively add it to -mm and -next, but problems. 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different from the tree you patched. Please redo, refresh and resend?
Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra wrote: > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory > owned by a device that can be mapped into CPU page tables like > MEMORY_DEVICE_GENERIC and can also be migrated like > MEMORY_DEVICE_PRIVATE. Some more reviewer input appears to be desirable here. I was going to tentatively add it to -mm and -next, but problems. 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different from the tree you patched. Please redo, refresh and resend?
