RE: [PATCH] drm/amdgpu: fix "fix 64bit division"

[Quan, Evan]

Reviewed-by: Evan Quan 

>-Original Message-
>From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of
>Christian K?nig
>Sent: Friday, April 07, 2017 4:44 PM
>To: amd-gfx@lists.freedesktop.org
>Subject: [PATCH] drm/amdgpu: fix "fix 64bit division"
>
>From: Christian König 
>
>The offset must be 64bit and add back the accidential dropped line.
>
>Signed-off-by: Christian König 
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>index c91f13b..ba11ff254 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>@@ -551,9 +551,10 @@ static unsigned long amdgpu_ttm_io_mem_pfn(struct
>ttm_buffer_object *bo,
> {
>   struct drm_mm_node *mm = bo->mem.mm_node;
>   uint64_t size = mm->size;
>-  unsigned long offset = page_offset;
>+  uint64_t offset = page_offset;
>
>   page_offset = do_div(offset, size);
>+  mm += offset;
>   return (bo->mem.bus.base >> PAGE_SHIFT) + mm->start +
>page_offset;
> }
>
>--
>2.7.4
>
>___
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: fix "fix 64bit division"

[Zhang, Jerry (Junwei)]

On 04/07/2017 04:44 PM, Christian König wrote:

From: Christian König 

The offset must be 64bit and add back the accidential dropped line.

Signed-off-by: Christian König 

Reviewed-by: Junwei Zhang 


---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index c91f13b..ba11ff254 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -551,9 +551,10 @@ static unsigned long amdgpu_ttm_io_mem_pfn(struct 
ttm_buffer_object *bo,
  {
struct drm_mm_node *mm = bo->mem.mm_node;
uint64_t size = mm->size;
-   unsigned long offset = page_offset;
+   uint64_t offset = page_offset;

page_offset = do_div(offset, size);
+   mm += offset;
return (bo->mem.bus.base >> PAGE_SHIFT) + mm->start + page_offset;
  }



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx