Re: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled (v2)

[Luben Tuikov]

On 2020-08-25 10:34 a.m., Nirmoy wrote:
> 
> On 8/25/20 4:18 PM, Alex Deucher wrote:
>> virtual display is non-atomic so report false to avoid checking
> 
> With below nitpick fixed, Acked-by: Nirmoy Das 

Another nitpick: "below" is not an adjective. It's a preposition or in
this case as an adverb:

"With the nitpick below fixed,"...

Regards,
Luben

> 
> virtual --> Virtual
> 
> 
> Nirmoy
> 
> 
>> atomic state and other atomic things at runtime.
>>
>> v2: squash into the sr-iov check
>>
>> Signed-off-by: Alex Deucher 
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index 5a948edcc93c..8f37f9f99105 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -2861,7 +2861,7 @@ bool amdgpu_device_asic_has_dc_support(enum 
>> amd_asic_type asic_type)
>>*/
>>   bool amdgpu_device_has_dc_support(struct amdgpu_device *adev)
>>   {
>> -if (amdgpu_sriov_vf(adev))
>> +if (amdgpu_sriov_vf(adev) || adev->enable_virtual_display)
>>  return false;
>>   
>>  return amdgpu_device_asic_has_dc_support(adev->asic_type);
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfxdata=02%7C01%7Cluben.tuikov%40amd.com%7Ca80cd8a3f9b34b19d07708d849036b25%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637339626337747219sdata=6xwRnYCESQNachEMmT2jpVjKTsDg4RkwQKpMsOTsSkA%3Dreserved=0
> 

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled (v2)

[Nirmoy]

On 8/25/20 4:18 PM, Alex Deucher wrote:

virtual display is non-atomic so report false to avoid checking


With below nitpick fixed, Acked-by: Nirmoy Das 

virtual --> Virtual


Nirmoy



atomic state and other atomic things at runtime.

v2: squash into the sr-iov check

Signed-off-by: Alex Deucher 
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 5a948edcc93c..8f37f9f99105 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2861,7 +2861,7 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type 
asic_type)
   */
  bool amdgpu_device_has_dc_support(struct amdgpu_device *adev)
  {
-   if (amdgpu_sriov_vf(adev))
+   if (amdgpu_sriov_vf(adev) || adev->enable_virtual_display)
return false;
  
  	return amdgpu_device_asic_has_dc_support(adev->asic_type);

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled (v2)

[Chen, Guchun]

[AMD Public Use]

Acked-by: Guchun Chen 

Regards,
Guchun

-Original Message-
From: amd-gfx  On Behalf Of Alex Deucher
Sent: Tuesday, August 25, 2020 10:18 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander 
Subject: [PATCH] drm/amdgpu: report DC not supported if virtual display is 
enabled (v2)

virtual display is non-atomic so report false to avoid checking atomic state 
and other atomic things at runtime.

v2: squash into the sr-iov check

Signed-off-by: Alex Deucher 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 5a948edcc93c..8f37f9f99105 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2861,7 +2861,7 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type 
asic_type)
  */
 bool amdgpu_device_has_dc_support(struct amdgpu_device *adev)  {
-   if (amdgpu_sriov_vf(adev))
+   if (amdgpu_sriov_vf(adev) || adev->enable_virtual_display)
return false;
 
return amdgpu_device_asic_has_dc_support(adev->asic_type);
--
2.25.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfxdata=02%7C01%7Cguchun.chen%40amd.com%7C5dd32cf703464c63e3ba08d84901b99a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637339619046540701sdata=vnfKXyNtJVE10V6qFwzHQQ7rmVAV9Le6g31nkmaPnLA%3Dreserved=0
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx