RE: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5
[AMD Official Use Only - General] Reviewed-by: Ruijing Dong ruijing.d...@amd.com<mailto:ruijing.d...@amd.com> Thanks, Ruijing From: amd-gfx On Behalf Of Jiang, Sonny Sent: Monday, April 29, 2024 9:49 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5 [AMD Official Use Only - General] [AMD Official Use Only - General] Ping. Sonny From: Jiang, Sonny mailto:sonny.ji...@amd.com>> Sent: Thursday, April 25, 2024 4:12 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Subject: Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5 By tests, I didn't find error on VCN1 to VCN4. Thanks, Sonny From: Jiang, Sonny mailto:sonny.ji...@amd.com>> Sent: Thursday, April 25, 2024 4:10 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Cc: Jiang, Sonny mailto:sonny.ji...@amd.com>>; Jiang, Sonny mailto:sonny.ji...@amd.com>> Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5 From: Sonny Jiang mailto:sonji...@amd.com>> VCN5 session info package interface changed Signed-off-by: Sonny Jiang mailto:sonny.ji...@amd.com>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index 677eb141554e..b89605b400c0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c @@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand ib->ptr[ib->length_dw++] = handle; ib->ptr[ib->length_dw++] = upper_32_bits(addr); ib->ptr[ib->length_dw++] = addr; - ib->ptr[ib->length_dw++] = 0x000b; + ib->ptr[ib->length_dw++] = 0x; ib->ptr[ib->length_dw++] = 0x0014; ib->ptr[ib->length_dw++] = 0x0002; /* task info */ @@ -952,7 +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han ib->ptr[ib->length_dw++] = handle; ib->ptr[ib->length_dw++] = upper_32_bits(addr); ib->ptr[ib->length_dw++] = addr; - ib->ptr[ib->length_dw++] = 0x000b; + ib->ptr[ib->length_dw++] = 0x; ib->ptr[ib->length_dw++] = 0x0014; ib->ptr[ib->length_dw++] = 0x0002; -- 2.43.2
RE: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5
[AMD Official Use Only - General] Reviewed-by: Leo Liu > -Original Message- > From: amd-gfx On Behalf Of Sonny > Jiang > Sent: Thursday, April 25, 2024 4:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Jiang, Sonny ; Jiang, Sonny > > Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5 > > From: Sonny Jiang > > VCN5 session info package interface changed > > Signed-off-by: Sonny Jiang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > index 677eb141554e..b89605b400c0 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > @@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct > amdgpu_ring *ring, uint32_t hand > ib->ptr[ib->length_dw++] = handle; > ib->ptr[ib->length_dw++] = upper_32_bits(addr); > ib->ptr[ib->length_dw++] = addr; > - ib->ptr[ib->length_dw++] = 0x000b; > + ib->ptr[ib->length_dw++] = 0x; > > ib->ptr[ib->length_dw++] = 0x0014; > ib->ptr[ib->length_dw++] = 0x0002; /* task info */ @@ -952,7 > +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring > *ring, uint32_t han > ib->ptr[ib->length_dw++] = handle; > ib->ptr[ib->length_dw++] = upper_32_bits(addr); > ib->ptr[ib->length_dw++] = addr; > - ib->ptr[ib->length_dw++] = 0x000b; > + ib->ptr[ib->length_dw++] = 0x; > > ib->ptr[ib->length_dw++] = 0x0014; > ib->ptr[ib->length_dw++] = 0x0002; > -- > 2.43.2
Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5
[AMD Official Use Only - General] Ping. Sonny From: Jiang, Sonny Sent: Thursday, April 25, 2024 4:12 PM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5 By tests, I didn't find error on VCN1 to VCN4. Thanks, Sonny From: Jiang, Sonny Sent: Thursday, April 25, 2024 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Jiang, Sonny ; Jiang, Sonny Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5 From: Sonny Jiang VCN5 session info package interface changed Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index 677eb141554e..b89605b400c0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c @@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand ib->ptr[ib->length_dw++] = handle; ib->ptr[ib->length_dw++] = upper_32_bits(addr); ib->ptr[ib->length_dw++] = addr; - ib->ptr[ib->length_dw++] = 0x000b; + ib->ptr[ib->length_dw++] = 0x; ib->ptr[ib->length_dw++] = 0x0014; ib->ptr[ib->length_dw++] = 0x0002; /* task info */ @@ -952,7 +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han ib->ptr[ib->length_dw++] = handle; ib->ptr[ib->length_dw++] = upper_32_bits(addr); ib->ptr[ib->length_dw++] = addr; - ib->ptr[ib->length_dw++] = 0x000b; + ib->ptr[ib->length_dw++] = 0x; ib->ptr[ib->length_dw++] = 0x0014; ib->ptr[ib->length_dw++] = 0x0002; -- 2.43.2
Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5
[AMD Official Use Only - General] By tests, I didn't find error on VCN1 to VCN4. Thanks, Sonny From: Jiang, Sonny Sent: Thursday, April 25, 2024 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Jiang, Sonny ; Jiang, Sonny Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5 From: Sonny Jiang VCN5 session info package interface changed Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index 677eb141554e..b89605b400c0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c @@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand ib->ptr[ib->length_dw++] = handle; ib->ptr[ib->length_dw++] = upper_32_bits(addr); ib->ptr[ib->length_dw++] = addr; - ib->ptr[ib->length_dw++] = 0x000b; + ib->ptr[ib->length_dw++] = 0x; ib->ptr[ib->length_dw++] = 0x0014; ib->ptr[ib->length_dw++] = 0x0002; /* task info */ @@ -952,7 +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han ib->ptr[ib->length_dw++] = handle; ib->ptr[ib->length_dw++] = upper_32_bits(addr); ib->ptr[ib->length_dw++] = addr; - ib->ptr[ib->length_dw++] = 0x000b; + ib->ptr[ib->length_dw++] = 0x; ib->ptr[ib->length_dw++] = 0x0014; ib->ptr[ib->length_dw++] = 0x0002; -- 2.43.2
