Re: [ansible-project] What should be the proper way to use include_tasks in ansible 2.5

2018-01-23 Thread Matt Martz
Michael,

It is indeed a changed behavior in 2.4.3rc2, however we are working to
revert that specific behavior, which will be included in an upcoming rc3.



On Tue, Jan 23, 2018 at 4:40 AM, Michael Ströder 
wrote:

> chipcha wrote:
> > Would it be possible to also add best practices of how to migrate
> > include_tasks to import_tasks with loops
> > After https://github.com/ansible/ansible/pull/33595 it seems that all my
> > include_tasks with tags are ignored
>
> I can confirm this issue using ansible-2.4.3.0-0.5.rc2.tar.gz and I
> wonder why such a breaking change is done for minor update within 2.4.x.
>
> Ciao, Michael.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Ansible Project" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ansible-project+unsubscr...@googlegroups.com.
> To post to this group, send email to ansible-project@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/ansible-project/f51d7dc3-cced-d2b3-73ad-30c0b84df274%40stroeder.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Matt Martz
@sivel
sivel.net

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ansible-project+unsubscr...@googlegroups.com.
To post to this group, send email to ansible-project@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/CAD8N0v9-NGzMYNcuzRNCy_y54eNbBN6bimkKh-f9TPtGTHst2Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [ansible-project] What should be the proper way to use include_tasks in ansible 2.5

2018-01-23 Thread Michael Ströder
chipcha wrote:
> Would it be possible to also add best practices of how to migrate
> include_tasks to import_tasks with loops
> After https://github.com/ansible/ansible/pull/33595 it seems that all my
> include_tasks with tags are ignored

I can confirm this issue using ansible-2.4.3.0-0.5.rc2.tar.gz and I
wonder why such a breaking change is done for minor update within 2.4.x.

Ciao, Michael.

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ansible-project+unsubscr...@googlegroups.com.
To post to this group, send email to ansible-project@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/f51d7dc3-cced-d2b3-73ad-30c0b84df274%40stroeder.com.
For more options, visit https://groups.google.com/d/optout.


smime.p7s
Description: S/MIME Cryptographic Signature


Re: [ansible-project] What should be the proper way to use include_tasks in ansible 2.5

2018-01-23 Thread chipcha
Thanks for the quick input Matt :)
Would it be possible to also add best practices of how to migrate 
include_tasks to import_tasks with loops
After https://github.com/ansible/ansible/pull/33595 it seems that all my 
include_tasks with tags are ignored and changing those to import_tasks 
after they already configured  loops seems to be impossible.

Thanks


On Tuesday, January 23, 2018 at 12:37:14 AM UTC+2, Matt Martz wrote:
>
> I've recently started work on this specific topic for the 2.5 porting 
> guide which you can find at https://github.com/ansible/ansible/pull/35199 
> 
>
> On Mon, Jan 22, 2018 at 4:32 PM, chipcha 
> > wrote:
>
>> Hi all,
>>
>> Following the discussion in issue #35065: included include_role fails to 
>> escalate since ebf971f
>> (see also 
>> https://groups.google.com/forum/#%21searchin/ansible-project/chipcha%7Csort:date/ansible-project/2-A3BVF02X4/USl6hixDDQAJ
>> )
>>
>> My issue is related to include_tasks.
>> I understood that for ansible 2.4.3 the behavior of include_tasks will 
>> stay the same while in ansible 2.5 this behavior is about to be changed and 
>> only import_tasks should merge down attributes.
>> To apply my playlist for ansible 2.5 should I change all include_tasks to 
>> import_tasks? If so, should I need to add anything else?
>> Any help will be appreciated
>>
>> Thanks
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Ansible Project" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to ansible-proje...@googlegroups.com .
>> To post to this group, send email to ansible...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/ansible-project/a7e75da6-f4f3-4c64-b6d0-4b6eac6b7894%40googlegroups.com
>>  
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Matt Martz
> @sivel
> sivel.net
>

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ansible-project+unsubscr...@googlegroups.com.
To post to this group, send email to ansible-project@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/b8466fc5-6fe2-4fe3-9e3e-d79d1d031c36%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [ansible-project] What should be the proper way to use include_tasks in ansible 2.5

2018-01-22 Thread Matt Martz
I've recently started work on this specific topic for the 2.5 porting guide
which you can find at https://github.com/ansible/ansible/pull/35199

On Mon, Jan 22, 2018 at 4:32 PM, chipcha  wrote:

> Hi all,
>
> Following the discussion in issue #35065: included include_role fails to
> escalate since ebf971f
> (see also https://groups.google.com/forum/#%21searchin/ansible-
> project/chipcha%7Csort:date/ansible-project/2-A3BVF02X4/USl6hixDDQAJ)
>
> My issue is related to include_tasks.
> I understood that for ansible 2.4.3 the behavior of include_tasks will
> stay the same while in ansible 2.5 this behavior is about to be changed and
> only import_tasks should merge down attributes.
> To apply my playlist for ansible 2.5 should I change all include_tasks to
> import_tasks? If so, should I need to add anything else?
> Any help will be appreciated
>
> Thanks
>
> --
> You received this message because you are subscribed to the Google Groups
> "Ansible Project" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ansible-project+unsubscr...@googlegroups.com.
> To post to this group, send email to ansible-project@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/ansible-project/a7e75da6-f4f3-4c64-b6d0-4b6eac6b7894%40googlegroups.
> com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Matt Martz
@sivel
sivel.net

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ansible-project+unsubscr...@googlegroups.com.
To post to this group, send email to ansible-project@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/CAD8N0v87OqZt8Da_sERSYASmSeNTtjdTWhm%3DJrvDneS0k9X%3DWw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.