Re: mod_jserv/4340: socket connection to jserv should be bound to host address

[Andrew Fullford]

The following reply was made to PR mod_jserv/4340; it has been noted by GNATS.

From: [EMAIL PROTECTED] (Andrew Fullford)
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED], java-apache@list.working-dogs.com
Subject: Re: mod_jserv/4340: socket connection to jserv should be bound to host 
address
Date: Mon, 10 May 1999 21:59:47 -0500 (CDT)

 I'll hack on this -- especially given somebody cares!  I'm not sure why
 this wouldn't work, it's probably something simple.
 
 Andy
 --
 Andrew Fullford   Email: [EMAIL PROTECTED]
 August AssociatesWeb: www.august.net
 
  Date: Mon, 10 May 1999 19:46:13 -0700
  Subject: Re: mod_jserv/4340: socket connection to jserv should be bound to
host address
  From: jon * [EMAIL PROTECTED]
  To: [EMAIL PROTECTED]
  
  ret=bind(sock,(struct sockaddr *)addr,sizeof(struct sockaddr_in));
  
  Hello,
  
  I have tried adding that line and everything stopped working...the diff of
  the code change that I attempted is below. I do see the cannot bind to host
  error in my mod_jserv.log file.
  
  I really am not experienced with networking code in C so I'm not sure what
  is going wrong, I'm just trying to see if I can close this bug report.
  
  Any better ideas?
  
  -jon
  
  Index: jserv_ajpv11.c
  ===
  RCS file: /products/cvs/master/jserv/src/c/jserv_ajpv11.c,v
  retrieving revision 1.24
  diff -r1.24 jserv_ajpv11.c
  101a102,110
   ret=bind(sock,(struct sockaddr *)addr,sizeof(struct sockaddr_in));
   if (ret==-1) {
   jserv_error(JSERV_LOG_EMERG,cfg,ajp11: %s %s:%d,
   can not bind to host,
   inet_ntoa(addr.sin_addr),
   port);
   return -1;
   }
   
  

mod_jserv/4340: socket connection to jserv should be bound to host address

[Andrew Fullford]

Number: 4340
Category:   mod_jserv
Synopsis:   socket connection to jserv should be bound to host address
Confidential:   no
Severity:   non-critical
Priority:   medium
Responsible:jserv
State:  open
Class:  sw-bug
Submitter-Id:   apache
Arrival-Date:   Fri Apr 30 18:30:00 PDT 1999
Last-Modified:
Originator: [EMAIL PROTECTED]
Organization:
apache
Release:Apache 1.3.6, ApacheJServ-1.0b4
Environment:
Linux 2.2, Solaris 2.6, 7
JDK 1.1.6
Description:
when operating on a system with multiple virtual interfaces, it is necessary
to specify a host IP address for the running jserv otherwise all connections
are attempted against 127.0.0.1, which is typically not the correct process,
if it exists at all.  When a connection is started on an unnamed socket, the
O/S will (somewhat randomly) assign the source address for the connection from
the available virtual interfaces.  This makes it difficult to define the list
of acceptable hosts to the security.allowedAddresses property.

I realize it is possible to avoid the collision by running jserv on separate
ports for each http server instance.  However this requires an external port
allocation mechanism.  Such allocation is already well established via the
separate virtual interfaces.
How-To-Repeat:
have a host with multiple virtual interfaces, run two independent apache servers
and try to get them to communicate with their respective jservs.
Fix:
At line 102 in jserv_ajpv11.c, add:

   ret=bind(sock,(struct sockaddr *)addr,sizeof(struct sockaddr_in));

This will set the source address to the target address, which should be
correct for all cases I can think of as the jserv is guaranteed to be running
on the local machine.  I guess you should also test the return value :-)
Audit-Trail:
Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include [EMAIL PROTECTED] in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request ]
[from a developer.  ]
[Reply only with text; DO NOT SEND ATTACHMENTS! ]