cvs commit: apache-site bugdb.cgi

[coar]

coar98/01/03 10:17:42

  Modified:.bugdb.cgi
  Log:
Add a checkbox to the edit form to turn off mail notification.
(Useful when making cosmetic changes or altering closed PRs.)
  
  Revision  ChangesPath
  1.23  +27 -13apache-site/bugdb.cgi
  
  Index: bugdb.cgi
  ===
  RCS file: /export/home/cvs/apache-site/bugdb.cgi,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- bugdb.cgi 1997/12/30 05:34:21 1.22
  +++ bugdb.cgi 1998/01/03 18:17:41 1.23
  @@ -102,6 +102,9 @@
   #  12/30/1997 Ken Coar - Correct a pointer to the bugdb page, and add the
   #actual closure text to the editing display so editors know what will
   #be sent.
  +#  01/03/1998 Ken Coar - Add a checkbox to the edit form to prevent
  +#email from being sent.  This allows cosmetic changes to be made,
  +#even to closed PRs, without spamming people.
   #
   ### End Modification log
   
  @@ -239,7 +242,7 @@
   ### Main menu
   } elsif ($PATH_INFO eq "") {
   &main_menu();
  -print "Version: 30 December 1997Authors: ",
  +print "Version: 3 January 1998Authors: ",
"http://alumni.caltech.edu/~dank/gnats.html\";>Dan Kegel ",
"and Huy Le,  ",
"with revamp work by ",
  @@ -428,7 +431,7 @@
   
   # Send the PR
   $prtext = &unparse_pr("send");
  -open(MAIL, "|$MAILER") || die "Error while invoking sendmail";
  +open(MAIL, "|$MAILER") || die "Error while invoking $MAILER";
   print MAIL <\n";
  -local($mail_to);
  +local($mail_to, $mailed) = ("", 0);
   $mail_to = join(", ", sort(keys(%mail_to)));
  -if ($mail_to ne "") {
  +if (($mail_to ne "") && (!$input{"NoNotify"})) {
if (open(MAILER, "|$MAILER")) {
$msg = 
   "To: $mail_to
  @@ -892,19 +895,21 @@
   ";
print MAILER $msg;
close(MAILER);
  -
  - # Display message
  - $msg =~ s/\/\>\;/g;
  - print 
  -"Your changes to PR $pr were filed to the database.
  -The parties concerned were notified via e-mail as follows:
  -$msg
  -";
  + $mailed = 1;
} else {
print "Error: can't run $MAILER\n";
}
   }
  +# Display message
  +$msg =~ s/\/\>\;/g;
  +print "Your changes to PR $pr were filed to the database.";
  +if ($mailed) {
  +print <$msg
  +EOHT
  +}
   }
   
   # Gives the interface to change the PR
  @@ -951,6 +956,15 @@
   # Maximize box dimensions
   local($width)= 60;
   local($height)= 4;
  +
  +print <
  + 
  + 
  + DO NOT send mail about this change
  + 
  +
  +EOHT
   
   print "
   Editor (you):
  
  
  

cvs commit: apachen/src/main alloc.c

[dgaudet]

dgaudet 98/01/02 16:23:59

  Modified:src/main alloc.c
  Log:
  style guide changes.
  
  Revision  ChangesPath
  1.66  +10 -4 apachen/src/main/alloc.c
  
  Index: alloc.c
  ===
  RCS file: /export/home/cvs/apachen/src/main/alloc.c,v
  retrieving revision 1.65
  retrieving revision 1.66
  diff -u -r1.65 -r1.66
  --- alloc.c   1997/12/30 19:56:11 1.65
  +++ alloc.c   1998/01/03 00:23:59 1.66
  @@ -731,7 +731,7 @@
   table_entry *elts = (table_entry *) t->elts;
   int done = 0;
   
  -for (i = 0; i < t->nelts; )
  +for (i = 0; i < t->nelts; ) {
if (!strcasecmp(elts[i].key, key)) {
if (!done) {
elts[i].val = pstrdup(t->pool, val);
  @@ -746,7 +746,10 @@
--t->nelts;
}
}
  - else ++i;
  + else {
  + ++i;
  + }
  +}
   
   if (!done) {
elts = (table_entry *) push_array(t);
  @@ -760,7 +763,7 @@
   register int i, j, k;
   table_entry *elts = (table_entry *) t->elts;
   
  -for (i = 0; i < t->nelts; )
  +for (i = 0; i < t->nelts; ) {
if (!strcasecmp(elts[i].key, key)) {
   
/* found an element to skip over
  @@ -774,7 +777,10 @@
}
--t->nelts;
}
  - else ++i;
  + else {
  + ++i;
  + }
  +}
   }
   
   API_EXPORT(void) table_merge(table *t, const char *key, const char *val)
  
  
  

cvs commit: apachen/src/main http_log.c

[dgaudet]

dgaudet 98/01/02 16:18:40

  Modified:src  CHANGES
   src/main http_log.c
  Log:
  Fix buffer overrun in log_printf().
  
  Reviewed by:  Randy Terbush
  
  Revision  ChangesPath
  1.557 +4 -0  apachen/src/CHANGES
  
  Index: CHANGES
  ===
  RCS file: /export/home/cvs/apachen/src/CHANGES,v
  retrieving revision 1.556
  retrieving revision 1.557
  diff -u -r1.556 -r1.557
  --- CHANGES   1998/01/02 23:58:26 1.556
  +++ CHANGES   1998/01/03 00:18:31 1.557
  @@ -1,5 +1,9 @@
   Changes with Apache 1.3b4
   
  +  *) The aplog_error changes specific to 1.3 introduced a buffer
  + overrun in the (now legacy) log_printf function.  Fixed.
  + [Dean Gaudet]
  +
 *) mod_digest didn't properly deal with proxy authentication.  It
also lacked a case-insensitive comparision of the "Digest"
token.  [Ronald Tschalaer <[EMAIL PROTECTED]>] PR#1599
  
  
  
  1.45  +1 -1  apachen/src/main/http_log.c
  
  Index: http_log.c
  ===
  RCS file: /export/home/cvs/apachen/src/main/http_log.c,v
  retrieving revision 1.44
  retrieving revision 1.45
  diff -u -r1.44 -r1.45
  --- http_log.c1997/12/07 15:47:59 1.44
  +++ http_log.c1998/01/03 00:18:38 1.45
  @@ -413,7 +413,7 @@
   va_list args;
   
   va_start(args, fmt);
  -vsprintf(buf, fmt, args);
  +ap_vsnprintf(buf, sizeof(buf), fmt, args);
   aplog_error(APLOG_MARK, APLOG_ERR, s, buf);
   va_end(args);
   }
  
  
  

cvs commit: apachen/src/modules/standard mod_alias.c mod_auth_anon.c mod_cern_meta.c mod_digest.c mod_log_agent.c mod_log_referer.c mod_usertrack.c

[dgaudet]

dgaudet 98/01/02 16:16:39

  Modified:src/modules/standard mod_alias.c mod_auth_anon.c
mod_cern_meta.c mod_digest.c mod_log_agent.c
mod_log_referer.c mod_usertrack.c
  Log:
  Somehow I missed a whole boatload of modules when adding static.  I'm not
  sure how that was.  There's a few other changes in here, nothing that affects
  functionality, they're essentially documentation fixes.
  
  Revision  ChangesPath
  1.28  +3 -3  apachen/src/modules/standard/mod_alias.c
  
  Index: mod_alias.c
  ===
  RCS file: /export/home/cvs/apachen/src/modules/standard/mod_alias.c,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- mod_alias.c   1997/12/14 20:48:55 1.27
  +++ mod_alias.c   1998/01/03 00:16:35 1.28
  @@ -246,10 +246,10 @@
   {NULL}
   };
   
  -static int alias_matches(char *uri, char *alias_fakename)
  +static int alias_matches(const char *uri, const char *alias_fakename)
   {
  -char *end_fakename = alias_fakename + strlen(alias_fakename);
  -char *aliasp = alias_fakename, *urip = uri;
  +const char *end_fakename = alias_fakename + strlen(alias_fakename);
  +const char *aliasp = alias_fakename, *urip = uri;
   
   while (aliasp < end_fakename) {
if (*aliasp == '/') {
  
  
  
  1.28  +10 -10apachen/src/modules/standard/mod_auth_anon.c
  
  Index: mod_auth_anon.c
  ===
  RCS file: /export/home/cvs/apachen/src/modules/standard/mod_auth_anon.c,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -r1.27 -r1.28
  --- mod_auth_anon.c   1997/10/22 20:30:15 1.27
  +++ mod_auth_anon.c   1998/01/03 00:16:35 1.28
  @@ -112,7 +112,7 @@
   
   } anon_auth_config_rec;
   
  -void *create_anon_auth_dir_config(pool *p, char *d)
  +static void *create_anon_auth_dir_config(pool *p, char *d)
   {
   anon_auth_config_rec *sec = (anon_auth_config_rec *)
   pcalloc(p, sizeof(anon_auth_config_rec));
  @@ -131,39 +131,39 @@
   return sec;
   }
   
  -const char *anon_set_passwd_flag(cmd_parms *cmd,
  +static const char *anon_set_passwd_flag(cmd_parms *cmd,
 anon_auth_config_rec * sec, int arg)
   {
   sec->auth_anon_mustemail = arg;
   return NULL;
   }
   
  -const char *anon_set_userid_flag(cmd_parms *cmd,
  +static const char *anon_set_userid_flag(cmd_parms *cmd,
 anon_auth_config_rec * sec, int arg)
   {
   sec->auth_anon_nouserid = arg;
   return NULL;
   }
  -const char *anon_set_logemail_flag(cmd_parms *cmd,
  +static const char *anon_set_logemail_flag(cmd_parms *cmd,
   anon_auth_config_rec * sec, int arg)
   {
   sec->auth_anon_logemail = arg;
   return NULL;
   }
  -const char *anon_set_verifyemail_flag(cmd_parms *cmd,
  +static const char *anon_set_verifyemail_flag(cmd_parms *cmd,
  anon_auth_config_rec * sec, int arg)
   {
   sec->auth_anon_verifyemail = arg;
   return NULL;
   }
  -const char *anon_set_authoritative_flag(cmd_parms *cmd,
  +static const char *anon_set_authoritative_flag(cmd_parms *cmd,
anon_auth_config_rec * sec, int arg)
   {
   sec->auth_anon_authoritative = arg;
   return NULL;
   }
   
  -const char *anon_set_string_slots(cmd_parms *cmd,
  +static const char *anon_set_string_slots(cmd_parms *cmd,
  anon_auth_config_rec * sec, char *arg)
   {
   
  @@ -187,7 +187,7 @@
   return NULL;
   }
   
  -command_rec anon_auth_cmds[] =
  +static command_rec anon_auth_cmds[] =
   {
   {"Anonymous", anon_set_string_slots, NULL, OR_AUTHCFG, ITERATE,
"a space-separated list of user IDs"},
  @@ -207,7 +207,7 @@
   
   module MODULE_VAR_EXPORT anon_auth_module;
   
  -int anon_authenticate_basic_user(request_rec *r)
  +static int anon_authenticate_basic_user(request_rec *r)
   {
   anon_auth_config_rec *sec =
   (anon_auth_config_rec *) get_module_config(r->per_dir_config,
  @@ -267,7 +267,7 @@
   return DECLINED;
   }
   
  -int check_anon_access(request_rec *r)
  +static int check_anon_access(request_rec *r)
   {
   #ifdef NOTYET
   conn_rec *c = r->connection;
  
  
  
  1.23  +8 -8  apachen/src/modules/standard/mod_cern_meta.c
  
  Index: mod_cern_meta.c
  ===
  RCS file: /export/home/cvs/apachen/src/modules/standard/mod_cern_meta.c,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- mod_cern_meta.c   1997/10/22 20:30:17 1.22
  +++ mod_cern_meta.c   1998/01/03 00:16:36 1.23
  @@ -166,7 +166,7 @@
   char *metafiles;
   } cern_meta_dir_config;
   
  -void *create_cern_meta_dir_config(pool *p, char *dummy)
  +stat