Re: cvs commit: apache-1.3/src/modules/standard mod_rewrite.c

[Ralf S. Engelschall]

In article <[EMAIL PROTECTED]> you wrote:

> Beachtet dieser Patch die ExecCGI option? Oder kann man die damit
> unterlaufen?

No, ExecCGI is still needed. And BTW, this is not a new feature, the [T=xxx]
option exists for years.  And it always was used this way. All I changed this
time was to remove the inconsistency with the "-" pseudo-substitution URL
(which means no subst). Nothing else. In the past one has to rewrite the URL
to whatever and the whatever back to the URL to achieve this effect because
"-" didn't honor the MIME-type stuff. So, no new features or new bugs, just
one inconsistency less.
   Ralf S. Engelschall
   [EMAIL PROTECTED]
   www.engelschall.com

Re: cvs commit: apache-1.3/src/modules/standard mod_rewrite.c

[Marc Slemko]

On 3 Jun 1998 [EMAIL PROTECTED] wrote:

> rse 98/06/03 05:12:12
> 
>   Modified:src  CHANGES
>src/modules/standard mod_rewrite.c
>   Log:
>   Fix recently introduced Win32 child spawning code in mod_rewrite.c which was
>   broken because of invalid ap_pstrcat() -> strcat() transformation.  I'm a
>   little bit confused: Seems like no one has actually compiled Apache with all
>   modules under Win32 just before Jim rolled the 1.3.0 tarball. Because else
>   someone had received a compile error. Hmmm... I knew why I hates to put code
>   into mod_rewrite I couldn't test myself... :-(

Why is it using sprintf?

No.  Code.  Should.  Use.  sprintf.  Almost.

We have an ap_snprintf.  Use it.  I don't care if it isn't necessary or
you think it isn't necessary or it may not be necessary or you hope it
isn't necessary.  Always unless you shouldn't. And I see no reason why you
shouldn't here. 


>   +++ mod_rewrite.c   1998/06/03 12:12:11 1.114
>   @@ -3190,11 +3190,11 @@
>#if defined(WIN32)
>/* MS Windows */
>{
>   -char *pCommand;
>   +char pCommand[MAX_STRING_LEN];
>STARTUPINFO si;
>PROCESS_INFORMATION pi;
>
>   -pCommand = strcat(SHELL_PATH, " /C ", cmd, NULL);
>   +sprintf(pCommand, "%s /C %s", SHELL_PATH, cmd);
>
>memset(&si, 0, sizeof(si));
>memset(&pi, 0, sizeof(pi));
>   
>   
>   
>