Re: [Apertium-stuff] Regression Testing Now Operational

[Daniel Swanson]

On Tue, Jul 27, 2021 at 8:47 AM Flammie A Pirinen  wrote:
>
> Am Fri, Jul 23, 2021 at 08:14:01PM -0500 schrieb Daniel Swanson:
>
> > At the beginning of last week, 47 languages and pairs had a meaningful
> > 'make test', and several of those were failing. As of today, 365 repos
> > have 'make test' and virtually all are passing.
>
> That's exciting, here's some first test run minor suggestions:
>
> * make test after git pull failed with "apertium-regtest: command not
>   found", which is ok for devs but could be improved with having regtest
>   stuff test in AM_CONDITIONALS possibly with informative message

I shall investigate how to do that.

> * apertium-regtest has no ./autogen.sh, people have gotten used to that
>   so even just having autoreconf -fvi in it is a good idea

Will change that in a moment.

>
> Running teh actual tests in apertium-fin-nor I get:
>
> make test
> Making all in docs
> make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor/docs“ 
> wird betreten
> make[1]: Für das Ziel „all“ ist nichts zu tun.
> make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor/docs“ 
> wird verlassen
> make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor“ wird 
> betreten
> apertium-validate-modes modes.xml
> apertium-gen-modes modes.xml
> make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor“ wird 
> verlassen
> apertium-regtest test
> Corpus 1 of 4: fin-nob
> Traceback (most recent call last):
>   File "/usr/local/bin/apertium-regtest", line 1041, in 
> if not static_test(args.ignore_add):
>   File "/usr/local/bin/apertium-regtest", line 950, in static_test
> corp.load()
>   File "/usr/local/bin/apertium-regtest", line 378, in load
> outdata = load_output(self.out_name(c))
>   File "/usr/local/bin/apertium-regtest", line 79, in load_output
> l = int(l[1:])
> TypeError: 'int' object is not subscriptable
> make: *** [Makefile:1132: test] Fehler 1
>
> perhaps this is different version of pyhthon or libraries? I have
> python 3.9.1 on linux.

That's a typo for which I pushed a fix ~5 minutes ago.

>
> --
> Regards, Flammie 
> (Please note, that I will often include my replies inline instead of
> top or bottom of the mail)
> ___
> Apertium-stuff mailing list
> Apertium-stuff@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/apertium-stuff


___
Apertium-stuff mailing list
Apertium-stuff@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/apertium-stuff

Re: [Apertium-stuff] Regression Testing Now Operational

[Flammie A Pirinen]

Am Fri, Jul 23, 2021 at 08:14:01PM -0500 schrieb Daniel Swanson:

> At the beginning of last week, 47 languages and pairs had a meaningful
> 'make test', and several of those were failing. As of today, 365 repos
> have 'make test' and virtually all are passing.

That's exciting, here's some first test run minor suggestions:

* make test after git pull failed with "apertium-regtest: command not
  found", which is ok for devs but could be improved with having regtest
  stuff test in AM_CONDITIONALS possibly with informative message
* apertium-regtest has no ./autogen.sh, people have gotten used to that
  so even just having autoreconf -fvi in it is a good idea

Running teh actual tests in apertium-fin-nor I get:

make test
Making all in docs
make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor/docs“ wird 
betreten
make[1]: Für das Ziel „all“ ist nichts zu tun.
make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor/docs“ wird 
verlassen
make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor“ wird 
betreten
apertium-validate-modes modes.xml
apertium-gen-modes modes.xml
make[1]: Verzeichnis „/home/flammie/github/apertium/apertium-fin-nor“ wird 
verlassen
apertium-regtest test
Corpus 1 of 4: fin-nob
Traceback (most recent call last):
  File "/usr/local/bin/apertium-regtest", line 1041, in 
if not static_test(args.ignore_add):
  File "/usr/local/bin/apertium-regtest", line 950, in static_test
corp.load()
  File "/usr/local/bin/apertium-regtest", line 378, in load
outdata = load_output(self.out_name(c))
  File "/usr/local/bin/apertium-regtest", line 79, in load_output
l = int(l[1:])
TypeError: 'int' object is not subscriptable
make: *** [Makefile:1132: test] Fehler 1

perhaps this is different version of pyhthon or libraries? I have 
python 3.9.1 on linux.

-- 
Regards, Flammie 
(Please note, that I will often include my replies inline instead of
top or bottom of the mail)


signature.asc
Description: PGP signature
___
Apertium-stuff mailing list
Apertium-stuff@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/apertium-stuff