Re: [apparmor] [PATCH v2 3/8] autofs: set ctime as well when mtime changes on a dir

2023-06-13 Thread Ian Kent

On 12/6/23 18:45, Jeff Layton wrote:

When adding entries to a directory, POSIX generally requires that the
ctime also be updated alongside the mtime.

Signed-off-by: Jeff Layton 


Acked-by: Ian Kent 



---
  fs/autofs/root.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/autofs/root.c b/fs/autofs/root.c
index 6baf90b08e0e..93046c9dc461 100644
--- a/fs/autofs/root.c
+++ b/fs/autofs/root.c
@@ -600,7 +600,7 @@ static int autofs_dir_symlink(struct mnt_idmap *idmap,
p_ino = autofs_dentry_ino(dentry->d_parent);
p_ino->count++;
  
-	dir->i_mtime = current_time(dir);

+   dir->i_mtime = dir->i_ctime = current_time(dir);
  
  	return 0;

  }
@@ -633,7 +633,7 @@ static int autofs_dir_unlink(struct inode *dir, struct 
dentry *dentry)
d_inode(dentry)->i_size = 0;
clear_nlink(d_inode(dentry));
  
-	dir->i_mtime = current_time(dir);

+   dir->i_mtime = dir->i_ctime = current_time(dir);
  
  	spin_lock(>lookup_lock);

__autofs_add_expiring(dentry);
@@ -749,7 +749,7 @@ static int autofs_dir_mkdir(struct mnt_idmap *idmap,
p_ino = autofs_dentry_ino(dentry->d_parent);
p_ino->count++;
inc_nlink(dir);
-   dir->i_mtime = current_time(dir);
+   dir->i_mtime = dir->i_ctime = current_time(dir);
  
  	return 0;

  }




[apparmor] [PATCH v2 3/8] autofs: set ctime as well when mtime changes on a dir

2023-06-13 Thread Jeff Layton
When adding entries to a directory, POSIX generally requires that the
ctime also be updated alongside the mtime.

Signed-off-by: Jeff Layton 
---
 fs/autofs/root.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/autofs/root.c b/fs/autofs/root.c
index 6baf90b08e0e..93046c9dc461 100644
--- a/fs/autofs/root.c
+++ b/fs/autofs/root.c
@@ -600,7 +600,7 @@ static int autofs_dir_symlink(struct mnt_idmap *idmap,
p_ino = autofs_dentry_ino(dentry->d_parent);
p_ino->count++;
 
-   dir->i_mtime = current_time(dir);
+   dir->i_mtime = dir->i_ctime = current_time(dir);
 
return 0;
 }
@@ -633,7 +633,7 @@ static int autofs_dir_unlink(struct inode *dir, struct 
dentry *dentry)
d_inode(dentry)->i_size = 0;
clear_nlink(d_inode(dentry));
 
-   dir->i_mtime = current_time(dir);
+   dir->i_mtime = dir->i_ctime = current_time(dir);
 
spin_lock(>lookup_lock);
__autofs_add_expiring(dentry);
@@ -749,7 +749,7 @@ static int autofs_dir_mkdir(struct mnt_idmap *idmap,
p_ino = autofs_dentry_ino(dentry->d_parent);
p_ino->count++;
inc_nlink(dir);
-   dir->i_mtime = current_time(dir);
+   dir->i_mtime = dir->i_ctime = current_time(dir);
 
return 0;
 }
-- 
2.40.1