Re: [apparmor] [patch] techdoc.pdf improvements

2012-05-08 Thread John Johansen
On 05/08/2012 03:56 PM, Christian Boltz wrote:
> Hello,
> 
> Am Dienstag, 8. Mai 2012 schrieb Kees Cook:
>> On Tue, May 08, 2012 at 09:59:11PM +0200, Christian Boltz wrote:
>>> - don't include build date on first page of the PDF
>>
>> Oh good -- this had been bothering me.
> 
> I was thinking about inserting the correct date, but that would have 
> looked too bad. bzr log tells me something about April 2007, but at this 
> time the file was moved to the apparmor-parser package. The last "real" 
> edit might be even older...
> 
> It would be nice to have techdoc.tex updated, but that's another 
> story ;-)
> 
Well I don't know about a .tex but I have been working on several white
papers and expect that we will make effort to update the techdoc off of
it.




-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor


Re: [apparmor] [patch] techdoc.pdf improvements

2012-05-08 Thread Christian Boltz
Hello,

Am Dienstag, 8. Mai 2012 schrieb Kees Cook:
> On Tue, May 08, 2012 at 09:59:11PM +0200, Christian Boltz wrote:
> > - don't include build date on first page of the PDF
> 
> Oh good -- this had been bothering me.

I was thinking about inserting the correct date, but that would have 
looked too bad. bzr log tells me something about April 2007, but at this 
time the file was moved to the apparmor-parser package. The last "real" 
edit might be even older...

It would be nice to have techdoc.tex updated, but that's another 
story ;-)

> > - make clean:
> >   - delete techdoc.out (created by pdftex)
> >   - fix deletion of techdoc.txt (was techdo_r_.txt)
> 
> Hah, whoops.

Indeed.

> > (but he didn't notice the techdo_r_.txt ;-)
> 
> Looks like our pdflatex outputs differ. On Debian/Ubuntu, there's no
> techdoc.txt generated:

It's not included in the default target. You have to explicitely run
make techdoc.txt

This will also generate the PDF and HTML version because it depends on 
them.

Your response also leads to another question: should we change the 
Makefile so that techdoc.* is build when just calling "make"?

Basically this would mean for parser/Makefile: (pseudo-patch)
-all:
+all: techdoc.txt

Otherwise we have to change README because it says

For more information, you can read the techdoc.pdf (available after 


building the parser) and by visiting the http://apparmor.net/ web
site.

;-)


Regards,

Christian Boltz
-- 
>> Man möge mich korrigieren. 
> Du hast es nicht anders gewollt ;-)
J, gibs mir! ;-)
[> Christian Boltz und Johannes Kastl in suse-linux]


-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor


Re: [apparmor] [patch] techdoc.pdf improvements

2012-05-08 Thread Kees Cook
Hi Christian,

On Tue, May 08, 2012 at 09:59:11PM +0200, Christian Boltz wrote:
> - make table of contents, footnotes etc. clickable hyperlinks

Nice!

> - use timestamp of techdoc.tex (instead of build time) as creationdate
>   in the PDF metadata
> - don't include build date on first page of the PDF

Oh good -- this had been bothering me.

> - make clean:
>   - delete techdoc.out (created by pdftex)
>   - fix deletion of techdoc.txt (was techdo_r_.txt)

Hah, whoops.

> The initial target was to get reproduceable PDF builds (therefore the 
> timestamp-related changes), the other things came up during discussing
> this patch with David Haller.
> 
> The only remaining difference in the PDF from build to build is the /ID
> line.  This line can't be controlled in pdflatex and is now filtered 
> out by build-compare in the openSUSE build service (bnc#760867).
> 
> Credits go to David Haller for writing large parts of this patch
> (but he didn't notice the techdo_r_.txt ;-)

Looks like our pdflatex outputs differ. On Debian/Ubuntu, there's no
techdoc.txt generated:

-rw-rw-r--  1 kees kees   3542 May  8 14:41 techdoc.aux
-rw-rw-r--  1 kees kees   2200 May  8 14:41 techdoc.toc
-rw-rw-r--  1 kees kees 246153 May  8 14:41 techdoc.pdf
-rw-rw-r--  1 kees kees  14265 May  8 14:41 techdoc.log


> Signed-Off-By: Christian Boltz 

Acked-by: Kees Cook 

-- 
Kees Cook

-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor


[apparmor] [patch] techdoc.pdf improvements

2012-05-08 Thread Christian Boltz
Hello,

the attached patch contains various changes in building techdoc.tex:
- make table of contents, footnotes etc. clickable hyperlinks
- use timestamp of techdoc.tex (instead of build time) as creationdate
  in the PDF metadata
- don't include build date on first page of the PDF
- make clean:
  - delete techdoc.out (created by pdftex)
  - fix deletion of techdoc.txt (was techdo_r_.txt)

The initial target was to get reproduceable PDF builds (therefore the 
timestamp-related changes), the other things came up during discussing
this patch with David Haller.

The only remaining difference in the PDF from build to build is the /ID
line.  This line can't be controlled in pdflatex and is now filtered 
out by build-compare in the openSUSE build service (bnc#760867).

Credits go to David Haller for writing large parts of this patch
(but he didn't notice the techdo_r_.txt ;-)


Signed-Off-By: Christian Boltz 




And now let me explain why bzr blame is named bzr _blame_ ;-))

# bzr blame parser/Makefile |grep techdor
1522 kees.co | 60   rm -rf techdoc.aux techdoc.log techdoc.pdf 
techdoc.toc techdor.txt techdoc/
# bzr log -r1522

revno: 1522
committer: Kees Cook 
branch nick: master
timestamp: Wed 2010-11-03 17:04:43 -0700
message:
  This patch cleans up the testsuite output harder, and removes a 
  bashism in another clean target.


Kees, looks like removing bashisms is a bad idea *g,d&r*

(and I wonder nobody noticed the not-deleted techdoc.txt in "bzr st" 
output since november 2010...)


Regards,

Christian Boltz

PS: Non-random sig ;-)
-- 
[PDF] Fipptehler korrigiert -- wie konnten wir das bisher uebersehen ;)
- Schüsselworte: 
+ Schlüsselworte: 
[David Haller in suse-linux-faq]
Various changes in building techdoc.tex:
- make table of contents, footnotes etc. clickable hyperlinks
- use timestamp of techdoc.tex (instead of build time) as creationdate
  in the PDF metadata
- don't include build date on first page of the PDF
- make clean:
  - delete techdoc.out (created by pdftex)
  - fix deletion of techdoc.txt (was techdo_r_.txt)

The initial target was to get reproduceable PDF builds (therefore the 
timestamp-related changes), the other things came up during discussing
this patch with David Haller.

The only remaining difference in the PDF from build to build is the /ID
line.  This line can't be controlled in pdflatex and is now filtered 
out by build-compare in the openSUSE build service (bnc#760867).

Credits go to David Haller for writing large parts of this patch
(but he didn't notice the techdo_r_.txt ;-)


Signed-Off-By: Christian Boltz 



=== modified file 'parser/Makefile'
--- parser/Makefile	2012-03-22 20:19:27 +
+++ parser/Makefile	2012-05-08 18:40:10 +
@@ -118,7 +118,8 @@
 	$(MAKE) -C po ${NAME}.pot NAME=${NAME} SOURCES="${SRCS} ${HDRS}"
 
 techdoc.pdf: techdoc.tex
-	while pdflatex $< ${BUILD_OUTPUT} || exit 1 ; \
+	timestamp=$(shell date "+%Y%m%d%H%M%S+02'00'" -r $< );\
+	while pdflatex "\def\fixedpdfdate{$$timestamp}\input $<" ${BUILD_OUTPUT} || exit 1 ; \
 		grep -q "Label(s) may have changed" techdoc.log; \
 	do :; done
 
@@ -302,7 +303,7 @@
 	rm -f $(NAME)*.tar.gz $(NAME)*.tgz
 	rm -f af_names.h
 	rm -f cap_names.h
-	rm -rf techdoc.aux techdoc.log techdoc.pdf techdoc.toc techdor.txt techdoc/
+	rm -rf techdoc.aux techdoc.out techdoc.log techdoc.pdf techdoc.toc techdoc.txt techdoc/
 	$(MAKE) -s -C $(AAREDIR) clean
 	$(MAKE) -s -C po clean
 	$(MAKE) -s -C tst clean

=== modified file 'parser/techdoc.tex'
--- parser/techdoc.tex	2011-02-09 22:29:05 +
+++ parser/techdoc.tex	2012-05-08 18:55:56 +
@@ -5,6 +5,17 @@
 \usepackage{url}
 %\usepackage{times}
 
+\usepackage[pdftex,
+  pdfauthor={Andreas Gruenbacher and Seth Arnold},
+  pdftitle={AppArmor Technical Documentation},%
+\ifx\fixedpdfdate\@empty\else
+  pdfcreationdate={\fixedpdfdate},
+  pdfmoddate={\fixedpdfdate},
+\fi
+  pdfsubject={AppArmor},
+  pdfkeywords={AppArmor}
+]{hyperref}
+
 \hyphenation{App-Armor}
 \hyphenation{name-space}
 
@@ -14,7 +25,8 @@
 \author{Andreas Gruenbacher and Seth Arnold \\
 \url{{agruen,seth.arnold}@suse.de} \\
 SUSE Labs / Novell}
-%\date{}
+% don't include the (build!) date
+\date{}
 
 \begin{document}
 

-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor