[PATCH] add our version to string to httpd banner

[Philip M. Gollucci]

Before:
Server: Apache/2.0.54 (Unix) DAV/2 mod_perl/2.0.2-dev Perl/5.8.7

After:
Server: Apache/2.0.54 (Unix) DAV/2 mod_apreq/2.1.2-dev 
mod_perl/2.0.2-dev Perl/5.8.7



[EMAIL PROTECTED] /usr/local/dev/repos/ASF/httpd/apreq/trunk svn diff 
Index: module/apache/command.c

===
--- module/apache/command.c (revision 210049)
+++ module/apache/command.c (working copy)
@@ -18,6 +18,7 @@

 #include apreq_util.h
 #include apreq_module_apache.h
+#include apreq_version.h

 #include httpd.h
 #include http_log.h
@@ -152,6 +153,7 @@
 apr_initialize();
 apr_pool_create(p, NULL);
 apreq_initialize(p);
+ap_add_version_component(p, apr_psprintf(p, mod_apreq/%s, 
APREQ_VERSION_STRING));

 ap_register_cleanup(sp, p, apreq_cleanup, apreq_cleanup);
 }

Index: module/apache2/filter.c
===
--- module/apache2/filter.c (revision 210049)
+++ module/apache2/filter.c (working copy)
@@ -29,6 +29,7 @@
 #include apreq_private_apache2.h
 #include apreq_error.h
 #include apreq_util.h
+#include apreq_version.h

 static void *apreq_create_dir_config(apr_pool_t *p, char *d)
 {
@@ -423,6 +424,8 @@
 {
 apr_status_t status;

+ap_add_version_component(p, apr_psprintf(p, mod_apreq/%s, 
APREQ_VERSION_STRING));

+
 status = apreq_post_initialize(p);
 if (status != APR_SUCCESS) {
 ap_log_error(APLOG_MARK, APLOG_STARTUP|APLOG_ERR, status, 
base_server,


--
END

What doesn't kill us can only make us stronger.
Nothing is impossible.

Philip M. Gollucci ([EMAIL PROTECTED]) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
  http://www.liquidityservicesinc.com
   http://www.liquidation.com
   http://www.uksurplus.com
   http://www.govliquidation.com
   http://www.gowholesale.com

Re: APR::Request::Param::Table

[Joe Schaefer]

Adam Prime [EMAIL PROTECTED] writes:

 Here's how i would have done what i'm trying to do in mp1.  The docs
 say this interface is broken, but they aren't explaining to me very
 clearly what i'm supposed to do to get this sort of functionality in
 mp2

You can't do it anymore with apreq's 2.x API.
This functionality was dropped with 2.05-dev,
but the docs weren't updated properly to reflect 
the change.  Sorry about that.


-- 
Joe Schaefer

Re: [PATCH[ library/t/Makefile.am

[Joe Schaefer]

Philip M. Gollucci [EMAIL PROTECTED] writes:

 P.S.

 whats needed for the TODO for dropping automake and using apr/httpd
 conf things. 


Hard work- lots of it, I'd suppose.  It's prolly a lot easier
for httpd to just extract our C files and incorporate those
directly into their build system.

-- 
Joe Schaefer