Re: [PATCH] Some windows build enhancements

2008-04-24 Thread Philip M. Gollucci

Mladen Turk wrote:

ACK.
There was one small typo and it seems I have the karma for commits,
so I've fixed it directly.

I suppose the fix has to go to the 2.10 branch as well.

I haven't seen the svn commit mail on apreq-cvs yet ?

Yes, please fix it on branches/v2.10 as well.


--

Philip M. Gollucci ([EMAIL PROTECTED])
c:703.336.9354
Consultant / http://p6m7g8.net/Resume/resume.txt
http://riderway.com / http://ridecharge.com
1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB  B89E 1324 9B4F EC88 A0BF

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.



Re: [PATCH] Some windows build enhancements

2008-04-24 Thread Mladen Turk

Philip M. Gollucci wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Mladen Turk wrote:
| Hi,
|
| libapreq is missing .rc file, so here is a standard ASF one.
| Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC
| in the same way as APR declares so that dllexport/dllimport
| get correctly handled.
Hi Mladen,

Thanks for your work on this.  In the future, please submit patches
piece wise.

Committed to trunk: 651366, 651374, 651381, 651385, 651388

backported to v2_10 branch: 651399.



ACK.
There was one small typo and it seems I have the karma for commits,
so I've fixed it directly.

I suppose the fix has to go to the 2.10 branch as well.


Regards
--
(TM)


Re: [PATCH] Some windows build enhancements

2008-04-24 Thread Philip M. Gollucci

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Mladen Turk wrote:
| Hi,
|
| libapreq is missing .rc file, so here is a standard ASF one.
| Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC
| in the same way as APR declares so that dllexport/dllimport
| get correctly handled.
Hi Mladen,

Thanks for your work on this.  In the future, please submit patches
piece wise.

Committed to trunk: 651366, 651374, 651381, 651385, 651388

backported to v2_10 branch: 651399.



- --
- 
Philip M. Gollucci ([EMAIL PROTECTED])
o:703.549.2050x206
Senior System Admin - Riderway, Inc.
http://riderway.com / http://ridecharge.com
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.

-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.8 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIEO3fdbiP+9ubjBwRAnNVAJ0SQj0/AH0uKv2i2uqs7pjoWyE5zACdE2sl
Q5zb1EHDh1GuAetL/YNkg2k=
=0wpi
-END PGP SIGNATURE-


[PATCH] Some windows build enhancements

2008-04-24 Thread Mladen Turk

Hi,

libapreq is missing .rc file, so here is a standard ASF one.
Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC
in the same way as APR declares so that dllexport/dllimport
get correctly handled.



Regards
--
(TM)
#include "apreq_version.h"

#define APREQ_COPYRIGHT "Copyright 2000-2008 The Apache Software " \
  "Foundation or its licensors, as applicable."

#define APREQ_LICENSE "Licensed under the Apache License, Version 2.0 " \
"(the ""License""); you may not use this file except " \
"in compliance with the License.  You may obtain a " \
"copy of the License at\r\n\r\n" \
"http://www.apache.org/licenses/LICENSE-2.0\r\n\r\n"; \
"Unless required by applicable law or agreed to in " \
"writing, software distributed under the License is " \
"distributed on an ""AS IS"" BASIS, WITHOUT " \
"WARRANTIES OR CONDITIONS OF ANY KIND, either " \
"express or implied.  See the License for the " \
"specific language governing permissions and " \
"limitations under the License."

#define APREQ_DLL_BASENAME "libapreq-" APR_STRINGIFY(APREQ_MAJOR_VERSION)
#define APREQ_VERSION_STRING_CSV APREQ_MAJOR_VERSION ##, \
 ##APREQ_MINOR_VERSION ##, \
 ##APREQ_PATCH_VERSION


1 VERSIONINFO
 FILEVERSION APREQ_VERSION_STRING_CSV,0
 PRODUCTVERSION APREQ_VERSION_STRING_CSV,0
 FILEFLAGSMASK 0x3fL
#if defined(APREQ_IS_DEV_VERSION)
#if defined(_DEBUG)
 FILEFLAGS 0x03L
#else
 FILEFLAGS 0x02L
#endif
#else
#if defined(_DEBUG)
 FILEFLAGS 0x01L
#else
 FILEFLAGS 0x00L
#endif
#endif
#if defined(WINNT) || defined(WIN64)
 FILEOS 0x40004L
#else
 FILEOS 0x4L
#endif
 FILETYPE 0x2L
 FILESUBTYPE 0x0L
BEGIN
  BLOCK "StringFileInfo"
  BEGIN
BLOCK "040904b0"
BEGIN
VALUE "Comments", APREQ_LICENSE "\0"
  VALUE "CompanyName", "Apache Software Foundation\0"
  VALUE "FileDescription", "Apache HTTP Server Request Library\0"
  VALUE "FileVersion", APREQ_VERSION_STRING "\0"
  VALUE "InternalName", APREQ_DLL_BASENAME "\0"
  VALUE "LegalCopyright", APREQ_COPYRIGHT "\0"
  VALUE "OriginalFilename", APREQ_DLL_BASENAME ".dll\0"
  VALUE "ProductName", "Apache HTTP Server Project\0"
  VALUE "ProductVersion", APREQ_VERSION_STRING "\0"
END
  END
  BLOCK "VarFileInfo"
  BEGIN
VALUE "Translation", 0x409, 1200
  END
END
Index: include/apreq.h
===
--- include/apreq.h (revision 651220)
+++ include/apreq.h (working copy)
@@ -69,10 +69,18 @@
  * APREQ_DECLARE_DATA type apr_variable = value;
  */
 #define APREQ_DECLARE_DATA
-#else
+#elif defined (APREQ_DECLARE_STATIC)
+#define APREQ_DECLARE(type) type __stdcall
+#define APREQ_DECLARE_NONSTD(type)  type
+#define APREQ_DECLARE_DATA
+#elif defined (APREQ_DECLARE_EXPORT)
 #define APREQ_DECLARE(type) __declspec(dllexport) type __stdcall
 #define APREQ_DECLARE_NONSTD(type)  __declspec(dllexport) type
 #define APREQ_DECLARE_DATA  __declspec(dllexport)
+#else
+#define APREQ_DECLARE(type) __declspec(dllimport) type __stdcall
+#define APREQ_DECLARE_NONSTD(type)  __declspec(dllimport) type
+#define APREQ_DECLARE_DATA  __declspec(dllimport)
 #endif
 
 /**
Index: win32/apreq2_test.mak
===
--- win32/apreq2_test.mak   (revision 651220)
+++ win32/apreq2_test.mak   (working copy)
@@ -127,7 +127,7 @@
 "$(OUTDIR)" :
 if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"
 
-CPP_PROJ=/nologo /MDd /W3 /Gm /GX /ZI /Od /D "WIN32" /D "_DEBUG" /D "_MBCS" /D 
"_LIB"/YX /I"$(APACHE)\include" /I"$(APREQ_HOME)\include" /FD /GZ  /c 
+CPP_PROJ=/nologo /MDd /W3 /Gm /GX /ZI /Od /D "WIN32" /D "_DEBUG" /D "_MBCS" /D 
"_LIB" /YX /I"$(APACHE)\include" /I"$(APREQ_HOME)\include" /FD /GZ  /c 
 BSC32=bscmake.exe
 BSC32_FLAGS=/nologo /o"$(LIBDIR)\apreq2_test.bsc" 
 LIB32=link.exe -lib
Index: win32/libapreq2.mak
===
--- win32/libapreq2.mak (revision 651220)
+++ win32/libapreq2.mak (working copy)
@@ -68,6 +68,7 @@
 "$(INTDIR)\module_custom.obj" \
 "$(INTDIR)\module_cgi.obj" \
 "$(INTDIR)\error.obj" \
+"$(INTDIR)\libprocrun.res" \
"$(APR_LIB)" \
"$(APU_LIB)"
 
@@ -78,8 +79,10 @@
 "$(OUTDIR)" :
 if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"
 
-CPP_PROJ=/nologo /MD /W3 /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_MBCS" 
/D "_USRDLL" /I"$(APACHE)\include" /I"$(APREQ_HOME)\include" /YX /FD /c 
+CPP_PROJ=/nologo /MD /W3 /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_MBCS" 
/D "_USRDLL" /D "APREQ_DECLARE_EXPORT" /I"$(APACHE)\include" 
/I"$(APREQ_HOME)\include" /YX /FD /c 
 MTL_PROJ=/nologo /D "NDEBUG" /