Re: [PATCH[ library/t/Makefile.am
"Philip M. Gollucci" <[EMAIL PROTECTED]> writes: > P.S. > > whats needed for the TODO for dropping automake and using apr/httpd > conf things. Hard work- lots of it, I'd suppose. It's prolly a lot easier for httpd to just extract our C files and incorporate those directly into their build system. -- Joe Schaefer
Re: [PATCH[ library/t/Makefile.am
Philip M. Gollucci wrote:
I've reached a conundrum here:
With the above fix, ./buildconf actually finishes because automake
doesn't error out with the above error, but
gmake test
fails in library/t
because the linker flags aren't passed in library/t/Makefile.am
I finally figured this out:
This is due to an inconsistency in automake15's version string
running
automake15 --version
automake (GNU automake15) 1.5
VS
automak19
automake (GNU automake) 1.9.5
Note the extra 15. 15 is > 1.6 so the buildconf let me use an
unsupported version of automake.
Here is a patch to solve this:
[also note the s/Apache::Request/Apache2::Request/]
[EMAIL PROTECTED] /usr/local/dev/repos/ASF/httpd/apreq/trunk> svn diff
build/version_check.pl
Index: build/version_check.pl
===
--- build/version_check.pl (revision 210049)
+++ build/version_check.pl (working copy)
@@ -7,8 +7,25 @@
$path = $tool unless defined $path;
sub exe_version { scalar qx/$path -v/ }
-sub gnu_version { scalar qx/$path --version/ }
+sub gnu_version {
+ my $ver = scalar qx/$path --version/;
+ if ($path =~ /automake/) {
+ if ($ver =~ /15/) {
+ ## automake15 --version displays
+ ## automake (GNU automake15) 1.5
+ ## causing us to use 15 as the version and not 1.5
+ return 1.5;
+ }
+ else {
+ return $ver;
+ }
+}
+ else {
+ return $ver;
+ }
+}
+
sub xsb_version {
eval {
require ExtUtils::XSBuilder;
@@ -197,7 +214,7 @@
"Build system (core C API) prerequisites\n", \%build;
print "\n", "=" x 50, "\n";
print_prereqs
-"Perl glue (Apache::Request) prerequisites\n", \%perl_glue;
+"Perl glue (Apache2::Request) prerequisites\n", \%perl_glue;
print "\n", "=" x 50, "\n";
print_prereqs
"Additional prerequisites for apreq subversion builds\n",
\%svn;
--
END
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci ([EMAIL PROTECTED]) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Re: [PATCH[ library/t/Makefile.am
Philip M. Gollucci wrote: Fix automake SVN build error: library/t/Makefile.am:2: invalid unused variable name: `AM_LDFLAGS' [EMAIL PROTECTED] /usr/local/dev/repos/ASF/httpd/apreq/trunk> svn diff Index: library/t/Makefile.am === --- library/t/Makefile.am (revision 209929) +++ library/t/Makefile.am (working copy) @@ -1,5 +1,4 @@ AM_CPPFLAGS = @APR_INCLUDES@ -AM_LDFLAGS = [EMAIL PROTECTED]@ --link-libtool --libs` @APR_LTFLAGS@ noinst_LIBRARIES = libapache_test.a libapache_test_a_SOURCES = at.h at.c I've reached a conundrum here: With the above fix, ./buildconf actually finishes because automake doesn't error out with the above error, but gmake test fails in library/t because the linker flags aren't passed in library/t/Makefile.am I tried using LDFLAGS instead, but then I had to much with the LD_LIBRARY_PATH env variable. I then tried setting AML_LDFLAGS and assigning it to LDFLAGS and it still complained with the first error about it being unused. So at the moment to build/test from SVN I have to re-run automake manually after editing library/t/Makefile.am *sigh* P.S. whats needed for the TODO for dropping automake and using apr/httpd conf things. -- END What doesn't kill us can only make us stronger. Nothing is impossible. Philip M. Gollucci ([EMAIL PROTECTED]) 301.254.5198 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Developer / Liquidity Services, Inc. http://www.liquidityservicesinc.com http://www.liquidation.com http://www.uksurplus.com http://www.govliquidation.com http://www.gowholesale.com
[PATCH[ library/t/Makefile.am
Fix automake SVN build error: library/t/Makefile.am:2: invalid unused variable name: `AM_LDFLAGS' [EMAIL PROTECTED] /usr/local/dev/repos/ASF/httpd/apreq/trunk> svn diff Index: library/t/Makefile.am === --- library/t/Makefile.am (revision 209929) +++ library/t/Makefile.am (working copy) @@ -1,5 +1,4 @@ AM_CPPFLAGS = @APR_INCLUDES@ -AM_LDFLAGS = [EMAIL PROTECTED]@ --link-libtool --libs` @APR_LTFLAGS@ noinst_LIBRARIES = libapache_test.a libapache_test_a_SOURCES = at.h at.c -- END What doesn't kill us can only make us stronger. Nothing is impossible. Philip M. Gollucci ([EMAIL PROTECTED]) 301.254.5198 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Developer / Liquidity Services, Inc. http://www.liquidityservicesinc.com
