Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Randy Kobes wrote: I believe that error is the same error that arises in many of the apr-ext tests in mod_perl (with Apache/2.2); with httpd-2.2.2, it arises on about line 798 of apr_pools.c of srclib/apr/memory/unix/, in the apr_pool_create_ex() function - the line if (allocator == NULL) allocator = parent->allocator; has "parent" apparently NULL. If anyone has tested mod_perl and/or libapreq under Apache/2.2 with unix, can you let us know if you encounter problems either with mod_perl's apr-ext tests or withj libapreq's glue/perl/t/apreq/cgi.t tests? Thanks. Yes, mod_perl 2.0.2 fails 3-5 tests on FreeBSD (at least) with httpd 2.2.x. You should use mod_perl trunk for now if you are comming against this series of httpd. I'll be drifting over to mp_land for some catch up work after we get 2.08 out the door. -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
On Mon, 22 May 2006, Steve Hay wrote: [ ... ] I have one test script failing, though. When I ran "nmake test" from the top-level directory every test in glue\perl\t\apreq\cgi.t failed with a generic Windows popup error message saying "perl.exe has encountered a problem and needs to close...": Failed Test Stat Wstat Total Fail Failed List of Failed---t\apreq\cgi.t 41 41 100.00% 1-41Failed 1/10 test scripts, 90.00% okay. 41/191 subtests failed, 78.53% okay. When I cd into glue\perl and run "nmake test" from there I get different popups instead complaining about missing DLL's. If I add their locations to my PATH then I get the same "perl.exe has encountered..." messages as before. I believe that error is the same error that arises in many of the apr-ext tests in mod_perl (with Apache/2.2); with httpd-2.2.2, it arises on about line 798 of apr_pools.c of srclib/apr/memory/unix/, in the apr_pool_create_ex() function - the line if (allocator == NULL) allocator = parent->allocator; has "parent" apparently NULL. If anyone has tested mod_perl and/or libapreq under Apache/2.2 with unix, can you let us know if you encounter problems either with mod_perl's apr-ext tests or withj libapreq's glue/perl/t/apreq/cgi.t tests? Thanks. -- best regards, Randy
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
eval()ing it is a good idea, and then die()ing if it's not available - I've committed a fix for this. nice. I'm wresting with one more build cleanup for module/Makefile.am These actually moved into t/c-modules from c-modules. They currently fail during (g)make clean and t/c-modules/'s (g)make clean is never run. If I fix the 2 targets below though, I break (g)make test. I'm guess something is running the targets before the tests start and its deleting a generated file, but I haven't tracked that down yet. At any rate, I'll likely roll an -RC2 later tonight (PST). Thanks everyone. test_clean : cmodules_clean -MAKE=$(MAKE) @PERL@ t/TEST -clean -rm -rf t/htdocs t/logs t/modules t/TEST t/core t/core.* t/cgi-bin/test_cgi t/cgi-bin/.libs t/.libs t/conf/extra.conf t/conf/ssl/ca t/conf/ssl/httpd-passphrase.pl cmodules_clean: -cd c-modules && $(MAKE) clean -rm c-modules/Makefile c-modules/*/Makefile c-modules/apache_httpd_test.h -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
On Mon, 22 May 2006, Philip M. Gollucci wrote: Steve Hay wrote: Philip M. Gollucci wrote: - When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an error from win32/Configure.pl about Archive-Tar being missing, but this is not mentioned in the PREREQUISITES file and was not checked by test_prereq in Makefile.PL before calling this script. Committed revision 408136 This doesn't seem to do anything for me. When I run Makefile.PL without Archive-Tar present it just fails as before: Actually, it wasn't supposed to.. That commit just causes it to be listed in the PREREQUISITES file. Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib C:/perl5mt/site/lib .) at win32/Configure.pl line 11. BEGIN failed--compilation aborted at win32/Configure.pl line 11. system C:\perl5mt\bin\perl.exe win32/Configure.pl --with-apache2-apxs="C:\apache2\bin\apxs.bat" --with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2" --enable-perl-glue failed: 512 at Makefile.PL line 88. Do we want to eval the this in Configure.pl ? I'll leave this one to Randy if he is still reading :) eval()ing it is a good idea, and then die()ing if it's not available - I've committed a fix for this. -- best regards, Randy
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Steve Hay wrote: Philip M. Gollucci wrote: - When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an error from win32/Configure.pl about Archive-Tar being missing, but this is not mentioned in the PREREQUISITES file and was not checked by test_prereq in Makefile.PL before calling this script. Committed revision 408136 This doesn't seem to do anything for me. When I run Makefile.PL without Archive-Tar present it just fails as before: Actually, it wasn't supposed to.. That commit just causes it to be listed in the PREREQUISITES file. Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib C:/perl5mt/site/lib .) at win32/Configure.pl line 11. BEGIN failed--compilation aborted at win32/Configure.pl line 11. system C:\perl5mt\bin\perl.exe win32/Configure.pl --with-apache2-apxs="C:\apache2\bin\apxs.bat" --with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2" --enable-perl-glue failed: 512 at Makefile.PL line 88. Do we want to eval the this in Configure.pl ? I'll leave this one to Randy if he is still reading :) -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Randy Kobes wrote: On Fri, 19 May 2006, Steve Hay wrote: Philip M. Gollucci wrote:> Please download, test, and report back on the following> candidate tarball:> > http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz WinXP/VC++ 6.0, Apache-2.2.2, Perl-5.8.8: - When I run "nmake", the build process falls over at library/error.c with the error: NMAKE : fatal error U1073: don't know how to make '"C:\apache2\lib\libapr.lib"'Stop.NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\VC98\Bin\NMAKE.EXE"' : return code '0x2' I assume this is the same problem that mod_perl-2.0 was having until Randy came to the rescue recently: the library in question is now called libapr-1.lib. The latter problem should now be fixed in the svn sources - thanks. Thanks, that's fixed the build error. I have one test script failing, though. When I ran "nmake test" from the top-level directory every test in glue\perl\t\apreq\cgi.t failed with a generic Windows popup error message saying "perl.exe has encountered a problem and needs to close...": Failed Test Stat Wstat Total Fail Failed List of Failed --- t\apreq\cgi.t 41 41 100.00% 1-41 Failed 1/10 test scripts, 90.00% okay. 41/191 subtests failed, 78.53% okay. When I cd into glue\perl and run "nmake test" from there I get different popups instead complaining about missing DLL's. If I add their locations to my PATH then I get the same "perl.exe has encountered..." messages as before. Radan Computational Ltd. The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Philip M. Gollucci wrote:
- When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an
error from win32/Configure.pl about Archive-Tar being missing, but
this is not mentioned in the PREREQUISITES file and was not checked by
test_prereq in Makefile.PL before calling this script.
Committed revision 408136
This doesn't seem to do anything for me. When I run Makefile.PL without
Archive-Tar present it just fails as before:
Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib
C:/perl5mt/site/lib .) at win32/Configure.pl line 11.
BEGIN failed--compilation aborted at win32/Configure.pl line 11.
system C:\perl5mt\bin\perl.exe win32/Configure.pl
--with-apache2-apxs="C:\apache2\bin\apxs.bat"
--with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2"
--enable-perl-glue failed: 512 at Makefile.PL line 88.
Something like the attached patch at least gets the check done before
win32/Configure.pl is run, but even then it still carries on after the
failed check and crashes just the same:
Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib
C:/perl5mt/site/lib .) at build/version_check.pl line 42.
Please upgrade Archive::Tar first.
C:\perl5mt\bin\perl.exe win32/Configure.pl
--with-apache2-apxs="C:\apache2\bin\apxs.bat"
--with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2"
--enable-perl-glue
Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib
C:/perl5mt/site/lib .) at win32/Configure.pl line 11.
BEGIN failed--compilation aborted at win32/Configure.pl line 11.
system C:\perl5mt\bin\perl.exe win32/Configure.pl
--with-apache2-apxs="C:\apache2\bin\apxs.bat"
--with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2"
--enable-perl-glue failed: 512 at Makefile.PL line 92.
Shouldn't test_prereq stop Makefile.PL on failure rather than just warning?
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are
confidential and intended for the addressee(s) only. If you have received this
message in error or there are any problems, please notify the sender
immediately. The unauthorized use, disclosure, copying or alteration of this
message is strictly forbidden. Note that any views or opinions presented in
this email are solely those of the author and do not necessarily represent
those of Radan Computational Ltd. The recipient(s) of this message should check
it and any attached files for viruses: Radan Computational will accept no
liability for any damage caused by any virus transmitted by this email.
--- Makefile.PL.orig2006-05-22 09:09:18.0 +0100
+++ Makefile.PL 2006-05-22 09:17:21.645269900 +0100
@@ -41,6 +41,10 @@
test_prereq "Test::More";
}
+if (WIN32) {
+test_prereq "Archive::Tar";
+}
+
$opts .= "--debug " if (WIN32 and $args{debug});
delete @[EMAIL PROTECTED];
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
On Fri, 19 May 2006, Steve Hay wrote: Philip M. Gollucci wrote:> Please download, test, and report back on the following> candidate tarball:> > http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz WinXP/VC++ 6.0, Apache-2.2.2, Perl-5.8.8: - When I extracted the tarball, I found two extra directories (docs and man) besides libapreq2-2.08. I trust these won't be in the release version. - When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an error from win32/Configure.pl about Archive-Tar being missing, but this is not mentioned in the PREREQUISITES file and was not checked by test_prereq in Makefile.PL before calling this script. - When I run "nmake", the build process falls over at library/error.c with the error: NMAKE : fatal error U1073: don't know how to make '"C:\apache2\lib\libapr.lib"'Stop.NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\VC98\Bin\NMAKE.EXE"' : return code '0x2' I assume this is the same problem that mod_perl-2.0 was having until Randy came to the rescue recently: the library in question is now called libapr-1.lib. The latter problem should now be fixed in the svn sources - thanks. -- best regards, Randy
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
- When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an error from win32/Configure.pl about Archive-Tar being missing, but this is not mentioned in the PREREQUISITES file and was not checked by test_prereq in Makefile.PL before calling this script. Committed revision 408136 -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Patch for spec file is attached for your reference. Actually, unlike mod_perl, we currently do not distribute a .spec file for an rpm. I wonder if we should start ? -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
- When I extracted the tarball, I found two extra directories (docs and man) besides libapreq2-2.08. I trust these won't be in the release version. Actually, these are in the current release(2.07) too. Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
I should have mentioned.. that odd thing where it doesn't test on OSX is on this release I thought someone had submitted a patch for that a few months ago
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Bojan Smojver wrote: On Fri, 2006-05-19 at 15:42 +1000, Bojan Smojver wrote: I'll try the same in Fedora Extras development tree as well. Packages should be available from Rawhide upon the next sign/release cycle. Obviously, an RC2 is comming. Thanks for the feedback thus far. Keep it comming. -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
On Fri, 2006-05-19 at 15:42 +1000, Bojan Smojver wrote: > I'll try the same in > Fedora Extras development tree as well. Packages should be available from Rawhide upon the next sign/release cycle. -- Bojan
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Philip M. Gollucci wrote: Please download, test, and report back on the following candidate tarball: http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz WinXP/VC++ 6.0, Apache-2.2.2, Perl-5.8.8: - When I extracted the tarball, I found two extra directories (docs and man) besides libapreq2-2.08. I trust these won't be in the release version. - When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an error from win32/Configure.pl about Archive-Tar being missing, but this is not mentioned in the PREREQUISITES file and was not checked by test_prereq in Makefile.PL before calling this script. - When I run "nmake", the build process falls over at library/error.c with the error: NMAKE : fatal error U1073: don't know how to make '"C:\apache2\lib\libapr.lib"' Stop. NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\VC98\Bin\NMAKE.EXE"' : return code '0x2' I assume this is the same problem that mod_perl-2.0 was having until Randy came to the rescue recently: the library in question is now called libapr-1.lib. Radan Computational Ltd. The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Quoting "Philip M. Gollucci" <[EMAIL PROTECTED]>:
Please download, test, and report back on the following
candidate tarball:
Builds as RPM on Fedora Core 5 on my x86_64 box. I'll try the same in
Fedora Extras development tree as well. The spec file required some
changes in order to build. I'm hoping Perl folks using Rawhide will be
able to verify if all is still cool, once the package becomes available.
Patch for spec file is attached for your reference.
--
Bojan
--- libapreq2.spec.orig 2006-05-19 15:29:17.0 +1000
+++ libapreq2.spec 2006-05-19 15:37:15.0 +1000
@@ -1,15 +1,15 @@
%{!?apxs: %{expand:%%define apxs %{_sbindir}/apxs}}
Name: libapreq2
-Version:2.07
-Release:1.1%{?dist}
+Version:2.08
+Release:0.rc1.1%{?dist}
Summary:Apache HTTP request library
Group: System Environment/Libraries
License:Apache Software License
URL:http://httpd.apache.org/apreq/
#Source0:http://www.cpan.org/authors/id/J/JO/JOESUF/%{name}-%{version}.tar.gz
-Source0:http://people.apache.org/~joes/libapreq2-2.07.tar.gz
+Source0:http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz
Source1:%{name}-httpd.conf
Patch0: %{name}-build.patch
Patch1: %{name}-2.07-rc3-ldflags.patch
@@ -62,7 +62,6 @@
#!/bin/sh
%{__perl_provides} $* \
| grep -v 'perl(APR::\(Request\(::\(Apache2\|CGI\|Error\)\)\?\))$' \
-| grep -v 'perl(Apache2::\(Cookie\|Request\|Upload\))$'
EOF
%define __perl_provides %{_builddir}/%{name}-%{version}/%{name}-perl-prov
chmod +x %{__perl_provides}
@@ -147,7 +146,6 @@
%defattr(-,root,root,-)
%doc glue/perl/README
%{perl_vendorarch}/auto/APR/
-%{perl_vendorarch}/Apache2/
%{perl_vendorarch}/APR/
%{_mandir}/man3/A*::*.3*
[Fwd: Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1]
Forwarding back to the list. -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..." --- Begin Message --- On May 18, 2006, at 5:05 AM, Philip M. Gollucci wrote: Please download, test, and report back on the following candidate tarball: http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz Seems to work on osx 10.4.6 But you probably knew that already I tried on freebsd 6.0 REL but couldn't get it to work. i got a "/usr/bin/ld: cannot find -lldap" but that's probably either because I tend to only build off my ports tree, or because I had some weird issues with ldconfig a few months ago and everything got corrupted. Sorry i'm not of more help. //Jonathan Vanasco |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | RoadSound.com / Indie-Rock.net | Collaborative Online Management And Syndication Tools |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - --- End Message ---
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
Randy Kobes wrote: On Thu, 18 May 2006, Philip M. Gollucci wrote: Please download, test, and report back on the following candidate tarball: http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz Does this compile with Apache/2.2 on unix? I've been working on 2.2 support for Win32, but will need a few days, and am just wondering if I should rush it. Thanks. I don't know yet. When I run my test matrix later tonight I'll let you know. I know it works with 2.0.58, perl 5.8.8, mod_perl 2.0.2 on FreeBSD. I would assume it does ? Thats okay, it won't get released till sometime next week. -- Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1
On Thu, 18 May 2006, Philip M. Gollucci wrote: Please download, test, and report back on the following candidate tarball: http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz Does this compile with Apache/2.2 on unix? I've been working on 2.2 support for Win32, but will need a few days, and am just wondering if I should rush it. Thanks. -- best regards, Randy
[RELEASE CANDIDATE] libapreq2 2.08-RC1
Please download, test, and report back on the following candidate tarball: http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC1.tar.gz Most notably, it compiles with perl 5.8.8 now. CHANGES SINCE 2.07 - Perl Glue docs [Philip M. Gollucci] Fix the 'docs_install' make target to actually install the docs for the perl glue. - Perl Glue Build [Philip M. Gollucci] Regenerate glue/perl/xsbuilder/ppport.h to fix perl 5.8.8+ on some plaforms. - C API [joes] Add code for apreq_cookies(). - Perl API [joes] Expose the constants in apreq_error.h via the APR::Request::Error package. Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..."
