Re: code sign-off/DCO for ovirt projects
On 04/10/2012 04:13 PM, Ryan Harper wrote: * Itamar Heim [2012-04-10 03:57]: top posting to make sure this is visible: touched based with danken and enabled this for vdsm project. if there are any issues/more time needed for adjustment, will disable and re-enable. http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html#Signed-off-by Excellent! When would we enable this for the remaining ovirt-* projects? (engine, cli, sdk, etc.)? i suggest asking on weekly call per project as it needs to sync (vdsm/ovirt-node with mostly a single maintainer easier to sync than engine) On 04/08/2012 11:11 AM, Dan Kenigsberg wrote: On Sat, Apr 07, 2012 at 01:00:27AM +0300, Itamar Heim wrote: On 04/06/2012 06:00 PM, Ryan Harper wrote: Re-sending this to arch as in our meeting this week we agreed[1] no reason to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but that we needed to enlist the maintainers to work out enforcement. that's easy enough since we use gerrit. if acked by all, i can simply enable 'force sign-off' on patches option in gerrit and it will be enforced... 1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html I do not mind requring the make-my-lawyer-happy line in all Vdsm commits, and I suppose that this would be fine by everybody on vdsm-devel. Tell us when this takes effect, we'll prepare our commit-msg hooks by then. Anything cooler we can do beyond putting SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') grep -qs "^$SOB" "$1" || echo "$SOB">> "$1" at the bottom of .git/hooks/commit-msg ? - Forwarded message from Ryan Harper- From: Ryan Harper Subject: code sign-off/DCO for ovirt projects Date: Tue, 3 Apr 2012 14:59:40 -0500 Message-ID:<20120403195940.gb5...@us.ibm.com> User-Agent: Mutt/1.5.6+20040907i To: bo...@ovirt.org I see that this was discussed in the past on the board list[1] and there didn't seem to be any disagreement with doing DCO sign-off for code contributions. However, not all of the ovirt projects are doing DCO/Sign-off. There are a few commits in vdms.git that have a SoB, ovirt-node seems to be using DCO completely. Nothing in ovirt-engine either. I didn't check all of the ovirt subprojects, but I think it's safe to assume that's not being applied across all of the projects consistently. Can we get that added to the commit process for these projects moving forward? Is there anything else needed beyond maintainers enforcing the need for SoB in patches? 1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
* Itamar Heim [2012-04-10 03:57]: > top posting to make sure this is visible: > touched based with danken and enabled this for vdsm project. > if there are any issues/more time needed for adjustment, will disable > and re-enable. > > http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html#Signed-off-by Excellent! When would we enable this for the remaining ovirt-* projects? (engine, cli, sdk, etc.)? > > > On 04/08/2012 11:11 AM, Dan Kenigsberg wrote: > >On Sat, Apr 07, 2012 at 01:00:27AM +0300, Itamar Heim wrote: > >>On 04/06/2012 06:00 PM, Ryan Harper wrote: > >>>Re-sending this to arch as in our meeting this week we agreed[1] no > >>>reason > >>>to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but > >>>that we needed to enlist the maintainers to work out enforcement. > >> > >>that's easy enough since we use gerrit. > >>if acked by all, i can simply enable 'force sign-off' on patches > >>option in gerrit and it will be enforced... > >> > >>> > >>> > >>>1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html > > > > > >I do not mind requring the make-my-lawyer-happy line in all Vdsm commits, > >and I suppose that this would be fine by everybody on vdsm-devel. Tell > >us when this takes effect, we'll prepare our commit-msg hooks by then. > > > >Anything cooler we can do beyond putting > > > >SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: > >\1/p') > >grep -qs "^$SOB" "$1" || echo "$SOB">> "$1" > > > >at the bottom of .git/hooks/commit-msg ? > > > >>> > >>>- Forwarded message from Ryan Harper - > >>> > >>>From: Ryan Harper > >>>Subject: code sign-off/DCO for ovirt projects > >>>Date: Tue, 3 Apr 2012 14:59:40 -0500 > >>>Message-ID:<20120403195940.gb5...@us.ibm.com> > >>>User-Agent: Mutt/1.5.6+20040907i > >>>To: bo...@ovirt.org > >>> > >>>I see that this was discussed in the past on the board list[1] and there > >>>didn't seem to be any disagreement with doing DCO sign-off for code > >>>contributions. However, not all of the ovirt projects are doing > >>>DCO/Sign-off. There are a few commits in vdms.git that have a SoB, > >>>ovirt-node seems to be using DCO completely. Nothing in ovirt-engine > >>>either. I didn't check all of the ovirt subprojects, but I think > >>>it's safe to assume that's not being applied across all of the > >>>projects consistently. > >>> > >>>Can we get that added to the commit process for these projects moving > >>>forward? Is there anything else needed beyond maintainers enforcing the > >>>need for SoB in patches? > >>> > >>> > >>>1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html > >>> > >> > >>___ > >>Arch mailing list > >>Arch@ovirt.org > >>http://lists.ovirt.org/mailman/listinfo/arch -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
On 04/10/2012 02:58 PM, Mike Burns wrote: On Tue, 2012-04-10 at 11:57 +0300, Itamar Heim wrote: top posting to make sure this is visible: touched based with danken and enabled this for vdsm project. if there are any issues/more time needed for adjustment, will disable and re-enable. http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html#Signed-off-by You can enable for the ovirt-node project as well. enabled for ovirt-node and ovirt-node-iso projects as well. ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
On Tue, 2012-04-10 at 11:57 +0300, Itamar Heim wrote: > top posting to make sure this is visible: > touched based with danken and enabled this for vdsm project. > if there are any issues/more time needed for adjustment, will disable > and re-enable. > > http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html#Signed-off-by > You can enable for the ovirt-node project as well. Thanks Mike > > On 04/08/2012 11:11 AM, Dan Kenigsberg wrote: > > On Sat, Apr 07, 2012 at 01:00:27AM +0300, Itamar Heim wrote: > >> On 04/06/2012 06:00 PM, Ryan Harper wrote: > >>> Re-sending this to arch as in our meeting this week we agreed[1] no reason > >>> to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but > >>> that we needed to enlist the maintainers to work out enforcement. > >> > >> that's easy enough since we use gerrit. > >> if acked by all, i can simply enable 'force sign-off' on patches > >> option in gerrit and it will be enforced... > >> > >>> > >>> > >>> 1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html > > > > > > I do not mind requring the make-my-lawyer-happy line in all Vdsm commits, > > and I suppose that this would be fine by everybody on vdsm-devel. Tell > > us when this takes effect, we'll prepare our commit-msg hooks by then. > > > > Anything cooler we can do beyond putting > > > > SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') > > grep -qs "^$SOB" "$1" || echo "$SOB">> "$1" > > > > at the bottom of .git/hooks/commit-msg ? > > > >>> > >>> - Forwarded message from Ryan Harper - > >>> > >>> From: Ryan Harper > >>> Subject: code sign-off/DCO for ovirt projects > >>> Date: Tue, 3 Apr 2012 14:59:40 -0500 > >>> Message-ID:<20120403195940.gb5...@us.ibm.com> > >>> User-Agent: Mutt/1.5.6+20040907i > >>> To: bo...@ovirt.org > >>> > >>> I see that this was discussed in the past on the board list[1] and there > >>> didn't seem to be any disagreement with doing DCO sign-off for code > >>> contributions. However, not all of the ovirt projects are doing > >>> DCO/Sign-off. There are a few commits in vdms.git that have a SoB, > >>> ovirt-node seems to be using DCO completely. Nothing in ovirt-engine > >>> either. I didn't check all of the ovirt subprojects, but I think > >>> it's safe to assume that's not being applied across all of the > >>> projects consistently. > >>> > >>> Can we get that added to the commit process for these projects moving > >>> forward? Is there anything else needed beyond maintainers enforcing the > >>> need for SoB in patches? > >>> > >>> > >>> 1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html > >>> > >> > >> ___ > >> Arch mailing list > >> Arch@ovirt.org > >> http://lists.ovirt.org/mailman/listinfo/arch > > ___ > Arch mailing list > Arch@ovirt.org > http://lists.ovirt.org/mailman/listinfo/arch ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
top posting to make sure this is visible: touched based with danken and enabled this for vdsm project. if there are any issues/more time needed for adjustment, will disable and re-enable. http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html#Signed-off-by On 04/08/2012 11:11 AM, Dan Kenigsberg wrote: On Sat, Apr 07, 2012 at 01:00:27AM +0300, Itamar Heim wrote: On 04/06/2012 06:00 PM, Ryan Harper wrote: Re-sending this to arch as in our meeting this week we agreed[1] no reason to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but that we needed to enlist the maintainers to work out enforcement. that's easy enough since we use gerrit. if acked by all, i can simply enable 'force sign-off' on patches option in gerrit and it will be enforced... 1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html I do not mind requring the make-my-lawyer-happy line in all Vdsm commits, and I suppose that this would be fine by everybody on vdsm-devel. Tell us when this takes effect, we'll prepare our commit-msg hooks by then. Anything cooler we can do beyond putting SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') grep -qs "^$SOB" "$1" || echo "$SOB">> "$1" at the bottom of .git/hooks/commit-msg ? - Forwarded message from Ryan Harper - From: Ryan Harper Subject: code sign-off/DCO for ovirt projects Date: Tue, 3 Apr 2012 14:59:40 -0500 Message-ID:<20120403195940.gb5...@us.ibm.com> User-Agent: Mutt/1.5.6+20040907i To: bo...@ovirt.org I see that this was discussed in the past on the board list[1] and there didn't seem to be any disagreement with doing DCO sign-off for code contributions. However, not all of the ovirt projects are doing DCO/Sign-off. There are a few commits in vdms.git that have a SoB, ovirt-node seems to be using DCO completely. Nothing in ovirt-engine either. I didn't check all of the ovirt subprojects, but I think it's safe to assume that's not being applied across all of the projects consistently. Can we get that added to the commit process for these projects moving forward? Is there anything else needed beyond maintainers enforcing the need for SoB in patches? 1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
* Itamar Heim [2012-04-06 17:01]: > On 04/06/2012 06:00 PM, Ryan Harper wrote: > >Re-sending this to arch as in our meeting this week we agreed[1] no reason > >to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but > >that we needed to enlist the maintainers to work out enforcement. > > that's easy enough since we use gerrit. > if acked by all, i can simply enable 'force sign-off' on patches option > in gerrit and it will be enforced... Excellent! Let me know when you've enabled the backend changes and I'll confirm I'm seeing Signed-off-by's in the repos. Let's see if we can target by Wednesday this week; I'll add an update item to the ovirt irc agenda to checkpoint. Thanks everyone for getting this working! Ryan > > > > > > >1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html > > > >- Forwarded message from Ryan Harper - > > > >From: Ryan Harper > >Subject: code sign-off/DCO for ovirt projects > >Date: Tue, 3 Apr 2012 14:59:40 -0500 > >Message-ID:<20120403195940.gb5...@us.ibm.com> > >User-Agent: Mutt/1.5.6+20040907i > >To: bo...@ovirt.org > > > >I see that this was discussed in the past on the board list[1] and there > >didn't seem to be any disagreement with doing DCO sign-off for code > >contributions. However, not all of the ovirt projects are doing > >DCO/Sign-off. There are a few commits in vdms.git that have a SoB, > >ovirt-node seems to be using DCO completely. Nothing in ovirt-engine > >either. I didn't check all of the ovirt subprojects, but I think > >it's safe to assume that's not being applied across all of the > >projects consistently. > > > >Can we get that added to the commit process for these projects moving > >forward? Is there anything else needed beyond maintainers enforcing the > >need for SoB in patches? > > > > > >1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html > > -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
On 04/08/2012 02:11 AM, Dan Kenigsberg wrote: > Anything cooler we can do beyond putting > > SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') > grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" > > at the bottom of .git/hooks/commit-msg ? To fix 'git format-patch' (which is used by 'git send-email'), use: git config format.signoff true But that only adds it when you send a patch, not when you make the commit. You can also use 'git commit -s' to add the signoff when you create the commit, but I don't know of a configuration bool that will make that automatic, short of your hack on the commit-msg hook. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
On Sat, Apr 07, 2012 at 01:00:27AM +0300, Itamar Heim wrote: > On 04/06/2012 06:00 PM, Ryan Harper wrote: > >Re-sending this to arch as in our meeting this week we agreed[1] no reason > >to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but > >that we needed to enlist the maintainers to work out enforcement. > > that's easy enough since we use gerrit. > if acked by all, i can simply enable 'force sign-off' on patches > option in gerrit and it will be enforced... > > > > > > >1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html I do not mind requring the make-my-lawyer-happy line in all Vdsm commits, and I suppose that this would be fine by everybody on vdsm-devel. Tell us when this takes effect, we'll prepare our commit-msg hooks by then. Anything cooler we can do beyond putting SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" at the bottom of .git/hooks/commit-msg ? > > > >- Forwarded message from Ryan Harper - > > > >From: Ryan Harper > >Subject: code sign-off/DCO for ovirt projects > >Date: Tue, 3 Apr 2012 14:59:40 -0500 > >Message-ID:<20120403195940.gb5...@us.ibm.com> > >User-Agent: Mutt/1.5.6+20040907i > >To: bo...@ovirt.org > > > >I see that this was discussed in the past on the board list[1] and there > >didn't seem to be any disagreement with doing DCO sign-off for code > >contributions. However, not all of the ovirt projects are doing > >DCO/Sign-off. There are a few commits in vdms.git that have a SoB, > >ovirt-node seems to be using DCO completely. Nothing in ovirt-engine > >either. I didn't check all of the ovirt subprojects, but I think > >it's safe to assume that's not being applied across all of the > >projects consistently. > > > >Can we get that added to the commit process for these projects moving > >forward? Is there anything else needed beyond maintainers enforcing the > >need for SoB in patches? > > > > > >1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html > > > > ___ > Arch mailing list > Arch@ovirt.org > http://lists.ovirt.org/mailman/listinfo/arch ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
Re: code sign-off/DCO for ovirt projects
On 04/06/2012 06:00 PM, Ryan Harper wrote: Re-sending this to arch as in our meeting this week we agreed[1] no reason to not implement DCO (http://kerneltrap.org/files/Jeremy/DCO.txt) but that we needed to enlist the maintainers to work out enforcement. that's easy enough since we use gerrit. if acked by all, i can simply enable 'force sign-off' on patches option in gerrit and it will be enforced... 1. http://lists.ovirt.org/pipermail/arch/2012-April/000433.html - Forwarded message from Ryan Harper - From: Ryan Harper Subject: code sign-off/DCO for ovirt projects Date: Tue, 3 Apr 2012 14:59:40 -0500 Message-ID:<20120403195940.gb5...@us.ibm.com> User-Agent: Mutt/1.5.6+20040907i To: bo...@ovirt.org I see that this was discussed in the past on the board list[1] and there didn't seem to be any disagreement with doing DCO sign-off for code contributions. However, not all of the ovirt projects are doing DCO/Sign-off. There are a few commits in vdms.git that have a SoB, ovirt-node seems to be using DCO completely. Nothing in ovirt-engine either. I didn't check all of the ovirt subprojects, but I think it's safe to assume that's not being applied across all of the projects consistently. Can we get that added to the commit process for these projects moving forward? Is there anything else needed beyond maintainers enforcing the need for SoB in patches? 1. http://lists.ovirt.org/pipermail/board/2011-October/000168.html ___ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch
