Re: [arch-general] [arch-dev-public] [signoff] cronie-1.4.7-4

2011-04-27 Thread Ray Kohler
On Tue, Apr 26, 2011 at 9:13 PM, Gaetan Bisson bis...@archlinux.org wrote:
 [2011-04-26 22:24:31 +0200] Gaetan Bisson:
 The cronie package in [testing] aims at seamlessly replacing dcron.

 Version 1.4.7-5 features several packaging improvements:
 - use anacron for daily/weekly/monthly jobs
 - use run-parts rather than ad-hoc script
 - use vanilla configuration files

 Downside: after upgrading from 1.4.7-4, you will need to restart crond.
 (The configuration must be reloaded so that run-parts is used.)

 Please test and signoff.

The file /etc/crontab must exist, even if it's empty, or inotify
support will be disabled at runtime.

As packaged, without this file:

2011-04-27T09:16:16-04:00 cron.info akherou /usr/sbin/crond[21437]:
(CRON) STARTUP (1.4.7)
2011-04-27T09:16:16-04:00 cron.err akherou /usr/sbin/crond[21437]:
(CRON) This directory or file can't be watched (/etc/crontab): No such
file or directory
2011-04-27T09:16:16-04:00 cron.info akherou /usr/sbin/crond[21437]:
(CRON) INFO (running without inotify support)

After doing touch /etc/crontab:

2011-04-27T10:14:22-04:00 cron.info akherou /usr/sbin/crond[22784]:
(CRON) STARTUP (1.4.7)
2011-04-27T10:14:22-04:00 cron.info akherou /usr/sbin/crond[22784]:
(CRON) INFO (running with inotify support)

I suggest including an empty /etc/crontab in this package, as you made
a conscious decision to enable inotify support in the build. Possibly
it should have some comments in it explaining why it has no content,
instead of a literally empty file.

Other than that, this package is working fine for me, nice work.


Re: [arch-general] [arch-dev-public] [signoff] cronie-1.4.7-4

2011-04-27 Thread Kwpolska
 Possibly it should have some comments in it explaining why it has no
 content, instead of a literally empty file.

I suggest

#m hh dd mo dw command

It will help people read and write their crontabs.
-- 
Cheers,
-- Kwpolska (http://kwpolska.co.cc)
O ascii ribbon campaign - stop html mail - www.asciiribbon.org


Re: [arch-general] [arch-dev-public] [signoff] cronie-1.4.7-4

2011-04-27 Thread Thomas Bächler
Am 27.04.2011 16:19, schrieb Ray Kohler:
 On Tue, Apr 26, 2011 at 9:13 PM, Gaetan Bisson bis...@archlinux.org wrote:
 [2011-04-26 22:24:31 +0200] Gaetan Bisson:
 The cronie package in [testing] aims at seamlessly replacing dcron.

 Version 1.4.7-5 features several packaging improvements:
 - use anacron for daily/weekly/monthly jobs
 - use run-parts rather than ad-hoc script
 - use vanilla configuration files

 Downside: after upgrading from 1.4.7-4, you will need to restart crond.
 (The configuration must be reloaded so that run-parts is used.)

 Please test and signoff.
 
 The file /etc/crontab must exist, even if it's empty, or inotify
 support will be disabled at runtime.

I would consider this an upstream bug that should be reported. inotify
is perfectly capable of handling this situation (as it is done in 'tail
-F' for example).



signature.asc
Description: OpenPGP digital signature


Re: [arch-general] [arch-dev-public] [signoff] cronie-1.4.7-4

2011-04-27 Thread Ray Kohler
On Wed, Apr 27, 2011 at 10:27 AM, Kwpolska kwpol...@gmail.com wrote:
 Possibly it should have some comments in it explaining why it has no
 content, instead of a literally empty file.

 I suggest

    #m hh dd mo dw command

 It will help people read and write their crontabs.

Well, if we want to do this, it would be better to have it match the
actual format of that file, including the user field. ;)

#mm hh dd mo dw user command

I do agree with Thomas' comment that the requirement for this file is
basically a bug, though.


Re: [arch-general] [arch-dev-public] [signoff] cronie-1.4.7-4

2011-04-27 Thread Gaetan Bisson
[2011-04-27 16:28:17 +0200] Thomas Bächler:
 Am 27.04.2011 16:19, schrieb Ray Kohler:
  
  The file /etc/crontab must exist, even if it's empty, or inotify
  support will be disabled at runtime.
 
 I would consider this an upstream bug that should be reported. inotify
 is perfectly capable of handling this situation (as it is done in 'tail
 -F' for example).

I reported it upstream (by email...) and will release a new version with
an empty /etc/crontab.

-- 
Gaetan


pgpkjeonpHoKj.pgp
Description: PGP signature


Re: [arch-general] [arch-dev-public] [signoff] cronie-1.4.7-4

2011-04-27 Thread Gaetan Bisson
[2011-04-27 16:27:03 +0200] Kwpolska:
  Possibly it should have some comments in it explaining why it has no
  content, instead of a literally empty file.

Good idea. I'll do that. :)

 I suggest
 
 #m hh dd mo dw command
 
 It will help people read and write their crontabs.

`man 5 crontab` is extremely well written; documentation in /etc/crontab
should rather go upstream.

-- 
Gaetan