Re: [arch-projects] [archweb] [PATCH] Add “rel” attribute to pagination links

2018-10-21 Thread Olli
On 21.10.18 15:10, Jelle van der Waa wrote:
> On 10/07/18 at 09:01pm, coderkun wrote:
> > Add the “rel” attribute for “prev” and “next” to the pagination
> > links of news and packages.
> 
> Interesting patch, but does any browser even care about these rel tags
> these days? A quick search didn't seem to show it's very useful.

Qutebrowser does support navigation based on the rel attributes:
https://qutebrowser.org/doc/help/commands.html#navigate

Additionally I would consider it as good practice to properly markup
links when possible.

Thanks for your feedback,
Olli


signature.asc
Description: PGP signature


Re: [arch-projects] [archweb] [PATCH] Add “rel” attribute to pagination links

2018-10-21 Thread Jelle van der Waa
On 10/07/18 at 09:01pm, coderkun wrote:
> Add the “rel” attribute for “prev” and “next” to the pagination links
> of news and packages.

Interesting patch, but does any browser even care about these rel tags
these days? A quick search didn't seem to show it's very useful.

> ---
>  templates/news/paginator.html| 4 ++--
>  templates/packages/search_paginator.html | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/templates/news/paginator.html b/templates/news/paginator.html
> index 57fbeb1..524c666 100644
> --- a/templates/news/paginator.html
> +++ b/templates/news/paginator.html
> @@ -4,7 +4,7 @@
>  
>  {% if page_obj.has_previous %}
>   -title="Go to previous page">< Prev
> +title="Go to previous page" rel="prev">< Prev
>  {% endif %}
>  {% for num in paginator.page_range %}
>  {% ifequal num page_obj.number %}
> @@ -15,7 +15,7 @@
>  {% endfor %}
>  {% if page_obj.has_next %}
>   -title="Go to next page">Next >
> +title="Go to next page" rel="next">Next >
>  {% endif %}
>  
>  
> diff --git a/templates/packages/search_paginator.html 
> b/templates/packages/search_paginator.html
> index a748d26..a676626 100644
> --- a/templates/packages/search_paginator.html
> +++ b/templates/packages/search_paginator.html
> @@ -7,7 +7,7 @@
>  
>  {% if page_obj.has_previous %}
>   -title="Go to previous page">< Prev
> +title="Go to previous page" rel="prev">< Prev
>  {% else %}
>  < Prev
>  {% endif %}
> @@ -15,7 +15,7 @@
>  
>  {% if page_obj.has_next %}
>   -title="Go to next page">Next >
> +title="Go to next page" rel="next">Next >
>  {% else %}
>  Next >
>  {% endif %}
> -- 
> 2.19.1

-- 
Jelle van der Waa


signature.asc
Description: PGP signature